Monday, October 30, 2017
2 changes · master
Resolved issues and error corrections
This update corrects spelling and grammar mistakes in developer-facing comments and messages across Odoo's core tooling. It improves clarity and professionalism without changing business features or system behavior.
Original PR description
Description of the issue/feature this PR addresses: Basic spelling and grammar corrections. Current behavior before PR: Comments and output with spelling errors Desired behavior after PR is merged: Correct majority of spelling and grammar issues. Ignoring large amount of software development and international spelling issues. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
This change updates the app switcher code in Enterprise and Studio to follow newer JavaScript coding guidelines. It is an internal cleanup intended to make the code easier to maintain, with no expected change to day-to-day user behavior.
Original PR description
see https://github.com/odoo/odoo/wiki/Javascript-coding-guidelines.
Files changed:
- _web_enterprise/static/src/js/app_switcher.js_
- _web_studio/static/src/js/app_switcher.js_
Some exceptions to the new coding guidelines:
- _on_attach_callback_ and _on_detach_callback_
- fields of objects that are used by many modules
(e.g. 'MenuItem' with 'menu_id')
Note:
- this commit relies on a newly added function in community:
_/odoo/addons/web/static/src/js/utility.js_
new function: **traversePath**
- this function is exactly similar to the old 'visit' in
_web_enterprise/static/src/js/app_switcher.js_
see https://github.com/odoo-dev/odoo/commit/b6dfd5726e8b68024c8448a61d788cc586b70a54