Daily updates from Odoo
Wednesday, December 6, 2017
1 change · master
Code cleanup and technical improvements
This cleans up an obsolete setting from the online sales templates that no longer affects behavior. Removing it reduces confusion for developers and maintainers without changing the customer-facing shopping experience.
Original PR description
The variable was introduced 3 years ago in https://github.com/odoo/odoo/commit/83193566305929539e37699c89a589eceefc6d01 And it's not used anymore: https://github.com/odoo/odoo/search?l=XML&q=optional_products&type=&utf8=%E2%9C%93 I believe it's not used in third-party modules either. Why I care about it? Because I found it in OCA module and tried to figure out what it's for. So, removing this will stop people like me confusing about it. OCA's module that still copy-paste it: https://github.com/OCA/e-commerce/blob/5677e67854f762a35d55797f1087d4ffc495cc13/website_sale_require_login/views/website_sale.xml#L16 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr