Daily updates from Odoo
Tuesday, April 3, 2018
6 changes · master
Enhancements to existing features
Project and timesheet kanban cards now show their action links in more consistent positions. This makes cards easier to scan and reduces layout shifts when different links are available.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This fixes an issue in Odoo's test utilities where readonly fields in editable line items were incorrectly ignored during simulated form saves. It helps ensure automated tests better match real user behavior in the Odoo client, reducing false failures or missed issues around dynamic form updates.
Original PR description
When trying to make a dynamic onchange, I defined a technical not stored boolean field (`flag` in this PR) that is set to True to mark the line as to be recomputed by the parent. This works fine in the Odoo client. However, when creating a test using the `Form` class, I'm facing to a strange behavior: `flag` is always `False`. The fields views doesn't take care about my field that is not stored, invisible and readonly :disappointed: The problem seems to come from the following line: https://github.com/odoo/odoo/blob/master/odoo/tests/common.py#L937 Thank you in advance! -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where a single chatter message could appear to create duplicate message counts for the recipient. Users will now see the correct number of messages in their inbox and starred message indicators, reducing confusion around unread or pending communications.
Original PR description
Id #1824534 Issue: https://www.odoo.com/web?#id=1824534&view_type=form&model=project.task&action=327&menu_id=4720 Description of the issue/feature this PR addresses: when one message send through chatter to the recipient, but at the end side(recipient) it show 2 messages. Current behavior before PR: when one message send through chatter to the recipient, but at the end side(recipient) it show 2 messages. Desired behavior after PR is merged: when one message send through chatter to the recipient, but at the end side(recipient) it show correct count of messages. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update adjusts the Accounting module to support a related test correction. It helps keep automated checks reliable, reducing the risk of future accounting changes being blocked or incorrectly validated.
Original PR description
Complement of 802339c12d1984d1f29e574378cd8df2471ab098 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Timesheet creation now validates fields in a more reliable order, preventing inconsistent error behavior. This helps ensure users receive the correct validation message instead of occasional access-related errors during timesheet entry.
Original PR description
When creating a timesheet, several fields need to be recomputed: - `currency_id` - `group_id` - `department_id` - `is_timesheet` - `validated` When `validated` is computed before the other fields, the recomputation will lead to an `AccessError` because of the rule `hr_timesheet.timesheet_line_rule_user`. Since the test `test_timesheet_validation_user` expects an `AccessError`, the test succeeds. However, from time to time, `validated` is computed last => the `AccessError` is not raised. Actually, a `ValidationError` should be raised in this case (from the `create` override in `timesheet_grid`). Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes inconsistent behavior when users create timesheets by ensuring validation checks happen in the intended order. It helps prevent intermittent errors and makes the expected business validation message appear reliably.
Original PR description
When creating a timesheet, several fields need to be recomputed: - `currency_id` - `group_id` - `department_id` - `is_timesheet` - `validated` When `validated` is computed before the other fields, the recomputation will lead to an `AccessError` because of the rule `hr_timesheet.timesheet_line_rule_user`. Since the test `test_timesheet_validation_user` expects an `AccessError`, the test succeeds. However, from time to time, `validated` is computed last => the `AccessError` is not raised. Actually, a `ValidationError` should be raised in this case (from the `create` override in `timesheet_grid`).