Tuesday, August 21, 2018
1 change · master
Enhancements to existing features
Invoices and sales reports no longer show tax groups whose total amount is 0.00. This reduces confusion for customers by hiding tax lines that do not affect the final amount due.
Original PR description
In some cases, a tax can be applied as a calculatory group, where two child elements zero out each other. In such case, where the total group amount would result in 0.0, we don't want to display this…
In some cases, a tax can be applied as a calculatory group, where two child elements zero out each other. In such case, where the total group amount would result in 0.0, we don't want to display this group. Doing so would be confusing to the spectator. After this commit, this confusion is relieved. **Description of the issue/feature this PR addresses:** - 0.0 results of tax groups generate confusing UI on printed invoice **Current behavior before PR:** - (Calculatory) Tax groups resulting in 0.0 total are printed on inovices **Desired behavior after PR is merged:** - (Calculatory) Tax groups on invoices, resulting in 0.0, are not printed in invoices as they are not relevant to the recipient (after all they don't have any effect on the transaction sum). **Note:** Please do not close, even if not immediately accepted (`wishlist` tag). This PR is meant to be carried along and actively maintained, until this semantic will be completed this way or another. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr @xoe-labs