- [x] Test failure unrelated

This indirection is the only place in the whole codebase, which indirects in
this way.

This block downstream code which relies on:
 - access to the line's company
 - while not necesarily having access to the account's company

(being line's company different than account's company)

Disclaimer: This use case is not officially supported.
However, this indirection does not make sense under the currently
supported model, neither.

**Description of the issue/feature this PR addresses:**
- Downstream module dependency
- Unnecessary indirection

**Current behavior before PR:**
- The currency is taken from the line's account's company

**Desired behavior after PR is merged:**
- The currency is taken from the line's company, directly


**Note:** Please do not close, even if not immediately accepted (`wishlist` tag). This PR is meant to be carried along and actively maintained, until this semantic will be completed this way or another.


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@xoe-labs

- [x] Test failure unrelated
- [x] Manual QA locally, can only be validated on an ee runbot (eg. by group journal entries by product)

Possibly as an oversight, before this commit, product_id was not passed
to the aml on account vouchers.

This caused inexpected behaviour, if products are a relevant dimension in cost
or revenue analysis analysis: Whereas on invoices, this product is copied to aml
on voucher, it is not.

Now products are copied to the amls thereby enabling this reporting dimension.
This is especially usefull for people who use vouchers for minor expenses, but
need some additional visibility to what general or analytic accounts provide.

**Description of the issue/feature this PR addresses:**
- Products are not available on voucher generated amls
- This is a missing analytic dimension as compared to normal invoices

**Current behavior before PR:**
- Products are not copied on vouchers

**Desired behavior after PR is merged:**
- As vouchers permit to choose a product
- Users expects information not to be lost on aml as compared to similar behavior on invoices.

**Note:** Please do not close, even if not immediately accepted (`wishlist` tag). This PR is meant to be carried along and actively maintained, until this semantic will be completed this way or another.


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@xoe-labs

The name of **_prepare_transfer_account** method was changed by **_prepare_transfer_account_for_direct_creation** [here](https://github.com/odoo/odoo/commit/87f0d2eefb77bfc6a9a0fa7f7dcd1475c7c34639#diff-ce53c5491cb2c9ab3dbbd41ecabf594f)

But, I think by mistake was changed the name of **_prepare_transfer_account** method  by **_get_default_banck_journals_data** and that it's wrong and occurs the following error when I try install **l10n_mx** module:

``` python
  File "/.repo_requirements/odoo/odoo/tools/convert.py", line 750, in parse
    self._tags[rec.tag](rec, de, mode=mode)
  File "/.repo_requirements/odoo/odoo/tools/convert.py", line 342, in _tag_function
    _eval_xml(self, rec, env)
  File "/.repo_requirements/odoo/odoo/tools/convert.py", line 193, in _eval_xml
    return odoo.api.call_kw(model, method, args, {})
  File "/.repo_requirements/odoo/odoo/api.py", line 749, in call_kw
    return _call_kw_multi(method, model, args, kwargs)
  File "/.repo_requirements/odoo/odoo/api.py", line 736, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "<decorator-gen-174>", line 2, in try_loading_for_current_company
  File "/.repo_requirements/odoo/odoo/api.py", line 372, in loop
    result = [method(rec, *args, **kwargs) for rec in self]
  File "/.repo_requirements/odoo/odoo/api.py", line 372, in <listcomp>
    result = [method(rec, *args, **kwargs) for rec in self]
  File "/home/odoo/odoo-master/addons/account/models/chart_template.py", line 170, in try_loading_for_current_company
    self.load_for_current_company(15.0, 15.0)
  File "/home/odoo/enterprise/account_reports/models/chart_template.py", line 9, in load_for_current_company
    res = super(AccountChartTemplate, self).load_for_current_company(sale_tax_rate, purchase_tax_rate)
  File "/home/odoo/odoo-master/addons/account/models/chart_template.py", line 240, in load_for_current_company
    self._create_bank_journals(company, acc_template_ref)
  File "/home/odoo/odoo-master/addons/payment/models/chart_template.py", line 11, in _create_bank_journals
    res = super(AccountChartTemplate, self)._create_bank_journals(company, acc_template_ref)
  File "/home/odoo/odoo-master/addons/account/models/chart_template.py", line 311, in _create_bank_journals
    for acc in self._get_default_bank_journals_data():
  File "/home/odoo/odoo-master/addons/account/models/chart_template.py", line 311, in _create_bank_journals
    for acc in self._get_default_bank_journals_data():
  File "/usr/lib/python3.5/bdb.py", line 48, in trace_dispatch
    return self.dispatch_line(frame)
  File "/usr/lib/python3.5/bdb.py", line 67, in dispatch_line
    if self.quitting: raise BdbQuit
odoo.tools.convert.ParseError: "" while parsing /home/odoo/odoo-master/addons/l10n_mx/data/account_chart_template_data.xml:4, near
<function model="account.chart.template" name="try_loading_for_current_company">
            <value eval="[ref('l10n_mx.mx_coa')]"/>
        </function>
2018-08-17 17:26:25,632 3917 INFO test odoo.service.server: Initiating shutdown
2018-08-17 17:26:25,633 3917 INFO test odoo.service.server: Hit CTRL-C again or send a second signal to force the shutdown.
```:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr