Friday, September 7, 2018
1 change · master
Resolved issues and error corrections
The delivery settings now show the option that controls whether shipping is invoiced on delivery, instead of applying it invisibly after order confirmation. This helps prevent unexpected or repeated shipping charges on partially fulfilled orders and gives users clear control over when shipping should be billed.
Original PR description
In case a delivery method was not applied on an order before confirmation the field invoice_shipping_on_delivery was set to True which implied an extra line for each delivery fulfilled. This could…
In case a delivery method was not applied on an order before confirmation the field invoice_shipping_on_delivery was set to True which implied an extra line for each delivery fulfilled. This could mean that an order which was partially fulfilled was getting multiple shipping lines or an order which was maybe not intended to be billed for shipping was getting automatically shipping costs applied. Both situation are rational, but the user needs to have the choice to either remove the automatically set option after confirmation or does apply this option on purpose even before confirmation. Adding the field in the view is an easy and correct fix as it makes the magic somehow transparent and editable. @mart-e @nim-odoo May I ask you to merge this for me? This one was producing a LOT of troubles. The solution is simpler than I expected and will finally make the feature complete. It is a typical UI Bug. Another solution would be to remove the code/feature, but I think this would be worse in terms of stable policy. Info: @wt-io-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr