Odoo Changelog — 2018-11-21

Wednesday, November 21, 2018

2 changes · master

Refactoring(2)

Code cleanup and technical improvements

[MERGE][REF] survey: break survey composer inherit on mail composer

Coremastersurvey

The survey invitation tool was cleaned up so it no longer carries unused email composer behavior behind the scenes. This makes the survey module easier to maintain while keeping the invitation-sending experience focused on its business purpose.

Original PR description

Purpose of this merge is to clean survey composer model. It currently inherits from mail.compose.message which also inherits from mail.message. That means a lot of fields and behavior coming from…

Purpose of this merge is to clean survey composer model. It currently
inherits from mail.compose.message which also inherits from mail.message.
That means a lot of fields and behavior coming from both models are present
on the survey composer. Most of them are not necessary as

 * send_mail method of mail composer is overriden and super is not called.
   Nothing from the complex behavior of mail.compose.message is used;
 * templates are just basically supported in survey, notably mass mailing or
   mass posting mode are not used;
 * methods from mail.message should not be available on survey composer;
 * most m2m fields coming from mail.message and composer have no use here;

In this merge we simply add the required fields and template behavior on
the survey composer and remove inheritance on mail.compose.message.

In this merge we also rename survey.mail.compose.message to survey.invite
as it simplifies code and is easier to understand.

This commit is linked to task ID 1909804.

#survey#invitations#maintenance

[REF] hr_appraisal: update to survey composer refactoring

PR #3098

Enterprisemasterhr_appraisal

The appraisal module was updated to work with recent changes in Odoo's survey tools. This keeps appraisal survey invitations functioning correctly after the underlying survey component was renamed and refactored.

Original PR description

Purpose is to adapt enterprise code to community changes in survey module.

This commit is linked to task ID 1909804.

#appraisals#surveys#compatibility

Purpose of this merge is to clean survey composer model. It currently inherits from mail.compose.message which also inherits from mail.message. That means a lot of fields and behavior coming from both models are present on the survey composer. Most of them are not necessary as * send_mail method of mail composer is overriden and super is not called. Nothing from the complex behavior of mail.compose.message is used; * templates are just basically supported in survey, notably mass mailing or mass posting mode are not used; * methods from mail.message should not be available on survey composer; * most m2m fields coming from mail.message and composer have no use here; In this merge we simply add the required fields and template behavior on the survey composer and remove inheritance on mail.compose.message. In this merge we also rename survey.mail.compose.message to survey.invite as it simplifies code and is easier to understand. This commit is linked to task ID 1909804.