Tuesday, November 27, 2018
1 change · master
Enhancements to existing features
This update simplifies how product attribute information is included on eCommerce product pages. It makes the page structure easier to maintain and reduces the risk of future website display issues, especially in multi-website setups.
Original PR description
Historically, the `website_sale.product_attributes` was a customize option. That template became a normal view (removed customize_show attribute) with bbd2d0e42 As it is now a normal view, there is…
Historically, the `website_sale.product_attributes` was a customize option. That template became a normal view (removed customize_show attribute) with bbd2d0e42 As it is now a normal view, there is no reason left to be an xpath view and we can move itw code directly into the inherited template. That way, we can simplify the `website_sale_comparison.product_attributes_body` template that was doing a cross xpath (inheriting `website_sale.product` but xpathing a DOM element from `website_sale.product_attributes` which was also inheriting `website_sale.product`). Note that cross xpath was not working well with multi website but was fixed with 410c07283b Still, we should avoid doing cross xpath when possible (originally it was not possible since the view was a customize_show) as it is hard to grep DOM element to find possible breaking xpath when doing changes on DOM. This is the reason of this commit. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr