Daily updates from Odoo
Friday, December 7, 2018
9 changes · master
Resolved issues and error corrections
Survey test mode now uses a dedicated testing link instead of a hidden placeholder token. This keeps real survey access tokens reserved for invited participants and limits test access to authorized survey staff, reducing accidental or unauthorized use.
Original PR description
Purpose of this commit is to clean a bit the test mode of surveys before working a bit on ACLs and survey access. Currently when taking a survey with a magic 'phantom' token it generates a test…
Purpose of this commit is to clean a bit the test mode of surveys before working a bit on ACLs and survey access. Currently when taking a survey with a magic 'phantom' token it generates a test answer allowing to go through the survey process. However it has several drawbacks : * 'phantom' is not a real token. Token parameter should be used only for real tokens and avoid having corner case when managing simple parameter; * token should only be used to ensure people have been granted access to answering surveys; * it is currently available for every users; * it is pure unwanted magic; In this commit we add a separate route for testing surveys that create the test answer and then redirects to the survey with this answer. It is now also limited to survey managers or survey officers testing their own surveys. Survey JS tour now uses the standard URL and not the testing one. Indeed as testing is now limited to survey officers and managers tour should test real life use cases. This commit is linked to task ID 1916034 and PR #29339.
Survey pages on the website now reuse the standard survey styling instead of maintaining duplicated asset lists. This reduces the risk of visual inconsistencies or missing updates while keeping the website look and feel intact.
Original PR description
Purpose ======= Survey assets were incorrectly overridden in the website_survey module and all copy/pasted. This will correctly include the survey_assets template and get rid of these copy/pasted assets references, while keeping the website style on survey pages.
Payroll salary rules can now correctly treat a quantity or rate of zero as an intentional value instead of replacing it with a default. This avoids incorrect payslip totals when a rule is meant to produce no amount.
Original PR description
Fixes https://github.com/odoo/odoo/issues/29205 Should probably be backported to previous versions. /cc @tivisse -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr @xoe-labs
The accounting dashboard now shows invoice counts that match the selected filters. This fixes misleading demo data and dashboard figures so users can rely on the displayed invoice totals.
Original PR description
Issue #27859 Description of the issue/feature this PR addresses: The numbers on the accounting dashboard are not consistent with the number of invoices. Actually it was more a problem in the demo data of l10n_generic_coa Current behavior before PR: Wrong Number of Invoices Desired behavior after PR is merged: Correct Number of Invoices based on Filter -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix corrects an oversight in website page properties related to redirect type handling. It helps ensure website redirects behave as intended when page settings are configured, reducing the risk of incorrect navigation for visitors.
Original PR description
Related to #2924b77b6f5 Similary to #8ca728bb9312 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A timing issue in an automated test for the Lunch app was corrected. This helps keep daily quality checks reliable, especially before 10 a.m., without changing user-facing lunch ordering features.
Original PR description
In https://github.com/odoo/odoo/commit/e8ac4d79964b852f21e272bc804d151b5b356791 we introduced an error in the test_search_available_today which broke the test before 10 am everyday
This change gives a growing automated Studio test more time to complete. It helps reduce occasional false failures in the testing system, improving confidence in development checks without changing the user experience.
Original PR description
This test tour is growing days after days so it's now time to raise its timeout (it is currently failing on runbot from time to time).
Fixes an issue that could cause the shop coupon walkthrough to fail because it relied on testing-only tools that are not available in normal website use. This makes the coupon-related tour more reliable for users and internal validation.
Original PR description
The tour shop_sale_coupon was changed to use the testUtils.dom.click method when we introduced the new test utility functions. Probably because the filename ends with 'test.js'. Obviously, this is not correct, because the testUtils function is not imported. To prevent issues in the future, we simply remove the two problematic calls. Another solution was to import the testUtils module, however, I think that it is simpler not to use those functions at all in tours, because tours can be executed in the web client/website, and in that case, they do not have access to the test utility functions.
A configuration issue in website calendar appointments was corrected so related records are connected through the proper fields. This helps avoid incorrect or unreliable appointment data relationships in the website calendar feature.