Monday, January 7, 2019
3 changes · master
Resolved issues and error corrections
Website pop-up dialogs now place the primary action button in the expected corner, making important actions easier and more intuitive for users to choose. The update also includes small layout fixes to improve consistency and readability in affected website screens.
Original PR description
Modal primary button should be the one in the corner (left if buttons aligned left, right if buttons aligned right) as in the Bootstrap doc. More than a simple guideline, the user will intuitively click on the button in the corner as it is supposed to be the primary one. Plus some DOM fixes (o_technical_modal was missing, H2 was too big especially since BS4) task-1922120
This fixes a broken option that lets users search through available fields when building domain filters. The search input is now correctly passed through and enabled for mass mailing, making it easier to configure mailing audiences.
Original PR description
PR #27788 introduced the possibility to add a `showSearchInput` property to domain widgets, which should allow users to fuzzy search on the fields list.
This feature was buggy and was not properly working when the field was declared with such option:
```xml
<field name="domain_field" widget="domain" options="{'showSearchInput': true, 'model': 'model_field'}"/>
```
This commit fixes that problem, and BTW it enables the feature in `mass_mailing`, which is one of the modules where this feature is most useful.
Another question that I still cannot understand is: **Why default to false?** But I didn't want to change that in this PR for now.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@Tecnativa @mge-odoo @qsm-odooThe UPS delivery website modal now places the main action button in the expected corner position. This makes the dialog easier and more intuitive for customers to use, reducing the chance of clicking the wrong option.
Original PR description
Modal primary button should be the one in the corner (left if buttons aligned left, right if buttons aligned right) as in the Bootstrap doc. More than a simple guideline, the user will intuitively click on the button in the corner as it is supposed to be the primary one. task-1922120