Thursday, January 10, 2019
6 changes · master
Resolved issues and error corrections
This update restores efficient lookup of activities by the user who created them after an internal field change. It helps keep activity-related searches responsive, especially in databases with many records.
Original PR description
The activity create_user_id field is now replaced by magic create_uid field. Since most of the search are done on this field, create_uid should be indexed as create_user_id was.
The automated payment registration walkthrough now succeeds even when only the required module set is installed. This keeps standalone testing reliable by ensuring the needed payment option is available during the flow.
Original PR description
The tour was failing when only the module (and its dependencies) was installed (but was correctly succeeding on runbot). The issue here was due to an invisible field in the 'Register Payment' wizard. The field was set invisible with the onchange because there was only one payment method on the journal. The module 'account_check_printing' adds another payment method (check) and the field becomes visible.
Odoo now only sends an activity assignment notification when the assigned user actually changes. This prevents duplicate or unnecessary emails and avoids extra permission checks when an activity is saved without changing ownership.
Original PR description
The current implementatipon of write on mail.activity will send a notification to the user every time a write is made on user_id. To avoid to send notification / mail if the user_id is given but doesn't change, we can simply filter the records. This will also avoid to check assignation rights in this case. Task: 1905086
A test flow was adjusted so it no longer depends on an uncommon optional payment module being installed. This helps keep standard community installations reliable by preventing a payment registration test from getting stuck on a field that may not appear.
Original PR description
With the current test_main_flows dependencies, the tour does not pass in community. Since rev. odoo/odoo@32db86e the `extra_trigger` waiting for `payment_method_id` is never reached because the onchange who is supposed to display this field hides it because there is only one payment method on the journal. The second payment method is added by the module account_check_printing but we don't want to add it in the dependencies because this module is not very common. Note that this `extra_trigger` was meant to wait for the onchange triggered by the journal modification on the 'Register Payment' modal but this modification is not useful as the journal is already 'Bank (USD)' by default.
This fix prevents an error in the Lunch HR module when an employee has no address and lunch locations cannot be determined. It helps keep lunch ordering and related tests stable for users with incomplete employee address data.
Original PR description
When the two conditions are false, the locations_ids is never assigned a value. For example when the current user's employee has no address. Making the click_all test fail: http://runbot.odoo.com/runbot/build/424279
This fix restores expected dropdown behavior in batch payment reconciliation after a Bootstrap update caused some menus to stop opening correctly. It keeps the payment workflow usable and avoids disruption for accounting users.
Original PR description
Bootstrap is updated from 4.1.3 to 4.2.1 with: https://github.com/odoo/odoo/pull/29949. With that update, Bootstrap somehow introduced a regression which prevents using 'javascript:void(0)' on a dropdown-toggle element (see https://github.com/twbs/bootstrap/issues/27903) and will only fix that in 4.3 with https://github.com/twbs/bootstrap/pull/27912 As using javascript:void(0) is not part of our conventions anyway and that the related elements are already default prevented anyway, changing them to href="#" solves the problem.