Friday, February 1, 2019
2 changes · master
Enhancements to existing features
The customer portal now keeps the Sign button disabled until a user has actually provided a signature. This prevents users from submitting an empty signature area and seeing an avoidable error message, making the signing flow smoother.
Original PR description
Before this commit, it was possible for the user to click on the Sign button even when the signature area was empty, which would lead to an error message. Now we disable the button when the area is empty. Related to enterprise PR: odoo/enterprise#3535 PR: #30653
The signing process now prevents users from clicking the Sign button before entering a signature, avoiding confusing error messages. This also makes related HR contract salary signing checks more reliable by waiting until the signature field is complete.
Original PR description
Before this commit, it was possible for the user to click on the Sign button even when the signature area was empty, which would lead to an error message. Now we disable the button when the area is empty. With this change, we can adapt the hr_contract_salary tour to make it more deterministic by correctly clicking on the Sign button only after the signature area has been filled. Thanks to @d-fence for the idea in PR #3281. Related to community PR: odoo/odoo#30653 PR: #3535