Monday, February 11, 2019
1 change · master
Code cleanup and technical improvements
This update renames internal invoice creation methods in sales and repairs so their purpose is clearer to developers. It should not change business workflows, but it reduces confusion and makes future maintenance safer.
Original PR description
Purpose ======= The method named "action_invoice_create" in the sale_order model did not make sense: - this method is not an action (it returns the ids of created invoices) - it is not used as an action on any xml buttons - it has no reason to be private This was probably a "real" action somewhere in the past but now it's just too confusing. (The method in repair.order was also renamed for the same reasons).