Daily updates from Odoo
Friday, February 15, 2019
8 changes · master
Resolved issues and error corrections
This fix makes the Payroll benefits screen open with the correct calendar view by default. It prevents users from landing on a broken or unavailable default view, making the workflow more reliable.
This update fixes how benefit-related buttons are created in Payroll by using the standard page-building method instead of manually assembling them. It reduces the risk of display or translation issues for users managing payroll benefits.
Original PR description
Use the proper jquery API instead of handcrafting dom elements. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change restores the ability for authorized users to post product reviews and blog comments even when no special access token is provided. It also standardizes star ratings so averages stay accurate when different rating methods are used.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where the celebration message shown at the end of a guided tour could disappear immediately after the final click. Guided tours now finish more reliably, giving users the intended confirmation that they completed the process.
Original PR description
Before this rev., steps were consumed on 'mousedown' events. This caused an issue with the RainbowMan displayed at the end of tours (which closes itself on 'click' events outside its $el). Here is what occured when the user clicked on the last step's element: - 'mouseenter' event triggered - current step consumed, as well as the tour, and a RainbowMan is instantiated and appended to the DOM - 'click' event triggered - RainbowMan closes itself because of that 'click' event Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update changes the displayed name of the website lead generation module so it no longer duplicates another module name. This helps users and administrators distinguish the modules more easily when managing CRM-related features.
Original PR description
The module has the same name as the module crm_iap_lead. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change removes redundant internal code that was copying data within the same shared cache. It simplifies the underlying system logic and may slightly reduce unnecessary processing, while keeping existing behavior unchanged.
Original PR description
As of commit d7190a3 ("[IMP] api: reindex the record cache to improve cache hit"), the cache is shared between environments. The code in determine_value() labelled as "HACK: if result is in the wrong…
As of commit d7190a3 ("[IMP] api: reindex the record cache to improve
cache hit"), the cache is shared between environments. The code in
determine_value() labelled as "HACK: if result is in the wrong cache,
copy values" is therefore now redundant.
It is still possible for "recs.env" to differ from "env", but
"recs.env.cache" and "env.cache" will always point to the exact same
cache object. This code is therefore needlessly copying values from
the cache back to the same cache.
Signed-off-by: Michael Brown <mbrown@fensystems.co.uk>
Description of the issue/feature this PR addresses:
Code labelled "HACK" is present in odoo/fields.py but is now entirely redundant. It should be removed to ease understanding of the code and to remove a needless performance impairment.
Current behavior before PR:
All automated tests pass.
Desired behavior after PR is merged:
All automated tests continue to pass.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis update makes financial report tests use a fixed date during execution, preventing rare failures when tests run across midnight. It helps keep automated checks stable and avoids false alarms in development workflows.
Original PR description
These tests fail when runned at 23:59:59 due to multiple calls to fields.Date.context_today because a context_today is done one day and the next one is done the next day.
This fix ensures the mobile barcode field starts correctly by returning the expected startup result. It helps prevent subtle loading or initialization issues for users working with barcode scanning on mobile devices.
Original PR description
Previous commit : 199312090a6c7af9df03dac35ad5719eabd64a77 Task ID: 1924766