Tuesday, March 5, 2019
8 changes · master
Resolved issues and error corrections
This fix updates website test code to avoid depending on the web editor base component. It helps keep automated website testing more reliable and easier to maintain without changing business-facing website features.
Original PR description
Related to da1899af48902edec7ac6ed8dd5ae2f8b02ec689 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where the bus longpolling service did not properly remove its event handlers when it was shut down. The change helps prevent lingering background handlers that could cause unstable behavior or test failures.
Original PR description
`this._id` is overriden by the crosstab_bus, so the event handlers weren't unbound at destroy. Manual forwardport of odoo/odoo#31578, as we need this for another branch, in which it makes tests fail. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change removes unnecessary internal checks and duplicated logic in inventory and purchase order processing. It helps keep stock validation and purchasing flows simpler and less error-prone without changing day-to-day user workflows.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Point of Sale orders now apply the account mappings defined in fiscal positions when creating accounting entries. This ensures income and receivable amounts are posted to the correct accounts, matching the behavior already available in Sales.
Original PR description
accounts mapping of fiscal positions should work on the PoS as it works in Sales Description of the issue/feature this PR addresses: Setup a fiscal position with account mapping for income account and receivable account Make a pos_order with the fiscal position Current behavior before PR: When pos is closed, account mapping is not done and the account_move does not take the mapped income account nor receivable account Desired behavior after PR is merged: The account_move should take the mapped income account and receivable account task: https://www.odoo.com/web#id=1916865&action=333&active_id=1428&model=project.task&view_type=form&menu_id=4720 Original commit by @invitu
Shipping packages are now only created after users confirm the packaging wizard, so cancelling no longer creates unwanted packages. Default shipping weight is now based on the actual delivery being packed, improving accuracy for shipping operations.
Original PR description
This PR fix the issues with the default shipping weight and the creation of a packaging regardless of the 'discard button'. Obsolete code was removed in the process. TaskID: 1924875
Reordering rules now only show relevant stock locations based on the selected warehouse. This helps users avoid choosing an incorrect location, reducing inventory planning mistakes.
Original PR description
The model reordering rules (stock.warehous.orderpoint) has a field waherouse_id and location_id. This commit will restrict the domain on location_id depending on the warehouse set. The user can now choose only locations child of the warehouse view location or location with no warehouse parent. Task : 1933828 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a rare issue where pop-up details could remain visible after moving items in the Gantt view. Popovers are now tied to the relevant Gantt row so they are removed properly when the view updates, keeping scheduling screens cleaner and less confusing.
Original PR description
Before this rev. there were still remaining popovers in some rare cases when moving pills (and thus after update). Now, the popovers are placed inside the gantt row (instead of the <body>) so it is correctly removed. Manual forwardport of 379b6740cd as this is needed for the update jquery branch. Task 1945899
This fix repairs broken automated tests for barcode-based stock workflows so they correctly reflect expected behavior. It helps prevent false failures and missed issues in future updates, improving confidence in the stock barcode module.
Original PR description
These tests were completely broken because: 1. The assertPageSummary function cannot take false as argument, and doing it resulted in a crash that prevented the other assertion from running, thus hiding the following two issues. 2. Some assertion functions that tested the presence of a class that is supposed to hide the element were forcing the element to be present in the dom to begin with, which was wrong according to the qweb template. Not being in the dom is now correctly interpreted as being "not visible". 3. Some assertions in the tests were functionally wrong and had to be fixed according to the specs of the module. 4. The for loop was using an undefined variable as well as passing a dom element to assertLineQty instead of a jQuery element.