Friday, March 8, 2019
4 changes · master
Resolved issues and error corrections
This change makes previously unreliable website editor tests run consistently again by restoring timing safeguards. It also improves how test results are compared so harmless differences in attribute order no longer cause failures, helping maintain confidence in future updates.
Original PR description
Those tests were skipped because they were failing non-deterministically. This commit aims to make them deterministic by putting back some guard promises that were lost during the jquery update adaptation. This commit also fixes a lingering issue with one of the asserts. We observed that sometimes, the "alt" and "title" attributes where both present on the element but displayed in different order in the string returned by wysiwyg.getValue(). This is because there is no set order in the attribute returned by jQuery.html(). Because of that, I replaced the simple sring test by a thorough manual comparison of the result that is expected to be equivalent.
This fixes autocomplete dropdown styling and test flows affected by the jQuery update. Users will continue to see the correct highlighted option while navigating dropdown suggestions, avoiding confusing visual behavior.
Original PR description
*partner_autocomplete,test_main_flows In jQuery 3, the active element in autocomplete dropdowns is no longer identified with class 'ui-state-focus' on the <li/>, but with class 'ui-state-active' is on its child <a/>. Moreover, the background color of the active element is now set on the <a/> instead of the <li/>. This rev. adapts scss rules accordingly, and selectors in the main_flow_tour. Issue reported on the jquery update pad. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Renaming a file upload field in Studio now updates its related filename field instead of creating an extra one. This keeps custom field setups cleaner and avoids confusion from duplicate filename fields.
Original PR description
When creating a binary field with Studio, another char field containing the filename is created. However, after renaming the binary field, another filename field was created, instead of renaming the existing one. The filename field is now correctly renamed and no duplicate is created. Task 1945366
Autocomplete dropdowns in the Enterprise web interface now display correctly after the jQuery 3 update. This prevents visual glitches in suggestion menus, helping users select options reliably while working in Odoo.
Original PR description
This rev. is the enterprise counterpart of PR odoo/odoo#31693.