Tuesday, March 12, 2019
2 changes · master
Resolved issues and error corrections
This fixes an issue where the accounting reconciliation popover no longer showed line details after a Bootstrap update. Users can again view the detailed information they need while reconciling entries, avoiding confusion and extra navigation.
Original PR description
commit 4697d7448010376397f7150b84c207978ab3010e update our bootstrap version to 4.3.1, one change of that version is that bootstrap now escape the content of popover and title removing the table element. https://blog.getbootstrap.com/2019/02/13/bootstrap-4-3-1-and-3-4-1/ This result in the popover in the reconciliation widget being empty. Therefore since the content of the popover was safe as it was rendered by Qweb.render, we disabled completely the sanitizer for the popover in the reconciliation widget.
This fix ensures that crash messages are shown correctly in Firefox again after a previous jQuery update stopped them from appearing. Users will now see the expected error dialog instead of missing feedback when something goes wrong.
Original PR description
After the update of jQuery, crashes were no longer displayed (in dialogs) on browsers using the unhandled-rejection-polyfill lib (e.g. firefox). This was due to a bad conversion from ES6 to ES5. Issue reported on the jquery update pad. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr