Thursday, March 14, 2019
2 changes · master
Resolved issues and error corrections
Automated browser tests now detect more types of unexpected page errors, so failures are caught sooner and more reliably. A website event test was also adjusted to wait until page changes are fully ready before saving, reducing false failures in testing.
Original PR description
Actually, when running browser_js tests, the test automatically fails when a console error is seen. In some cases, an exception can be thrown during a tour but without console error. In that case, another type of devtools protocol event is fired: Runtime.exceptionThorwn. This event is not catched by the browser_js test. With this commit the above mentioned event is catched and the test is directly considered as failed.
This update fixes a small typo in an internal action identifier within the Time Off module. It helps keep system references consistent and reduces the chance of minor configuration or maintenance confusion.
Original PR description
**Description of the issue/feature this PR addresses:** Typo detected 😋 I pushed to saas-12.1 safely because I don't know if this can be done in stable. If it can be done in stable, then tell me and I update the branch. **Current behavior before PR:** Typo in xmlid name. **Desired behavior after PR is merged:** Fixed typo. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr