Friday, March 22, 2019
2 changes · master
Enhancements to existing features
The Mail module now displays the message resend alert with stronger visual styling. This makes the warning easier for users to notice and understand before taking action.
Original PR description
Description of the issue/feature this PR addresses: Mail module (Minor view Improvement) Current behavior before PR:  Desired behavior after PR is merged:  -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This fix changes automated web tests to close pop-up windows the same way a user would, by focusing and clicking the close button. This helps prevent cleanup issues with date and time pickers, reducing false test failures and improving reliability.
Original PR description
During the clickEverywhere test, when a modal is opened, the hide method is called to bypass it. This is not realistic and does not work in some cases. For example in Point of sale, menu "Reporting/Sales Details", a modal is opened with a DateTimePicker (tempus dominus) already opened. When hiding or closing the modal, the DateTimePicker needs to perform some cleanup. If the modal is simply hidden, the DateTimePicker is not cleanly destroyed. With this commit, a modal is closed by clicking on its close button and before that, the focus is set on the close button to let the datepicker widget do its stuff on losing focus. Also, a more realistic click is done by triggering more events (code adapted from tour helper).