Wednesday, March 27, 2019
2 changes
Resolved issues and error corrections
Fixed an issue where opening the website live chat window could crash instead of showing the chat. This ensures visitors can start conversations normally, helping avoid missed support or sales interactions.
Original PR description
Before this commit, when opening a website livechat window, it crashed with the following error message in the dev tools: ``` Cannot read property 'html' of `undefined` ``` The problem was caused by the rendering of the chat window header before the chat window widget is even mounted in the DOM. This error has been introduced by the migration from jQuery 1.12 to 3, in which most occurrences of `$.Deferred` have been turned into `Promise` [1]. `Widget.appendTo()` returns a `Promise` (was `$.Deferred` before). A `Promise` is always asynchronous, whereas a `$.Deferred` with jQuery 1.12 may be either synchronous or asynchronous. In the case of the website livechat window, the implementation with `$.Deferred` was always synchronous, which is no longer the case now. [1] https://github.com/odoo/odoo/commit/126fb33f6a74916c808c8e988f55faf82f0b5759
This fixes bank reconciliation rules so they can apply multiple taxes where needed instead of being limited to one. It helps accounting teams reconcile transactions more accurately, especially in localizations with more complex tax setups.
Original PR description
task 1877574 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr