Thursday, April 4, 2019
2 changes · master
Resolved issues and error corrections
Creating a new purchase quotation from a purchase agreement could fail with an error. This fix removes unnecessary manual rounding so Odoo can handle monetary rounding automatically, allowing the quotation process to complete normally.
Original PR description
- in purchase there are 3 fields that computes by '_amount_all', so it is called 3 times. but, round method has 'ensure_one' therefore it gives singleton error. - So, removed rounding as there is need of rounding explicitly since these are monetary fields which will be rounded automatically. Related to Issue: 1948645 Description of the issue/feature this PR addresses: Traceback when creating new quotation from purchase aggrements Current behavior before PR: Traceback when creating new quotation from purchase aggrements Desired behavior after PR is merged: Traceback resolved when creating new quotation from purchase aggrements Issue: https://www.odoo.com/web#id=1948645&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.4ee8640ed26691650fc5c75a86206211 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Creating a manufacturing work order from the Gantt or grid view could fail because a required rounding value was missing. This fix ensures the process uses a safe default only when needed, preventing the crash and allowing users to create work orders normally.
Original PR description
- In master for grid view we have added + icon to create order,at time of mrp.workorder creation from grid, default_get is not called for uom.uom, so we don't have default value of rounding. - therefore, set rounding value to '0.01' when there is no rounding. Related to Issue: 1957994 Description of the issue/feature this PR addresses: traceback when I create a work order from Gantt view Current behavior before PR: traceback when I create a work order from Gantt view Desired behavior after PR is merged: traceback resolved when I create a work order from Gantt view Pad: https://pad.odoo.com/p/r.2f546e232fb318a8b9aeec3fc9950b1c Issue: https://www.odoo.com/web#id=1957994&action=327&model=project.task&view_type=form&menu_id=4720 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr