Daily updates from Odoo
Thursday, April 18, 2019
7 changes · master
Enhancements to existing features
When a module is uninstalled, related mail tracking records are now removed so outdated or inaccessible field history is not kept in the database. This reduces clutter and helps prevent users from seeing tracking information whose original access rules can no longer be verified. A related cleanup also improves internal naming and avoids showing empty messages based only on subtype text.
Original PR description
[IMP] mail: Delete tracking values when uninstalling module -------------- ### Purpose mail.tracking.values should be deleted when the corresponding field is deleted (when the module which defined it…
[IMP] mail: Delete tracking values when uninstalling module -------------- ### Purpose mail.tracking.values should be deleted when the corresponding field is deleted (when the module which defined it is uninstalled). Firstly because we don't want useless data in db. Secondly because the groups associated with the field can no longer be checked if it was deleted. As we don't know to whom the value was restricted, the value should not be displayed anyway. Note: this case was fixed in saas-12.2 by b9e96b7 but the proper way to fix it is to delete the tracking values. ### Specification Delete `mail.tracking.value` when the associated `ir.model.fields` is deleted. Two alternatives were considered: 1. Change the `field` field of `mail.tracking.value` from Char to a m2o to `ir.model.fields` which allows to use delete oncascade. This implies to modify existing code, but more importantly it adds database queries. 2. Override the unlink method of `ir.model.fields` to first unlink associated tracking values. The first method is probably cleaner but the second method was nonetheless chosen as we don't want to impact performance in the main tracking flow only to better support module uninstalls which happens rarely. Note: when a module is uninstalled, `ir.model.fields` are unlinked one by one (in a for loop). Tracking values are therefore also unlinked field by field. Batchifying field deletion would greatly reduce the amount of queries. [IMP] mail: Rename groups field of mail.tracking.value ---------------- This commit renames the `groups` field into `field_groups`. The previous name was impossible to grep as the word `groups` is everywhere in the code base. Also the new name better follows the implicit convention that fields related to the tracked field all start with `field_`. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The CRM lead generation screens now show credit consumption messages that are easier to understand and translate. This improves usability for teams using lead mining and website lead reveal features by making credit feedback clearer across languages.
Original PR description
Improve the usability of crm_iap_lead and crm_iap_lead_website. Task-ID 1965687 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This change updates the project's requirements list, likely restoring a missing update from an earlier maintenance change. It helps keep the system setup consistent for installations and deployments, with no direct functional change expected for everyday users.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change reduces unnecessary warning messages during installation when a database view is temporarily dropped and then recreated as expected. It helps avoid false alarms in automated checks while keeping the installation process behavior unchanged.
Original PR description
This problem appears when the module l10n_be_hr_payroll_fleet is installed. This module inherits from hr.contract and will create and modify some fields. By modifying contract's table, PostgreSQL will drop the view from hr_contract_employee_report. At the end of the installation, PostgreSQL will check if tables exist, it isn't the case for the view from hr_contract_employee_report, so it will recreate it. It's the normal behavior. But when a table is missing, a warning is logged and create problem with Runbot. For this reason, it's better to log an Info and not a Warning message. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Indian localization demo data no longer changes the main company’s country. This prevents conflicts that caused errors when using other localization demo data, such as Italy, making demo setups more reliable.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Italian demo data gives errors because of the main company being set to Indian. We should avoid doing that. Desired behavior after PR is merged: No errors and no country being set on the main company in the demo data. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Indian payroll module was updated to use the correct payroll structure setting name. This prevents installation errors so businesses can enable Indian payroll without being blocked by a setup issue.
Original PR description
This gave errors installing the Indian payroll module.
Miscellaneous changes
Description of the issue/feature this PR addresses: Correct titles Current behavior before PR: Right now the menuitem, action and tree name show "Tag" while it is about multiple tags. Desired behavior after PR is merged: The menuitem, action and tree name show "Tags" as they contain multiple records. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Original PR description
Description of the issue/feature this PR addresses: Correct titles Current behavior before PR: Right now the menuitem, action and tree name show "Tag" while it is about multiple tags. Desired behavior after PR is merged: The menuitem, action and tree name show "Tags" as they contain multiple records. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr