Daily updates from Odoo
Tuesday, September 24, 2019
1 change
Resolved issues and error corrections
This fixes a crash that could occur on tablets when the top menu and systray contain many items, especially in apps with fewer main menu entries such as Contacts. Users can now load these apps and resize or rotate the screen without hitting an error caused by missing menu items.
Original PR description
When having a long systray (icons from different apps, mode debug, multi-company...) the resize of the window can trigger a crash for apps that have not too much top-level menus (e.g. Contacts). This…
When having a long systray (icons from different apps, mode debug,
multi-company...) the resize of the window can trigger a crash for apps
that have not too much top-level menus (e.g. Contacts).
This also happens when loading those apps.
Steps to reproduce (on an iPad, portrait):
* use a Runbot with all modules installed (12.0+)
* activate "debug mode"
* ensure that the menu/systray bar is quite full
* open the "Contacts" app
=> traceback with a "cannot call getBoundingClientRect of undefined"
error
The reason is that the resize's callback iterate over the systray/menu
items to find which one should be folded behind a "more" ("+") menu
item.
Sadly in some cases (combination of screen width, systray size, app's
number of menus) it can lead to a traceback.
This commit ensures that when looping for menu items, we don't try to
reach an non-existing item.
X-original-commit: odoo/odoo@d7bae0329990171710acf2d9c0d4d9579cba2c0e
Co-authored-by: Romeo Fragomeli <rfr@odoo.com>