Monday, September 30, 2019
1 change · master
Code cleanup and technical improvements
This change renames fields previously called "user" in LDAP and email-fetching settings to safer names. It helps avoid database query errors when administrators or scripts update these records without special escaping.
Original PR description
**Description of the issue/feature this PR addresses:** If you execute the sql query: ```sql UPDATE res_company_ldap SET user = 1 ``` you will get a syntax error because `user` is a postgres keyword. It's true that you can avoid that by escaping the column using `"user"` instead, but usually people work with generic scripts that don't escape names. **Current behavior before PR:** Naming column `user` overwrites the sql keyword. **Desired behavior after PR is merged:** Column `user_id` instead doesn't overwrite anything. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr