Monday, October 14, 2019
12 changes · master
Resolved issues and error corrections
This fixes an issue where SMS template previews could fail when no template or related record was selected. Users should see a more reliable SMS preview experience instead of unexpected errors in optional setup cases.
Original PR description
[FIX] sms: avoid cache miss in compute We should always ensure to assign something in a compute method Since sms_template_id is not required, we have to check that it is set before trying to render the template Also make sure to have a default value in case you don't have a res_id Forward-Port-Of: odoo/odoo#38463
This fixes several issues in the website editor so theme and snippet options are easier to access and display correctly. Users editing websites should see cleaner snippet names and more reliable option panels, especially with older themes or nested settings.
Original PR description
Various editor fixes needed for themes Forward-Port-Of: odoo/odoo#38495
This fixes a bug where certain hierarchy-based filters could crash when the selected value was empty or matched no records. After the change, those filters simply return no results, improving reliability for users searching or filtering records.
Original PR description
Description of the issue/feature this PR addresses: operators `child_of` and `parent_of` fail if the right hand side is empty or yields empty results for many2many fields
Current behavior before PR: domains like `[('category_id', 'child_of', 'a name that yields nothing')]` on `res.partner` fail with an exception because we write a query of the form `... id in ()`
Desired behavior after PR is merged: the above domain yields nothing, and doesn't generate an exception
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe SMS composer now handles cases where no related record or recipient IDs are provided. This prevents unexpected errors and helps users continue sending or preparing SMS messages reliably.
Original PR description
[FIX] sms: avoid crashing when no res_model of res_ids sms_composer could crash in case you didn't pass it the active_id, active_ids context keys or don't call the default_get In that case it would try to access `self.env[False]` which would crash in the `_compute_recipients_count` We also have to ensure that we have a default value for `self.res_ids` because `literal_eval(False)` will crash Forward-Port-Of: odoo/odoo#38461
This update corrects the Colombian localization label for the business tax identification document from RUT to NIT. It ensures users see the legally accurate term for the number used, reducing confusion in customer and company records.
Original PR description
[FIX] l10n_co: change name of RUT document type to NIT The RUT is the Registro Único Tributario; the NIT is the Número de Identificación Tributaria. The number that is used is thus the NIT. opw 2082599 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38501
This update fixes a crash that could happen when users added a new line at the top of an editable list and then selected the last existing row. Users can now continue editing the last row normally, improving reliability in form-based list editing.
Original PR description
[FIX] web: List editable top select last row Description of the issue/feature this PR addresses: Current behavior before PR: Before this commit, when we have a list (editable top) in a form with some mandatory fields and some existing rows. If we click on 'add a line', a new empty line appear on the top, then we click on the last row, the empty row will disappear and we will have a traceback. Desired behavior after PR is merged: After this commit, if we repeat this scenario, we click on the last row, we will be able to edit this last row. Will fix this issue: https://github.com/odoo/odoo/issues/38204 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38302
This update renames web module test files so their names follow Odoo's standard testing convention. It helps keep automated tests consistently organized and easier to detect, with no expected impact on end users.
Original PR description
It's a tests file, like all tests file, its name must be finished by '_tests'. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Users can now edit imported subscriptions with end dates far in the future without encountering an error. The date picker now supports dates up to the year 9999, preventing disruptions when handling long-running or placeholder subscription dates.
Original PR description
[FIX] web: can't edit subscription with end date beyond 200 years in … …the future -Import a subscription with end date beyond 200 in the future (ex: 2500-01-01). -Open the subscription and click the Edit button. Before this commit: A stacktrace appears indicating that a date is not valid. It's not possible to edit the subscription. After this commit: The invalid date is replaced with the max date, allowing the user to edit the subscription. OPW: 2079696 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38418 Forward-Port-Of: odoo/odoo#38194
This fixes an issue where time entries between 0 and -1 hour lost their minus sign in HTML report displays. Business users reviewing timesheets will now see negative adjustments, such as -00:30, accurately instead of being shown as positive time.
Original PR description
[FIX] base: value_to_html doens't keep the minus sign for times betwe… …en 0 and 1 - Install timesheets and studio. - In timesheets add a time of -0.5 (minus half an hour). - Enter studio - Switch to the Reports tab, and click Timesheet Entries. Before this commit: The time is displayed as 00:30. After this commit: The time is displayed as -00:30. OPW: 2036188 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38354 Forward-Port-Of: odoo/odoo#38299
This fix ensures custom fields created with Studio are referenced accurately even when their names use uppercase or mixed-case letters. It prevents errors caused by database queries misreading those field names, improving reliability for customized Odoo setups.
Original PR description
[FIX] base: properly quote fields Fields created with Studio are case-sensitive, so we need to properly quote the query. opw-2083852 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38460
This fix ensures Odoo correctly recognizes when a view’s architecture depends on context, so resetting a modified view can show the expected differences. It also keeps website page caches consistent when view-related fields are updated, reducing the chance of stale or misleading page data.
Original PR description
[FIX] base: correctly define `arch` as depending on context Computed fields that depend on the context now have to be declared as such. To reproduce the issue: - go on the form view of any view - update the arch of the view - save - click on action "reset view architecture" - select hard reset - no diff is shown Expected: a diff should be shown `arch_base` depends on `arch`, so even though no current flow actually uses it when the context is changed, update its `depends_context` as well to be safe. Forward-Port-Of: odoo/odoo#37363
Odoo Studio now applies the optional field setting only in list views, preventing it from appearing in view types where it does not belong. This reduces confusion for users customizing screens and keeps Studio behavior consistent.
Original PR description
[FIX] studio: Set optional field only for treeview This commit removes the new optional field from other views than the treeview Forward-Port-Of: odoo/enterprise#5947