Daily updates from Odoo
Monday, October 14, 2019
10 changes · master
Resolved issues and error corrections
Reversing invoices and bills now creates the proper credit note documents, while other journal entries are reversed as miscellaneous entries. This helps ensure accounting reversals fully offset the original entries and keeps tax reporting tied to the correct accounting rules.
Original PR description
[FIX] account: type of entries created by reversals Only invoices/bills should create their equivalent credit notes when reversed (with tax tags coming from the related repartition lines), other kinds of journal entries should be reversed as misc entries, to negate them entirely in the accounting Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38476
Sale order lines created with minimal information now receive the correct company-related values before pricing and tax calculations run. This prevents errors during order entry and avoids incorrect cross-company data that could block users from reading or editing records.
Original PR description
[FIX] sale: fix add missing values at line create Create a new sale.order.line with only values = {'product_id': x, 'order_id': y} Then line.company_id == res.company() whereas…
[FIX] sale: fix add missing values at line create
Create a new sale.order.line with only values = {'product_id': x, 'order_id': y}
Then line.company_id == res.company()
whereas line.order_id.company_id == res.company(1).
Since company_id is a related on order_id.company_id, this is kind of wrong.
This is because we have a new record, so its values exist only in cache;
however when accessing the related the default is that related_sudo=True.
So we try to access the related value in another environment; but this sudo
environment does not have the line.order_id in cache.
Knowing this behaviour, the cache is copied to the sudo environment but only in
onchange, since it's the only supported use-case for new records.
Of note is that _prepare_add_missing_fields calls product_id_change,
which calls functions that expect all related to have the correct value.
For instance price computations rely on the _convert method, which depends on
the currency and the company of the line, so this can trigger tracebacks.
Note that in particular commit 3e61dab2814 is an explicit workaround for this
issue.
opw 2062123
Forward-Port-Of: odoo/odoo#38377
Forward-Port-Of: odoo/odoo#38258This update restores the expected access checks so portal users are no longer incorrectly blocked when opening links to records that reference restricted internal data. It prevents unnecessary access errors and redirects to the home page, improving the portal browsing experience.
Original PR description
[FIX] models, test_access_rights: restore normal ACL check Because of 4b1cb41cf7a3f936a1e6d00a2bb6a6a29e82d711, we might try to read the field 'active' on a record on which we can't read fields besides the name. This thus triggers an access error where there should not have been. In particular, this is the case for portal users: most often the records they can access point to records that they can't read (e.g. the partner of the internal user assigned to the ticket). As a result, clicking on any link creates an ACL, and thus redirects to the home page. Forward-Port-Of: odoo/odoo#38198
Opening Contacts with the Colombian localization installed no longer triggers repeated crash messages. The fix ensures every contact gets a safe verification code value, improving reliability for users managing Colombian contacts.
Original PR description
[FIX] l10n_co: crash when adding contact Install l10n_co,contacts. Open contacts. Several crash messages will popup because the override in l10n_co of res_partner is not computing the 'l10n_co_verification_code' field for every record. Changing the implementation to be sure to store some value for every record fix the issue. opw-2082583 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38406
This fix stops a server-side loop that could make the interface hang when users add certain custom fields to task list views. It improves reliability for teams customizing project task screens with Studio.
Original PR description
[FIX] models: infinite loop Example of workflow to reproduce the issue: - Add a selection field 'Test' to `project.task` with Studio - Go to Projects > Planning > By Project - Switch to list view -…
[FIX] models: infinite loop Example of workflow to reproduce the issue: - Add a selection field 'Test' to `project.task` with Studio - Go to Projects > Planning > By Project - Switch to list view - Add the newly created field to the view 'Task > Test' The interface loops indefinitely because the server is stuck in an infinite loop. The loop is the following: https://github.com/odoo/odoo/blob/89270ee39c0daa46ae8e2e3e57d7e512a1a65ddf/odoo/models.py#L5624-L5625 The root cause of the issue comes from an incorrect object ID added in the list of fields to recompute. Since the method is set in a `post_init`, the object `field` is different from `recs[field_name]`. To prevent the error, we retrieve the object directly in the `mark_fields_to_compute` method. opw-2083852 Co-authored-by: Denis Ledoux <dle@odoo.com> Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38497
Point of Sale invoices now better match stock accounting entries for products using real-time valuation. This helps keep financial records consistent with standard sales workflows and reduces manual reconciliation issues.
Original PR description
[FIX] point_of_sale: reconcile invoice anglo-saxon lines Reconcile the stock output lines of the pos.order invoice for products with real-time valuation. This is to be more consistent with the sales module. TASK-ID: 2048668 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#35901
This update improves Field Service workflows by showing the right action buttons at the right time, including completing tasks and resending reports. It also improves demo setup and multi-company handling so field service examples and task forms behave more reliably for users.
Original PR description
13.0 fiximp jem Forward-Port-Of: odoo/enterprise#6009
This fixes an issue in the Mexican electronic invoicing module where registering a payment on a customer invoice could fail after an internal invoice model changed. The update uses the current invoice data model, helping businesses process payments without errors.
Original PR description
[FIX] l10n_mx_edi: account.invoice reference was removed The forward port from ae92ac1c85209f4999e19e24afc35d046fc0e82a is incorrect from saas-12.4 to v13, because account.invoice model not exists now. Was improved to use the account.move model. To get this error, create a new customer invoice and register the payment. Forward-Port-Of: odoo/enterprise#6000
The IoT device scan now has a default IP address when Chrome blocks local IP detection. This prevents the scan from becoming unusable and helps users continue discovering IoT devices reliably.
Original PR description
[FIX] iot: Default IP Address for scan The latest version of Chrome blocks the detection of the local IP and no default address was set. Making the scan unusable. Forward-Port-Of: odoo/enterprise#6021
Code cleanup and technical improvements
The Mexican electronic invoicing module now loads key reference data using a faster standard import process. This reduces installation time and helps prevent reference data from being lost after installation.
Original PR description
Now tools.convert_file(csv) is faster than before because of it is using create_multi Importing l10n_mx_edi/data/l10n_mx_edi.product.sat.code.csv Spend 1 minute Cleaning a lot of complex code from hook Fix data deleted after install l10n_mx_edi Related issue: https://github.com/odoo/odoo/issues/35613 Dummy PR: https://git.vauxoo.com/vauxoo/enterprise-mx/merge_requests/604 [](https://runbot.vauxoo.com/runbot/99/604)