Affected versions: 10-12 It is possible to get to a situation where Odoo would try to send an email without a `From:` header address. <details><summary>Open to see one example use case that would trigger that situation</summary> 1. Install sale and account. 1. Go to one invoice. 1. Click send by email. 1. Click in the "open" button for the template field. 1. Click in the button to add the template to the model. 1. Refresh browser. 1. In the same invoice, hit Action > Send Mail (In

Affected versions: 10-12

It is possible to get to a situation where Odoo would try to send an email without a `From:` header address.

<details><summary>Open to see one example use case that would trigger that situation</summary>

1. Install sale and account.
1. Go to one invoice.
1. Click send by email.
1. Click in the "open" button for the template field.
1. Click in the button to add the template to the model.
1. Refresh browser.
1. In the same invoice, hit Action > Send Mail (Invoicing: Invoice email).
1. Send.

Since the template doesn't define a default "from" address, and it doesn't take the one from the user because it's in mass sending mode, and you don't have access to the server to add the `--email-from` CLI parameter, there are 2 possible outcomes:

1. An `AssertionError` happens and goes unnoticed, if you had `PYTHONOPTIMIZE=""`.
1. An email is sent with an empty `From:` header, being rejected by almost any SMTP provider out there, if you had `PYTHONOPTIMIZE="1"`.

</details>
In such case, you're unlucky if you don't have access to the underlying deployment, or if you use multiple databases in a single Odoo instance and each of them uses a different mail configuration.

To make this configuration easier to use and cover those use cases, here I add support for a new ICP: `mail.default.from`. It will be used when present, so it shouldn't affect existing deployments. When present, it will allow a admin to configure the default sending address just with Odoo itself.

This patch is half fix half feature, so I publish for v10 hoping it's considered a fix. I can re-target to a higher version if you consider it necessary.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@Tecnativa TT19448

Forward-Port-Of: odoo/odoo#38833
Forward-Port-Of: odoo/odoo#36837

With a Right to Left lang. Go to an employee form view. Click on the small pill with the number of subordinates (in the org chart). The popover opens but on the right side of the window instead of next to the pill. Fixes #38722 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38776

With a Right to Left lang.
Go to an employee form view.
Click on the small pill with the number of subordinates (in the org chart).
The popover opens but on the right side of the window instead of next to the
pill.

Fixes #38722


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#38776

Description of the issue/feature this PR addresses: Current behavior before PR: Private email and phone are related of partner 'address' fields. But the phone was read-only and the email is editable. Desired behavior after PR is merged: As phone and mail are related, they are read-only. We must edit them on the partner of Address field. close #38518 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38713

Description of the issue/feature this PR addresses:
Current behavior before PR:
Private email and phone are related of partner 'address' fields.
But the phone was read-only and the email is editable.

Desired behavior after PR is merged:
As phone and mail are related, they are read-only. We must edit
them on the partner of Address field.

close #38518 

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#38713

Description of the issue/feature this PR addresses: Current behavior before PR: When there few elements in kanban and a search panel, all kanban cards try to take a maximum of height and become deformed. Desired behavior after PR is merged: The behavior of dimensions of kanban cards must be the same with or without searchpanel. closes #38556 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38703

Description of the issue/feature this PR addresses:
Current behavior before PR:
When there few elements in kanban and a search panel, all kanban
cards try to take a maximum of height and become deformed.

Desired behavior after PR is merged:
The behavior of dimensions of kanban cards must be the same with
or without searchpanel.

closes #38556 


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#38703

When a reconciliation proposition's amount is computed from a regex, we cannnot be sure the regex captured something. If it didn't we don't want to display a badly formatted line. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37578

When a reconciliation proposition's amount is computed from a regex, we
cannnot be sure the regex captured something. If it didn't we don't want
to display a badly formatted line.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#37578

- base_vat: Correct management of the check of peruvian VAT without prefix. - l10n_pe: Correct income account the last one is not correct. - l10n_pe: Forced Round globally for peruvian companies once l10n_pe is installed, and with the onchange. - l10n_pe: For peruvian companies it does not make sense a sequence per year and the year in the prefix is incorrect, we must force XXX- as a sequence prefix. Forward-Port-Of: odoo/odoo#38764

- base_vat: Correct management of the check of peruvian VAT without prefix.
- l10n_pe: Correct income account the last one is not correct.
- l10n_pe: Forced Round globally for peruvian companies once l10n_pe is
installed, and with the onchange.
- l10n_pe: For peruvian companies it does not make sense a sequence per
year and the year in the prefix is incorrect, we must force XXX- as
a sequence prefix.

Forward-Port-Of: odoo/odoo#38764

Forward-Port-Of: odoo/odoo#38834

Forward-Port-Of: odoo/odoo#38834

Add an option called 'no-edit-color' to disable the possibilité of modify the color of the tags Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38785

Add an option called 'no-edit-color' to disable the possibilité of modify the color of the tags

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#38785

Have a reconciliation model that applies to some particular journals And that will match some of those journals' lines The field journal should be filled too (this field is only the default journal that a proposition will be filled with) Open the reconciliation widget on a given journal, within the list of possible journal (from the account dashboard) Before this commit there was a crashed. This was caused by the fact that one of the lines that should be displayed had a reconcile mode

Have a reconciliation model that applies to some particular journals
And that will match some of those journals' lines
The field journal should be filled too
(this field is only the default journal that a proposition will be filled with)

Open the reconciliation widget on a given journal, within the list of
possible journal (from the account dashboard)

Before this commit there was a crashed. This was caused by the fact that
one of the lines that should be displayed had a reconcile model that was not fetched beforehand

After this commit, there is no crash as all relevant reconcile
models are fetched

Note that, on reconcile models, the field journal_id is just there to prefill
the propositions it will create

corrects commit e5c8071484c883bf78478a39ef2120bcd8f2442d

OPW 2084942

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#38817
Forward-Port-Of: odoo/odoo#38726

The im_support module was broken in 12.0 after bus refactorings between 11.0 and 12.0. Adapt the JS code to that updated API in order to preserve support for CORS-supported livechat. Co-authored-by: @alexkuhn Forward-Port-Of: odoo/odoo#38479

The im_support module was broken in 12.0 after bus refactorings between 11.0 and 12.0. Adapt the JS code to that updated API in order to preserve support for CORS-supported livechat.
    
Co-authored-by: @alexkuhn

Forward-Port-Of: odoo/odoo#38479

Forward-Port-Of: odoo/odoo#37063

Forward-Port-Of: odoo/odoo#37063

For some obscure reason, a -1 was set when retrieving the id of the default receivable/payable accounts for the imported partners. This was not correct. Forward-Port-Of: odoo/enterprise#6175

For some obscure reason, a -1 was set when retrieving the id of the
default receivable/payable accounts for the imported partners. This was
not correct.

Forward-Port-Of: odoo/enterprise#6175

This commit correctly applies the group_system on the "Settings" menuitem. This is necessary since you need all kinds of permissions to access the Settings menu. However, it will make the menuitem appear even in non-debug mode, but it's consistent with all other apps. Task#2083817 Forward-Port-Of: odoo/enterprise#6025

This commit correctly applies the group_system on the "Settings" menuitem.

This is necessary since you need all kinds of permissions to access the Settings menu.

However, it will make the menuitem appear even in non-debug mode, but it's consistent with all
other apps.

Task#2083817

Forward-Port-Of: odoo/enterprise#6025

On the payroll reporting screen, attendances are counted as "Paid time off" in the pie chart. The reason is the work type is computed based on the boolean field `is_leave` of a work entry type. But the field can have a NULL value in the database for work entry types created before the module `hr_payroll` is installed. This commit changes the SQL view to support NULL values. Forward-Port-Of: odoo/enterprise#6169

On the payroll reporting screen, attendances are counted as "Paid time off"
in the pie chart.
The reason is the work type is computed based on the boolean field `is_leave` of
a work entry type. But the field can have a NULL value in the database for
work entry types created before the module `hr_payroll` is installed.
This commit changes the SQL view to support NULL values.

Forward-Port-Of: odoo/enterprise#6169

It may happen that an attendance work entry conflicts with a leave work entry where the leave is already approved. In this case, the button "Approve Time Off" should not be displayed on the leave work entry. Forward-Port-Of: odoo/enterprise#6144

It may happen that an attendance work entry conflicts with a leave work entry
where the leave is already approved.
In this case, the button "Approve Time Off" should not be displayed on the
leave work entry.

Forward-Port-Of: odoo/enterprise#6144