Daily updates from Odoo
Friday, October 18, 2019
28 changes · master
Enhancements to existing features
The calendar button is now placed in the standard button area used across Odoo forms. This makes the screen look more consistent and makes it easier to add related buttons in the future.
Original PR description
Description of the issue/feature this PR addresses: Place the button within the right box & make it look better Current behavior before PR: The button was not within an `oe_button_box` div element, which was giving different styling which is not consistent with the rest of Odoo. Result before this PR:  Desired behavior after PR is merged: The button is nicely showed within a button box, just like all other cases in Odoo. It is also easier to xpath and create extra buttons within this button box.  -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update renames user-related fields in LDAP and incoming email server settings to make their purpose clearer. It helps administrators better understand configuration screens without changing the underlying business process.
Original PR description
Task: https://www.odoo.com/web#id=1911988&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Belgian POS Blackbox log now uses a clearer internal field name for the employee or user reference. This is a minor technical cleanup that improves consistency and reduces confusion for future maintenance without changing day-to-day business workflows.
Original PR description
Task: https://www.odoo.com/web#id=1911988&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720
Resolved issues and error corrections
This update removes an obsolete internal graph utility that was no longer needed. It simplifies the core codebase and reduces maintenance overhead without changing day-to-day user workflows.
Miscellaneous changes
* Install pos_hr * Create new user [DEMO] (change password and save the user id) * In POS session settings, uncheck "Login with Employees" * Log in with [DEMO] * Start a new POS session * From the Employee page delete the record matching [DEMO] user id * Process a transaction from the POS Several error message will popup. This is due to https://github.com/odoo/odoo/commit/26274dbb9720743461be2a70de02bf4c1ea377f4 which introduced a faulty matching between the id of user who start the p
Original PR description
* Install pos_hr * Create new user [DEMO] (change password and save the user id) * In POS session settings, uncheck "Login with Employees" * Log in with [DEMO] * Start a new POS session * From the Employee page delete the record matching [DEMO] user id * Process a transaction from the POS Several error message will popup. This is due to https://github.com/odoo/odoo/commit/26274dbb9720743461be2a70de02bf4c1ea377f4 which introduced a faulty matching between the id of user who start the pos and an employee with the same id. Assigning the single properties as before the change fix the issue opw-2087591 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39028
Prevent column's width to change between an empty list and non-empty list by adding a help message. TaskID: 2081660 closes #38018 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38188
Original PR description
Prevent column's width to change between an empty list and non-empty list by adding a help message. TaskID: 2081660 closes #38018 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38188
1) Install Accounting, create a journal entry, save. Go to "Other Info" tab. "Reverse entry" button is visible, but it should be names "Reversed Entry" and it should be hidden if there is no linked reversed entry. 2) Install Accounting, create a journal entry, post it, reverse it with a date in the future. The reverse entry will be posted, instead it should stay a draft (with the appropriate 'auto_post' set to True) opw-2083121 -- I confirm I have signed the CLA and read the
Original PR description
1) Install Accounting, create a journal entry, save. Go to "Other Info" tab. "Reverse entry" button is visible, but it should be names "Reversed Entry" and it should be hidden if there is no linked reversed entry. 2) Install Accounting, create a journal entry, post it, reverse it with a date in the future. The reverse entry will be posted, instead it should stay a draft (with the appropriate 'auto_post' set to True) opw-2083121 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38470
Task: https://www.odoo.com/web?#id=2072111&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.04baa899df6b80118d7d4a2770d17c37 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37506
Original PR description
Task: https://www.odoo.com/web?#id=2072111&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.04baa899df6b80118d7d4a2770d17c37 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37506
task: https://www.odoo.com/web#id=1966308&action=327&model=project.task&view_type=form&menu_id=4720 pad: https://pad.odoo.com/p/r.0b224fc1bfc6be352de70bec4380dfd3 Forward-Port-Of: odoo/odoo#38081
Original PR description
task: https://www.odoo.com/web#id=1966308&action=327&model=project.task&view_type=form&menu_id=4720 pad: https://pad.odoo.com/p/r.0b224fc1bfc6be352de70bec4380dfd3 Forward-Port-Of: odoo/odoo#38081
A user get a AccessError during a valid flow on the website shop due to a attachment search (with website_sale_digital installed) : - As a portal user buy a product and pay with wire tranfer (or other) - Check the your quotation with this user and we get a AccessError for the read ir.attachment model. The bug comes from the website_sale_digital module which add a search on ir.attachment for each product (allows digital product sell, eg. ebook) on the controller rendering orders. To fix
Original PR description
A user get a AccessError during a valid flow on the website shop due to a attachment search (with website_sale_digital installed) : - As a portal user buy a product and pay with wire tranfer (or…
A user get a AccessError during a valid flow on the website shop due to a attachment search (with website_sale_digital installed) : - As a portal user buy a product and pay with wire tranfer (or other) - Check the your quotation with this user and we get a AccessError for the read ir.attachment model. The bug comes from the website_sale_digital module which add a search on ir.attachment for each product (allows digital product sell, eg. ebook) on the controller rendering orders. To fix this issue, add a sudo call before the search. It is legit because only the name and date is retrieved and the download (of the digital product) checks the access of this product attachment (if user already paid for it). TASK_ID : 2004031 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39000
Description of the issue/feature this PR addresses: In pivot, when we click on '+', it must open the selection box at the point where we click. Current behavior before PR: The box opens at the top of the page Desired behavior after PR is merged: The box opens at the point where we click id=2066675 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37385
Original PR description
Description of the issue/feature this PR addresses: In pivot, when we click on '+', it must open the selection box at the point where we click. Current behavior before PR: The box opens at the top of the page Desired behavior after PR is merged: The box opens at the point where we click id=2066675 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37385
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39016
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39016
Description of the issue/feature this PR addresses: Task: https://www.odoo.com/web#id=2071031&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.dac13d534c46d6f69e51ed5f734a0f08 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38265
Original PR description
Description of the issue/feature this PR addresses: Task: https://www.odoo.com/web#id=2071031&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.dac13d534c46d6f69e51ed5f734a0f08 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38265
This test was raising an assert error if the DB has other websites than the data/demo ones. As we have a new module in Odoo 13.0 (https://github.com/odoo/design-themes/pull/178) which is creating 25 websites, and since the design-themes runbot is now running tests, we were having a red design-themes runbot. Forward-Port-Of: odoo/odoo#38972
Original PR description
This test was raising an assert error if the DB has other websites than the data/demo ones. As we have a new module in Odoo 13.0 (https://github.com/odoo/design-themes/pull/178) which is creating 25 websites, and since the design-themes runbot is now running tests, we were having a red design-themes runbot. Forward-Port-Of: odoo/odoo#38972
Before this commit, the trash icons and "OR" indicator of each filter was too far and couldn't be seen Now, both of them are closer to the filter and can be seen in any circumstance. Task 2073707 Forward-Port-Of: odoo/odoo#37722
Original PR description
Before this commit, the trash icons and "OR" indicator of each filter was too far and couldn't be seen Now, both of them are closer to the filter and can be seen in any circumstance. Task 2073707 Forward-Port-Of: odoo/odoo#37722
Since 62c9dedafda0cbdc618641eaa80c49535ab0b5f6, when accessing a website connected as portal or public user, the themes images are not showed. An error is arose 'Sorry, you are not allowed to access documents of type 'Attachment' (ir.attachment)'. Now, the portal and public user have access to the themes images. opw-2082468 Co-authored-by: Lucas Perais <lpe@odoo.com> Forward-Port-Of: odoo/odoo#38515
Original PR description
Since 62c9dedafda0cbdc618641eaa80c49535ab0b5f6, when accessing a website connected as portal or public user, the themes images are not showed. An error is arose 'Sorry, you are not allowed to access documents of type 'Attachment' (ir.attachment)'. Now, the portal and public user have access to the themes images. opw-2082468 Co-authored-by: Lucas Perais <lpe@odoo.com> Forward-Port-Of: odoo/odoo#38515
Since https://github.com/odoo/odoo/commit/f896afcc8a54eae3efcdf034e3fd256942f7fa78, _(un)archive_ all on a kanban column triggered `toggle_active` on all records, which doesn't consider whether we want to archive/unarchive and on which records... With this fix, the archive attribute on the `kanban_column_records_toggle_active` event is considered again to know whether the records have to be archived or unarchived. Closes #38903 -- I confirm I have signed the CLA and read the PR guideli
Original PR description
Since https://github.com/odoo/odoo/commit/f896afcc8a54eae3efcdf034e3fd256942f7fa78, _(un)archive_ all on a kanban column triggered `toggle_active` on all records, which doesn't consider whether we want to archive/unarchive and on which records... With this fix, the archive attribute on the `kanban_column_records_toggle_active` event is considered again to know whether the records have to be archived or unarchived. Closes #38903 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38941
A 404 will take 3 to 5 seconds to be resolved and execute +- 1900 query, to return a rendered page which is quite expensive, especially when multiple missing images are rendered in a view. Catching static route and marking them as not frontend will help to avoid to handle miss on static resources. In this case server returns a standard 404. This commit also fix a iframe src in order to avoid a 404 on /web/(test )/report/html/some_report (thx to aab-odoo) Forward-Port-Of: odoo/odoo#388
Original PR description
A 404 will take 3 to 5 seconds to be resolved and execute +- 1900 query, to return a rendered page which is quite expensive, especially when multiple missing images are rendered in a view. Catching static route and marking them as not frontend will help to avoid to handle miss on static resources. In this case server returns a standard 404. This commit also fix a iframe src in order to avoid a 404 on /web/(test )/report/html/some_report (thx to aab-odoo) Forward-Port-Of: odoo/odoo#38815
Current behavior before PR: Without this patch, if a view defines a `<label for="forbidden_field"/>` anywhere, the web client tries to fetch the field data, but since the user has no access, it gets an error. You can see the effect with this addon: [label_groups_security.zip](https://github.com/odoo/odoo/files/2589217/label_groups_security.zip) Desired behavior after PR is merged: Now, if the label targets a forbidden field, it gets removed from the view, as happens with the related fi
Original PR description
Current behavior before PR: Without this patch, if a view defines a `<label for="forbidden_field"/>` anywhere, the web client tries to fetch the field data, but since the user has no access, it gets an error. You can see the effect with this addon: [label_groups_security.zip](https://github.com/odoo/odoo/files/2589217/label_groups_security.zip) Desired behavior after PR is merged: Now, if the label targets a forbidden field, it gets removed from the view, as happens with the related field. The client doesn't know of that field's existence and no errors happen. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr @Tecnativa Forward-Port-Of: odoo/odoo#28755
Before this commit launch a server with --db-filter that match at least 2 dbs name Try to authenticate You will have an error request is unbound when you try to access request.env Now, if request is not bound we return None Related to commit odoo/odoo@245ef4b1 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forw
Original PR description
Before this commit launch a server with --db-filter that match at least 2 dbs name Try to authenticate You will have an error request is unbound when you try to access request.env Now, if request is not bound we return None Related to commit odoo/odoo@245ef4b1 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38047
Commits df2ea31ff6e and 55ed70f405a moved things around, "without any functional change". They made it so that if you add twice a product to the cart, they are added in different lines instead of merged. There are two issues: - the `if line_id: return lines` made sense when the post-filtering was in the same function, since it could readily be avoided - conversely the post-filtering was avoided in the function that was added with the only goal to do it, except in the case where it was
Original PR description
Commits df2ea31ff6e and 55ed70f405a moved things around, "without any functional change". They made it so that if you add twice a product to the cart, they are added in different lines instead of merged. There are two issues: - the `if line_id: return lines` made sense when the post-filtering was in the same function, since it could readily be avoided - conversely the post-filtering was avoided in the function that was added with the only goal to do it, except in the case where it was useless (the case where lines is an empty recordset). opw 2083729 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38714
Prevent column's width to change between an empty list and non-empty list by adding a help message. TaskID: 2081660 Forward-Port-Of: odoo/enterprise#5972
Original PR description
Prevent column's width to change between an empty list and non-empty list by adding a help message. TaskID: 2081660 Forward-Port-Of: odoo/enterprise#5972
Forward-Port-Of: odoo/enterprise#6234
Original PR description
Forward-Port-Of: odoo/enterprise#6234
Have a model which has onchanges Have a selection field with some selection values Make some records with those values Now in studio, remove a selection value that is used on a record from the field Go on the form view of the record Before this commit, the records kept their value, even if the value was not correct At the onchange though, it crashed because the value for the field was not correct according to the selection field spec After this commit, before altering the field, we
Original PR description
Have a model which has onchanges Have a selection field with some selection values Make some records with those values Now in studio, remove a selection value that is used on a record from the field Go on the form view of the record Before this commit, the records kept their value, even if the value was not correct At the onchange though, it crashed because the value for the field was not correct according to the selection field spec After this commit, before altering the field, we check if there are records with that have values not included in the new selection values OPW 2078796 Forward-Port-Of: odoo/enterprise#6219 Forward-Port-Of: odoo/enterprise#5977
Fixed the visibility of borders when hovering/clicking a column Before this commit, a transparent border rule prevented other borders to appear when hovering or clicking on a list cell in studio. Now, their priority have been increased to bypass the default transparent border rule. Task 2081156 Forward-Port-Of: odoo/enterprise#5937
Original PR description
Fixed the visibility of borders when hovering/clicking a column Before this commit, a transparent border rule prevented other borders to appear when hovering or clicking on a list cell in studio. Now, their priority have been increased to bypass the default transparent border rule. Task 2081156 Forward-Port-Of: odoo/enterprise#5937
Web 404 requests can slow down the testing process. This commit prefer to uses routes on static since 404 will be much faster with corresponding community pr. Some other fixes are made in #6168 for social Forward-Port-Of: odoo/enterprise#6157
Original PR description
Web 404 requests can slow down the testing process. This commit prefer to uses routes on static since 404 will be much faster with corresponding community pr. Some other fixes are made in #6168 for social Forward-Port-Of: odoo/enterprise#6157
… a single image When uploading a single image to a Facebook post, you need to use a different endpoint. This separate endpoint was not correctly handled in the code and it did not mark the social.post as 'posted' when it should have. Task#2083782 Forward-Port-Of: odoo/enterprise#6023
Original PR description
… a single image When uploading a single image to a Facebook post, you need to use a different endpoint. This separate endpoint was not correctly handled in the code and it did not mark the social.post as 'posted' when it should have. Task#2083782 Forward-Port-Of: odoo/enterprise#6023
remove call to deprecated _get_visitor_from_request_or_create function Forward-Port-Of: odoo/enterprise#5945
Original PR description
remove call to deprecated _get_visitor_from_request_or_create function Forward-Port-Of: odoo/enterprise#5945