Wednesday, November 6, 2019
26 changes · master
New functionality added to Odoo
This update adds Chilean regions to Odoo’s standard country and state data. Businesses operating in Chile can now use accurate regional information in addresses, contacts, and localization-related workflows.
Original PR description
Description of the issue/feature this PR addresses: Add Chilean regions as states -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Enhancements to existing features
This change disables a problematic accounting test that was already marked as disabled. It helps keep development and validation workflows stable while the underlying test issue can be addressed separately.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
Attachment access checks were simplified so the system directly verifies whether the current user is an internal employee, administrator, or superuser. This reduces internal complexity while keeping responsibility for granting attachment access with the relevant business flow or controller.
Original PR description
/cc @ryv-odoo
Miscellaneous changes
Pulled list directly from https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/ir_module.py#L278 ## Description of the issue/feature this PR addresses: The documentation for `__manifest__.py` does not make it clear that the value of `license` must be one value from a set list of values, and not just any string. In addition, the docs for this does not list the actual values. ## Current behavior before PR: No Odoo product behavior changes ## Desired behavior after PR is me
Original PR description
Pulled list directly from https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/ir_module.py#L278 ## Description of the issue/feature this PR addresses: The documentation for…
Pulled list directly from https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/ir_module.py#L278 ## Description of the issue/feature this PR addresses: The documentation for `__manifest__.py` does not make it clear that the value of `license` must be one value from a set list of values, and not just any string. In addition, the docs for this does not list the actual values. ## Current behavior before PR: No Odoo product behavior changes ## Desired behavior after PR is merged: No Odoo product behavior changes ## Related * See #39270 for my signature addition * In #39273 I was asked to have this against 11.0 * This patch applies to 11.0, 12.0, and 13.0 * https://github.com/odoo/odoo/blob/11.0/odoo/addons/base/module/module.py#L279 * https://github.com/odoo/odoo/blob/12.0/odoo/addons/base/models/ir_module.py#L281 * https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/ir_module.py#L278 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39354
The test suite was updated so accounting-related tests create the data they need instead of depending on preloaded demo records. This makes future demo data changes safer, improves test speed, and supports more reliable validation across migrated databases.
Original PR description
Purpose ======= This is the first huge step to improve the test suite in several ways: - Make them demo data independent, allowing to modify the demo data without having to adapt the tests depending on it. It also allows to have a beautiful + convenient demo dataset to make a demonstration, and to configure complex data in the tests to manage the corner cases. - Improve the test performances by converting them into SavepointCase. Each test will be rollbacked to it's initial state, after the setUpClass call. That way the different data are not re-created at each test for nothing. - Introduce several test classes in base/tests/common.py to launch a TransactionCase, HttpCase or SavepointCase test with an available demo user, portal user or a large set of partners. - This is the first step to tend to a rolling release process, allowing to execute the tests (or a subset of the tests) on a migrated base, for example. TaskID: 2075739
Task: https://www.odoo.com/web?#id=2116040&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.59f598d9dd7bab55708a5098288eff79 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39578
Original PR description
Task: https://www.odoo.com/web?#id=2116040&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.59f598d9dd7bab55708a5098288eff79 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39578
…tton This commit fixes the "quiz finish" modal display by correctly hiding it when the user clicks on the "Next" button in the modal. Without this fix, the user could run into an issue where the "modal backdrop" would stay on the screen, locking all actions and forcing a manual refresh. Task#2118532 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR
Original PR description
…tton This commit fixes the "quiz finish" modal display by correctly hiding it when the user clicks on the "Next" button in the modal. Without this fix, the user could run into an issue where the "modal backdrop" would stay on the screen, locking all actions and forcing a manual refresh. Task#2118532 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39746
This commit: https://github.com/odoo/odoo/commit/0eba50dd1c33a08f8862a5718149e61b822e1b5a introduced a 'return' in the survey.js script: return load_chart(chartConfig, '#scoring_results_chart'); This makes the rest of the script completely skipped and bypasses all the filter features. task-2116078 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39555
Original PR description
This commit: https://github.com/odoo/odoo/commit/0eba50dd1c33a08f8862a5718149e61b822e1b5a introduced a 'return' in the survey.js script: return load_chart(chartConfig, '#scoring_results_chart'); This makes the rest of the script completely skipped and bypasses all the filter features. task-2116078 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39555
Fixed a bug where you got a traceback when trying to join a course on a quiz preview not in fullscreen mode. Task ID : 2079476 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38051
Original PR description
Fixed a bug where you got a traceback when trying to join a course on a quiz preview not in fullscreen mode. Task ID : 2079476 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38051
When a pos order is sent to the server, the field 'to_invoice' is never sent to the server which lead to always having a value to 'false'. We are now sending correctly this value to the server, and we can also base the fact to create an invoice on the value of each order. Because beeing offline could lead to create an order that should be invoiced as one that should not be. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR
Original PR description
When a pos order is sent to the server, the field 'to_invoice' is never sent to the server which lead to always having a value to 'false'. We are now sending correctly this value to the server, and we can also base the fact to create an invoice on the value of each order. Because beeing offline could lead to create an order that should be invoiced as one that should not be. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39843
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39855
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39855
Task : https://www.odoo.com/web?#id=1883428&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.4bdc2c8043f94f2ef5c3d476e430e1cb Forward-Port-Of: odoo/odoo#39849
Original PR description
Task : https://www.odoo.com/web?#id=1883428&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.4bdc2c8043f94f2ef5c3d476e430e1cb Forward-Port-Of: odoo/odoo#39849
Fixes #39688 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39721
Original PR description
Fixes #39688 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39721
The commit 3c4bb08 fixed an issue about reservation from transit location for versions from 11.0 to 12.0 by soften the record rule on stock.move From 12.3, we need to additionnaly soften the stock.move.line rule to have the same result as this model has a record rule too since that version Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www
Original PR description
The commit 3c4bb08 fixed an issue about reservation from transit location for versions from 11.0 to 12.0 by soften the record rule on stock.move From 12.3, we need to additionnaly soften the stock.move.line rule to have the same result as this model has a record rule too since that version Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39809 Forward-Port-Of: odoo/odoo#39791
- In the sales or accounting module, create some invoices. - Select them then click on `action > send & print` - The wizard opens but not in the mass mail mode. It creates some inconsistency and if you click on send, the invoices are sent to the wrong customer. Sometimes, the invoices are not sent at all. I think the problem comes from the `_compute_composition_mode` method who set the value of `composition_mode` on the wizard instead of on the composer. OPW-2085837 Descripti
Original PR description
- In the sales or accounting module, create some invoices. - Select them then click on `action > send & print` - The wizard opens but not in the mass mail mode. It creates some inconsistency and if you click on send, the invoices are sent to the wrong customer. Sometimes, the invoices are not sent at all. I think the problem comes from the `_compute_composition_mode` method who set the value of `composition_mode` on the wizard instead of on the composer. OPW-2085837 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39738
Followup for d22866f8427c5500014b6502cbfe127b678204a8 Without this fix the rendering associated with this view would crash because after the replace the field became a string and it crash when retrieving it with t-field -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39753 Forward-Port-Of: odoo/odoo#39732
Original PR description
Followup for d22866f8427c5500014b6502cbfe127b678204a8 Without this fix the rendering associated with this view would crash because after the replace the field became a string and it crash when retrieving it with t-field -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39753 Forward-Port-Of: odoo/odoo#39732
* The purchase import template was never updated to reflect the Big Demo Data Changes (58fc4e440952bde533c8aa1dc8b6fc2440a05337). * The employees template apparently never worked: "married (or similar)" was removed before that task was merged. Forward-Port-Of: odoo/odoo#39800
Original PR description
* The purchase import template was never updated to reflect the Big Demo Data Changes (58fc4e440952bde533c8aa1dc8b6fc2440a05337). * The employees template apparently never worked: "married (or similar)" was removed before that task was merged. Forward-Port-Of: odoo/odoo#39800
Forward-Port-Of: odoo/odoo#39249 Forward-Port-Of: odoo/odoo#38766
Original PR description
Forward-Port-Of: odoo/odoo#39249 Forward-Port-Of: odoo/odoo#38766
Before this commit, only `account.move` of type `in_invoice` were covered by the settings of documents. A restriction that was introduced with the refactor of accounting. This commit fixes this issue and allows all 4 types of invoices to be covered by the settings of `documents_account`. opw:2118941 Forward-Port-Of: odoo/enterprise#6573
Original PR description
Before this commit, only `account.move` of type `in_invoice` were covered by the settings of documents. A restriction that was introduced with the refactor of accounting. This commit fixes this issue and allows all 4 types of invoices to be covered by the settings of `documents_account`. opw:2118941 Forward-Port-Of: odoo/enterprise#6573
Fix grey zone, in case of precision: half and scale = week or month id=2088873 Forward-Port-Of: odoo/enterprise#6306
Original PR description
Fix grey zone, in case of precision: half and scale = week or month id=2088873 Forward-Port-Of: odoo/enterprise#6306
Forward-Port-Of: odoo/enterprise#6232
Original PR description
Forward-Port-Of: odoo/enterprise#6232
Add some tests, - Tests the priority on post 1. Image, if the user add images, they should be displayed on LinkedIn 2. URLs, if the user writes URLs in the message, but doesn't add an image, we must display a preview of the URL on LinkedIn 3. Text - Test if the post is marked as success/failure regarding the API response - Test if the accounts are marked as "disconnected" if the post failed Task #2081643 Forward-Port-Of: odoo/enterprise#5995
Original PR description
Add some tests, - Tests the priority on post 1. Image, if the user add images, they should be displayed on LinkedIn 2. URLs, if the user writes URLs in the message, but doesn't add an image, we must display a preview of the URL on LinkedIn 3. Text - Test if the post is marked as success/failure regarding the API response - Test if the accounts are marked as "disconnected" if the post failed Task #2081643 Forward-Port-Of: odoo/enterprise#5995
With a web_gantt view, if we click on a slot quickly after writing, values in the dialog box may be not updated. To fix this problem, we add mutex on the write function and before opening the dialog, we wait for this mutex. Forward-Port-Of: odoo/enterprise#6560
Original PR description
With a web_gantt view, if we click on a slot quickly after writing, values in the dialog box may be not updated. To fix this problem, we add mutex on the write function and before opening the dialog, we wait for this mutex. Forward-Port-Of: odoo/enterprise#6560
Fine-tuning of 1530d31dd3c25ffd520819d90e4d904e0a22b865 Before this commit, the value in the EC sales list report was always 0. It was adding the balance of the move lines, and each move has two move lines one with an amount in the credit and one with an amount in the debit. Now, the value is the sum of the invoices (moves) opw-2081572 Forward-Port-Of: odoo/enterprise#6558
Original PR description
Fine-tuning of 1530d31dd3c25ffd520819d90e4d904e0a22b865 Before this commit, the value in the EC sales list report was always 0. It was adding the balance of the move lines, and each move has two move lines one with an amount in the credit and one with an amount in the debit. Now, the value is the sum of the invoices (moves) opw-2081572 Forward-Port-Of: odoo/enterprise#6558
In version 12.0 the portal report assets were stored in the `assets_common` bundle, in version 13.0 the report assets are properly set in it's own bundle `report_assets_common`. This commit moves the assets for e-invoicing to `report_assets_common` bundle so the QR Code and the Original String are properly rendered in all reports. Before change: 
Original PR description
In version 12.0 the portal report assets were stored in the `assets_common` bundle, in version 13.0 the report assets are properly set in it's own bundle `report_assets_common`. This commit moves the assets for e-invoicing to `report_assets_common` bundle so the QR Code and the Original String are properly rendered in all reports. Before change:  After:  Forward-Port-Of: odoo/enterprise#6534
When requesting an appraisal, if no recipient is given in the wizard there is a traceback. An message cannot be sent to nobody. This commit makes the recipient field required in the view. Should be required at the model level in master branch (can't do that in stable 13.0) Forward-Port-Of: odoo/enterprise#6453
Original PR description
When requesting an appraisal, if no recipient is given in the wizard there is a traceback. An message cannot be sent to nobody. This commit makes the recipient field required in the view. Should be required at the model level in master branch (can't do that in stable 13.0) Forward-Port-Of: odoo/enterprise#6453