Daily updates from Odoo
Wednesday, November 6, 2019
2 changes · master
Code cleanup and technical improvements
Website carousel and quote carousel blocks were reorganized to behave more consistently in the page editor. This reduces editing glitches, allows separate backgrounds for carousels and slides, and improves duplicated carousel handling.
Original PR description
Previously, the carousel and quotes carousel snippets were the only ones that were not enclosed in section blocks. This had a number of undesirable side effects, such as editing the anchor on the…
Previously, the carousel and quotes carousel snippets were the only ones that were not enclosed in section blocks. This had a number of undesirable side effects, such as editing the anchor on the carousel breaking the carousel functionality, and the inability to separately choose a background for the carousel itself and individual slides. I also used this opportunity to move controls relative to the entire carousel onto the carousel itself rather than the individual slides. The sizing_y (vertical padding) will however keep targeting individual slides, as the carousel uses the height of its tallest slide, and also because padding on the carousel will not get covered by slide backgrounds and saty blank, which is unwanted. Lastly, most of the snippet options for the carousel were rewritten, as they were quite broken. There was some compatibility code for saas-3 left, some useless events were bound to the controls, even though they were already handled through event-delegation at the document level. Finally, most of the edition features were broken on duplicated carousels since the onClone method wasn't reassigning most of the things it needed to. task-2090180
This change simplifies how Odoo checks access to file attachments. It removes an overly broad employee-user requirement and leaves access decisions to the specific screens or features that use each attachment, reducing unnecessary access issues.
Original PR description
Since the commit 62c9dedafda0cbdc618641eaa80c49535ab0b5f6, the attachment required always a employee user access. Simplify corner case of attachment access check definition. It is the role of controller/model using attachment to give the rigth access for attachements. TASK_ID: 2004031 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr