Daily updates from Odoo
Thursday, November 7, 2019
34 changes · master
Enhancements to existing features
The technical administration menus for email and Discuss have been reorganized to make them easier to navigate. Administrators also gain direct access to notification records, improving visibility when investigating messaging activity.
The lead feedback modal now uses clearer, grammatically correct wording when partners explain why they are not interested in a lead or confirm customer contact. This improves professionalism and reduces confusion for users providing lead feedback.
Original PR description
These sentences weren't correct: Why aren't you interested **by** this lead? => Why aren't you interested **in** this lead? **Do you** have contacted the customer? => **I** have contacted the customer task-1838187 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The accounting reversal wizard now keeps track of all newly created reversal entries. This helps related processes, such as helpdesk ticket billing links, correctly connect invoice lines even when multiple reversals are created.
Original PR description
Add new move reversal line in wizard model, those new_move_ids are useful for the override in helpdesk. id=2017554 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The configuration help text now makes it clear that memory limit values must be entered in bytes. This helps first-time Odoo deployments avoid confusion and reduces the chance of incorrect server settings.
Original PR description
When you deploy Odoo for the first time, it is not explicit that you must enter a value in bytes for these specific parameters.
This change improves Odoo's internal test framework so cleanup actions run more reliably when shared test setup fails. It helps reduce leftover test data and unstable database states, making automated testing safer and more dependable for future development.
Original PR description
This commit backports bpo-24412, which allows the definition of class cleanups (addClassCleanup) similar to instance cleanups (addCleanup). This is useful for tests that override unittest's setUpClass (a LOT) and could crash during its execution: If this happens, it is possible that a bunch of crap is left in the database or even worse, the cursor becomes completely fucked; Thanks to the addClassCleanup, we can undo the damage done by the setUpClass.
The test suite has been updated so many tests no longer depend on preloaded demo data. This makes future demo data changes safer, improves test performance, and supports more flexible release and migration testing.
Original PR description
Purpose ======= This is the first huge step to improve the test suite in several ways: - Make them demo data independent, allowing to modify the demo data without having to adapt the tests depending on it. It also allows to have a beautiful + convenient demo dataset to make a demonstration, and to configure complex data in the tests to manage the corner cases. - Improve the test performances by converting them into SavepointCase. Each test will be rollbacked to it's initial state, after the setUpClass call. That way the different data are not re-created at each test for nothing. - Introduce several test classes in base/tests/common.py to launch a TransactionCase, HttpCase or SavepointCase test with an available demo user, portal user or a large set of partners. - This is the first step to tend to a rolling release process, allowing to execute the tests (or a subset of the tests) on a migrated base, for example. TaskID: 2075739
The phone calls configuration menu has been moved into the dedicated Phone / SMS technical menu. This makes administration screens easier to navigate by separating phone-related settings from Discuss, email, and mass mailing entries.
Original PR description
Purpose is to clean a bit technical menu, notably separating Discuss, Emails, Mass Mailing and Phone menu entries. Indeed there are quite a lot of menu entries and finding something is sometimes difficult. Task 2118599 Community PR odoo/odoo#39460 PR #6539
Phone call administration entries have been moved into the Phone / SMS technical menu. This makes the technical settings easier to navigate by separating phone-related items from other communication tools like Discuss, Email, and Mass Mailing.
Original PR description
Purpose is to clean a bit technical menu, notably separating Discuss, Emails, Mass Mailing and Phone menu entries. Indeed there are quite a lot of menu entries and finding something is sometimes difficult.
This update makes many accounting and payment tests independent from demo data, so demo examples can change without breaking validation. It also improves test reliability and performance by reusing prepared test data more efficiently, supporting faster and safer future releases.
Original PR description
Purpose ======= This is the first huge step to improve the test suite in several ways: - Make them demo data independent, allowing to modify the demo data without having to adapt the tests depending on it. It also allows to have a beautiful + convenient demo dataset to make a demonstration, and to configure complex data in the tests to manage the corner cases. - Improve the test performances by converting them into SavepointCase. Each test will be rollbacked to it's initial state, after the setUpClass call. That way the different data are not re-created at each test for nothing. - Introduce several test classes in base/tests/common.py to launch a TransactionCase, HttpCase or SavepointCase test with an available demo user, portal user or a large set of partners. - This is the first step to tend to a rolling release process, allowing to execute the tests (or a subset of the tests) on a migrated base, for example. TaskID: 2075739
Resolved issues and error corrections
This fix prevents website editing components that have already been removed or replaced from continuing their startup process. It reduces the risk of hidden editing glitches when page elements are refreshed quickly, especially for upcoming website snippet features.
Original PR description
This completes a commit that was made for the version saas-11.3 (12.0): https://github.com/odoo/odoo/commit/1440c8be0337c89e3d67d6d93e614c269c8689f1 Indeed, the logic was implemented for the appendTo, prependTo, etc methods but not for the attachTo... This could solve unknown problems in stable versions as well but was judged too risky to merge there. Indeed, if a real problem occurs in a stable version because of this, the condition can be added to the related widget individually. The problem was found in master: during website edition, the public widgets can be restarted if an element is edited... but sometimes the public widgets may be restarted in the same JS stack execution. The willStart method being async, the destroy method was called before the start method. This does not lead not any known problem with our current widgets but will create one for a new snippet being implemented.
This update keeps Enterprise features aligned with recent platform changes, preventing issues after the related core update. It affects marketing automation behavior and helps ensure campaigns continue to run as expected.
Original PR description
Closes https://github.com/odoo/enterprise/pull/6424
Miscellaneous changes
Description of the issue/feature this PR addresses: Follow up on https://github.com/odoo/odoo/commit/ac5469646cdea7c0990fbd5092eae26e7e0768ae#diff-04174b6f17e548b9a79222ae09c573db Current behavior before PR: Before this Commit, upgrade_boolean was applied on sale_coupon module while this has been moved to the community version from v13 Desired behavior after PR is merged: upgrade_boolean is not needed now -- I confirm I have signed the CLA and read the PR guidelines at www.od
Original PR description
Description of the issue/feature this PR addresses: Follow up on https://github.com/odoo/odoo/commit/ac5469646cdea7c0990fbd5092eae26e7e0768ae#diff-04174b6f17e548b9a79222ae09c573db Current behavior before PR: Before this Commit, upgrade_boolean was applied on sale_coupon module while this has been moved to the community version from v13 Desired behavior after PR is merged: upgrade_boolean is not needed now -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39985
Forward-Port-Of: odoo/odoo#39772
Original PR description
Forward-Port-Of: odoo/odoo#39772
Description of the issue/feature this PR addresses: Fixes https://github.com/odoo/odoo/pull/39583 This commit adds a default value for event_count Assigning default value for non-stored compute fields is required in 13.0 Current behavior before PR: ``` "Something went wrong!" res.partner(81,).event_count ``` Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39611
Original PR description
Description of the issue/feature this PR addresses: Fixes https://github.com/odoo/odoo/pull/39583 This commit adds a default value for event_count Assigning default value for non-stored compute fields is required in 13.0 Current behavior before PR: ``` "Something went wrong!" res.partner(81,).event_count ``` Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39611
When computing time statistics, we need to look for archived website visitors also to avoid a KeyError if we use the default 'Archived' filter. Description of the issue/feature this PR addresses: opw-2120562 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39918
Original PR description
When computing time statistics, we need to look for archived website visitors also to avoid a KeyError if we use the default 'Archived' filter. Description of the issue/feature this PR addresses: opw-2120562 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39918
From Sale create a new (or edit) SO. Add a note to the order with a log line without dash or whitespace (i.e. a url). Click on "Preview". The sale portal will try to display the long line which will overflow the standard size of the column creating an ugly overflow with a very long horizontal scrollbar. Adding a "break-all" rule to fix the sale portal case. opw-2088589 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/o
Original PR description
From Sale create a new (or edit) SO. Add a note to the order with a log line without dash or whitespace (i.e. a url). Click on "Preview". The sale portal will try to display the long line which will overflow the standard size of the column creating an ugly overflow with a very long horizontal scrollbar. Adding a "break-all" rule to fix the sale portal case. opw-2088589 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39878
Reproduce the issue: - In the CRM app, create a lead/opportunity. - Schedule a meeting for this opportunity via the chatter and click on create. - Go back, the "Meeting" stat button is now at 1 - Schedule a meeting for this opportunity via the chatter and click on edit then create. - Go back, the "Meeting" stat button is still at 1 Cause: When we click directly on create, the opportunity ID is in the defaults option but when we click on edit, there is no opportunity ID.
Original PR description
Reproduce the issue: - In the CRM app, create a lead/opportunity. - Schedule a meeting for this opportunity via the chatter and click on create. - Go back, the "Meeting" stat button is now at 1 - Schedule a meeting for this opportunity via the chatter and click on edit then create. - Go back, the "Meeting" stat button is still at 1 Cause: When we click directly on create, the opportunity ID is in the defaults option but when we click on edit, there is no opportunity ID. So, this commit use the context to retrieve the concerned opportunity and set it if it is not already set. I splitted the solution into a private method for a better readability. OPW-2092920 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39853
Without hr_recruitment it was not possible to import/export the hr.job as they were not visible. closes #22069 TaskID: 2088277 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39914 Forward-Port-Of: odoo/odoo#38881
Original PR description
Without hr_recruitment it was not possible to import/export the hr.job as they were not visible. closes #22069 TaskID: 2088277 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39914 Forward-Port-Of: odoo/odoo#38881
Reproduce this bug: - Install accounting & l10n_in - Create an invoice & print it The `<td>` dedicated to the HSN is always present so there is a cosmetic issue: the table is a *little* bit too large. OPW-2090663 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39837 Forward-Port-Of: o
Original PR description
Reproduce this bug: - Install accounting & l10n_in - Create an invoice & print it The `<td>` dedicated to the HSN is always present so there is a cosmetic issue: the table is a *little* bit too large. OPW-2090663 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39837 Forward-Port-Of: odoo/odoo#39815
Adapt website for 13.0 9996d04fd2 change of LinkDialog constructor arguments (to get back to same arguments as in 12.0). opw-2086444 Forward-Port-Of: odoo/odoo#39888
Original PR description
Adapt website for 13.0 9996d04fd2 change of LinkDialog constructor arguments (to get back to same arguments as in 12.0). opw-2086444 Forward-Port-Of: odoo/odoo#39888
Before this commit, when an event have multiples notifications, if the first notification is not ack when the second notification is shown, not only two are visualized but multiples notifications are raised. Now, only the correct number of notifications are shown. opw-2070852 Co-authored-by: Aaron Bohy <aab@odoo.com> Co-authored-by: Lucas Perais <lpe@odoo.com> Forward-Port-Of: odoo/odoo#39841 Forward-Port-Of: odoo/odoo#39807
Original PR description
Before this commit, when an event have multiples notifications, if the first notification is not ack when the second notification is shown, not only two are visualized but multiples notifications are raised. Now, only the correct number of notifications are shown. opw-2070852 Co-authored-by: Aaron Bohy <aab@odoo.com> Co-authored-by: Lucas Perais <lpe@odoo.com> Forward-Port-Of: odoo/odoo#39841 Forward-Port-Of: odoo/odoo#39807
Signed License agreement -- I confirm I have signed the CLA and read the PR guidelines at Forward-Port-Of: odoo/odoo#39223
Original PR description
Signed License agreement -- I confirm I have signed the CLA and read the PR guidelines at Forward-Port-Of: odoo/odoo#39223
In f29699231 (12.3) part of the code of the editor `Link Dialog` was moved to a web_editor/static/src/js/wysiwyg/plugin/link.js file/class. In 13.0 the 12.3 editor changes were mostly reverted in 35b61822a but part of the change of `Link Dialog` that was moved to another file/class was not moved back, thus: it does not work as expected => eg. if we add a link over an image, the image is removed. In this commit we get back the missing part as it was in 12.0 version. opw-2086444 Forward-Port-O
Original PR description
In f29699231 (12.3) part of the code of the editor `Link Dialog` was moved to a web_editor/static/src/js/wysiwyg/plugin/link.js file/class. In 13.0 the 12.3 editor changes were mostly reverted in 35b61822a but part of the change of `Link Dialog` that was moved to another file/class was not moved back, thus: it does not work as expected => eg. if we add a link over an image, the image is removed. In this commit we get back the missing part as it was in 12.0 version. opw-2086444 Forward-Port-Of: odoo/odoo#39858
- Create a child company B in parent company A - Go to company A - Create an invoice, create a payment (less than the invoice) - Open the payment matching widget - Associate the invoice and the payment, add a line for the open balance It is possible to choose accounts from company B. This is due to an incorrect forward-port of commit fb48e49779f71394a1d. It was valid in v11 but needed to be changed in v12. Fixes #39533 opw-2116411 Description of the issue/feature this PR addres
Original PR description
- Create a child company B in parent company A - Go to company A - Create an invoice, create a payment (less than the invoice) - Open the payment matching widget - Associate the invoice and the payment, add a line for the open balance It is possible to choose accounts from company B. This is due to an incorrect forward-port of commit fb48e49779f71394a1d. It was valid in v11 but needed to be changed in v12. Fixes #39533 opw-2116411 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39847
Forward-Port-Of: odoo/enterprise#6598
Original PR description
Forward-Port-Of: odoo/enterprise#6598
Was silently failing in 11.0 and 12.0, crashing in Odoo 13.0. Forward-Port-Of: odoo/enterprise#6390 Forward-Port-Of: odoo/enterprise#6364
Original PR description
Was silently failing in 11.0 and 12.0, crashing in Odoo 13.0. Forward-Port-Of: odoo/enterprise#6390 Forward-Port-Of: odoo/enterprise#6364
A) Fix the following use case: 1. Create a new partner, for testing 2. Create an account.move with one line on payable/receivable account and the test partner set. Keep it in draft and set its date in the past (so that it is overdue). 3. Open the followup report, remove the filter and search for the partner you made the receivable/payable line for. => The followup status of test partner tells that he has overdue invoices. It's wrong, since the account.move we made has not been posted. We
Original PR description
A) Fix the following use case: 1. Create a new partner, for testing 2. Create an account.move with one line on payable/receivable account and the test partner set. Keep it in draft and set its date in the past (so that it is overdue). 3. Open the followup report, remove the filter and search for the partner you made the receivable/payable line for. => The followup status of test partner tells that he has overdue invoices. It's wrong, since the account.move we made has not been posted. We should only consider posted entries to impact this status. (This first part is a 13.0 version of https://github.com/odoo/enterprise/pull/6589) B) Also fix the following case: 1. Create a test partner 2. Create a draft invoice for this partner, so that it is overdue 3. Open followup report => The invoice was reported as overdue. Forward-Port-Of: odoo/enterprise#6590
Install l10n_de_skr04,l10n_de_skr03,account_accountant Open Accounting settings User is not able to choose CoA because during initialization the account_report module created a move, so the CoA is considered choose. Avoid creating the move will restore the possibility to choose opw-2090654 Forward-Port-Of: odoo/enterprise#6580
Original PR description
Install l10n_de_skr04,l10n_de_skr03,account_accountant Open Accounting settings User is not able to choose CoA because during initialization the account_report module created a move, so the CoA is considered choose. Avoid creating the move will restore the possibility to choose opw-2090654 Forward-Port-Of: odoo/enterprise#6580
In the next case: 1. Configure your company to stamp with the PAC Sol. Factible 2. Create a new customer invoice with payment term PPD 3. Make the payment for the invoice in 2 (With a date in future, this to get an intentional error) In this case, returns a hidden error because the CFDI cannot be signed and hope a CFDI signed and is not found. Now, this was fixed, with the same code in the invoice model. OPW#2116463 Forward-Port-Of: odoo/enterprise#6593
Original PR description
In the next case: 1. Configure your company to stamp with the PAC Sol. Factible 2. Create a new customer invoice with payment term PPD 3. Make the payment for the invoice in 2 (With a date in future, this to get an intentional error) In this case, returns a hidden error because the CFDI cannot be signed and hope a CFDI signed and is not found. Now, this was fixed, with the same code in the invoice model. OPW#2116463 Forward-Port-Of: odoo/enterprise#6593
Install account_reports. From Accounting>Customers>Follow-up Reports select a followup and click on "Send Email". Aoctivating debug mode, and looking into the email queue is possible to see that the layout of the email is too much clobbered. The class-dependant style is applied by the transcoder https://github.com/odoo/odoo/blob/12.0/addons/web_editor/static/src/js/editor/transcoder.js but is not the case when sending the email, so the directive "width=100%" allow to achive an accepta
Original PR description
Install account_reports. From Accounting>Customers>Follow-up Reports select a followup and click on "Send Email". Aoctivating debug mode, and looking into the email queue is possible to see that the layout of the email is too much clobbered. The class-dependant style is applied by the transcoder https://github.com/odoo/odoo/blob/12.0/addons/web_editor/static/src/js/editor/transcoder.js but is not the case when sending the email, so the directive "width=100%" allow to achive an acceptable view. opw-2088622 Forward-Port-Of: odoo/enterprise#6574 Forward-Port-Of: odoo/enterprise#6521
- Create a child company B in parent company A - Go to company A - Create an invoice, create a payment (less than the invoice) - Open the payment matching widget - Associate the invoice and the payment, add a line for the open balance It is possible to choose accounts from company B. This is due to an incorrect forward-port of commit fb48e49779f71394a1d. It was valid in v11 but needed to be changed in v12. Fixes https://github.com/odoo/odoo/issues/39533 opw-2116411
Original PR description
- Create a child company B in parent company A - Go to company A - Create an invoice, create a payment (less than the invoice) - Open the payment matching widget - Associate the invoice and the payment, add a line for the open balance It is possible to choose accounts from company B. This is due to an incorrect forward-port of commit fb48e49779f71394a1d. It was valid in v11 but needed to be changed in v12. Fixes https://github.com/odoo/odoo/issues/39533 opw-2116411
In module base, the function _post_pdf splits the pdf based on outlines. An outline is a <h?> html tag found on the document. That's why the h1 tag generated a traceback. opw:2089685 Forward-Port-Of: odoo/enterprise#6562 Forward-Port-Of: odoo/enterprise#6541
Original PR description
In module base, the function _post_pdf splits the pdf based on outlines. An outline is a <h?> html tag found on the document. That's why the h1 tag generated a traceback. opw:2089685 Forward-Port-Of: odoo/enterprise#6562 Forward-Port-Of: odoo/enterprise#6541
Steps to reproduce the bug: - Let's consider two companies C1 and C2 and an internal user allowed to access it - In general settings of each copany, tick "Synchronize bills/invoies - In C1, create a customer invoice for C2 and post it Bug: In C2, a vendor bill VB was created with the wrong accounts (Account payable 211000 from C1 instaed of Fournisseurs 440000 from C2). So when accessing VB in C2, an access rights error was raised because the Account payable
Original PR description
Steps to reproduce the bug:
- Let's consider two companies C1 and C2 and an internal user allowed to access it
- In general settings of each copany, tick "Synchronize bills/invoies
- In C1, create a customer invoice for C2 and post it
Bug:
In C2, a vendor bill VB was created with the wrong accounts (Account payable 211000 from C1 instaed of
Fournisseurs 440000 from C2). So when accessing VB in C2, an access rights error was raised because the
Account payable 211000 was not readable from C2.
opw:2091937
Forward-Port-Of: odoo/enterprise#6571It was really hard to read the financial reports since the indentation was chaotic: all accounts were set on the second indent level even if the groups were indented further, and the values of debit and credit were kinda centered instead of right aligned. Because the alignement has changed, we also had to add a border around debit and credit so that we can see what the 'super-columns' are refering to. Forward-Port-Of: odoo/enterprise#6502
Original PR description
It was really hard to read the financial reports since the indentation was chaotic: all accounts were set on the second indent level even if the groups were indented further, and the values of debit and credit were kinda centered instead of right aligned. Because the alignement has changed, we also had to add a border around debit and credit so that we can see what the 'super-columns' are refering to. Forward-Port-Of: odoo/enterprise#6502