Daily updates from Odoo
Monday, November 18, 2019
21 changes · master
Resolved issues and error corrections
The time off allocation form no longer shows an outdated generated name while a manager is editing fields. This prevents confusion because the displayed name is only shown once it can be accurately calculated after saving or updating the relevant description.
Original PR description
When changing fields in Manager -> Allocation Form, the name (display_name) was recalculated only after the form was saved or only after the description was changed. TASK-ID: 2092844 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Salary confirmation emails now show the same gross wage that applicants see when they configure their package with extra days off. This avoids confusion by ensuring the emailed offer reflects holiday-related wage adjustments.
Original PR description
When an applicant takes extra days off, the gross wage is adapted on the frontend configuration page. But when the confirmation email is sent, the gross without counting the extra holidays is displayed.
Miscellaneous changes
This field was deemed redundant and thus removed from the view but we forgot the use case where multiple valuation adjustment lines are generated (eg applying a lc on multiple pickings) and the added value by picking must be adapted manually (eg decrease one to increase the other). task-2125127 Forward-Port-Of: odoo/odoo#40444
Original PR description
This field was deemed redundant and thus removed from the view but we forgot the use case where multiple valuation adjustment lines are generated (eg applying a lc on multiple pickings) and the added value by picking must be adapted manually (eg decrease one to increase the other). task-2125127 Forward-Port-Of: odoo/odoo#40444
Reproduce the issue - Install Projects and Studio - Edit the projects app's kanban view - Enable group by stage - Close studio - Add several stages The stages are wrapped to the next line Cause I think the problem comes from c5f6802, we apply a wrapping to all the kanban_dashboard items and in this cases the items are the stages. This commits apply the wrap only on non-grouped kanban dashboard. OPW-2123031 Description of the issue/fe
Original PR description
Reproduce the issue
- Install Projects and Studio
- Edit the projects app's kanban view
- Enable group by stage
- Close studio
- Add several stages
The stages are wrapped to the next line
Cause
I think the problem comes from c5f6802, we apply a wrapping to
all the kanban_dashboard items and in this cases the items are
the stages.
This commits apply the wrap only on non-grouped kanban dashboard.
OPW-2123031
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#40352
Forward-Port-Of: odoo/odoo#40333TaskID: 2088559 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40373 Forward-Port-Of: odoo/odoo#40322
Original PR description
TaskID: 2088559 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40373 Forward-Port-Of: odoo/odoo#40322
It was not possible to search a fiscal position by name without a custom filter. opw:2124184 Forward-Port-Of: odoo/odoo#40261
Original PR description
It was not possible to search a fiscal position by name without a custom filter. opw:2124184 Forward-Port-Of: odoo/odoo#40261
If a warehouse is created without code (eg. when created as a new group from a kanban view grouped by warehouse) we would get a traceback instead of an error: ``` The operation cannot be completed: - Create/update: a mandatory field is not set. - Delete: another model requires the record being deleted. If possible, archive it instead. Model: Warehouse (stock.warehouse), Field: Short Name (code) ``` opw-2124162 fix #40233 Forward-Port-Of: odoo/odoo#40340 Forward-Port-Of: odoo/odoo#402
Original PR description
If a warehouse is created without code (eg. when created as a new group from a kanban view grouped by warehouse) we would get a traceback instead of an error: ``` The operation cannot be completed: - Create/update: a mandatory field is not set. - Delete: another model requires the record being deleted. If possible, archive it instead. Model: Warehouse (stock.warehouse), Field: Short Name (code) ``` opw-2124162 fix #40233 Forward-Port-Of: odoo/odoo#40340 Forward-Port-Of: odoo/odoo#40267
Lead/Opportunity type ===================== In the settings, if ``group_use_leads`` is checked, we add the group ``use_leads`` to all users in the group ``base.group_user`` To know if the setting is checked, in the model ``crm.lead``, we compute this code, ``` self.env['res.users'].has_group('crm.group_use_lead') ``` In 12.0 ======= When we compute ``sudo``, we are as the admin user. The admin user is in the group ``base.group_user`` and so, he can be in the group ``use_leads``, s
Original PR description
Lead/Opportunity type ===================== In the settings, if ``group_use_leads`` is checked, we add the group ``use_leads`` to all users in the group ``base.group_user`` To know if the setting is…
Lead/Opportunity type
=====================
In the settings, if ``group_use_leads`` is checked, we add the group ``use_leads`` to all users in the group ``base.group_user``
To know if the setting is checked, in the model ``crm.lead``, we compute this code,
```
self.env['res.users'].has_group('crm.group_use_lead')
```
In 12.0
=======
When we compute ``sudo``, we are as the admin user.
The admin user is in the group ``base.group_user`` and so, he can be in the group ``use_leads``,
so everything work fine.
In 13.0
=======
When we perform a ``sudo``, we keep the same user.
But the visitor is not in the group ``base.group_user`` (he is in the group ``base.group_public``)
So, the visitor can never be in the group ``use_leads``
Fix
===
To fix it, we just need to compute the method ``has_group`` as the super user (which is in the group ``base.group_user``).
```
self.with_user(SUPERUSER_ID).env['res.users'].has_group('crm.group_use_lead')
```
Task #2124421
Forward-Port-Of: odoo/odoo#40310Reproduce the issue - Install Events - Set the english default format date to %d/%m/%Y - Create an event & edit the date The date is set correctly in the backend - Edit the date of an event on the website directly The date format is still the old one Cause The `from_html` method of DateTime was using `parser.parse` and ignore the user's date format. This commit changes `parser.parse` into `datetime.strptime` taking into consideration the u
Original PR description
Reproduce the issue
- Install Events
- Set the english default format date to %d/%m/%Y
- Create an event & edit the date
The date is set correctly in the backend
- Edit the date of an event on the website directly
The date format is still the old one
Cause
The `from_html` method of DateTime was using `parser.parse` and
ignore the user's date format.
This commit changes `parser.parse` into `datetime.strptime` taking
into consideration the user's date format.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#40395task-2125070 Forward-Port-Of: odoo/odoo#40402
Original PR description
task-2125070 Forward-Port-Of: odoo/odoo#40402
-In CRM, click the CREATE button. -Only enter a title for the new lead and directly click ADD. -Click on the newly created lead to view its details. Before this commit: although a probability could be computed based on the stage of the lead, this field has a default value and, at creation time, this value doesn't end up in the list of values from which the `_write_probability` function decide whether to recompute the probability. After this commit: The `_write_probability` funct
Original PR description
-In CRM, click the CREATE button. -Only enter a title for the new lead and directly click ADD. -Click on the newly created lead to view its details. Before this commit: although a probability could be computed based on the stage of the lead, this field has a default value and, at creation time, this value doesn't end up in the list of values from which the `_write_probability` function decide whether to recompute the probability. After this commit: The `_write_probability` function, renamed `_update_probability`, doesn't check whether it should or not update the probability. It just does it. This function is directly called in the `create`. `_check_if_update_probability` is called before `_update_probability` in the `write`. Task ID : 2081480 Forward-Port-Of: odoo/odoo#39003
### Description of the issue/feature this PR addresses: Manual taxes widget in the invoice form view is broken. ### Current behavior before PR: We notice this when testing Argentinian localization. [video](https://drive.google.com/file/d/1ThBsQJCMPOw0ho4UP60fAkyWJnsUAC9b/view) ### Desired behavior after PR is merged: Now the widget is properly working, and the taxes are properly show taking into account the Argentinian rules for which taxes should be discriminate or not taking int
Original PR description
### Description of the issue/feature this PR addresses: Manual taxes widget in the invoice form view is broken. ### Current behavior before PR: We notice this when testing Argentinian localization. [video](https://drive.google.com/file/d/1ThBsQJCMPOw0ho4UP60fAkyWJnsUAC9b/view) ### Desired behavior after PR is merged: Now the widget is properly working, and the taxes are properly show taking into account the Argentinian rules for which taxes should be discriminate or not taking into account the issuer/receptor responsibility and type of document -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39291
Install accounting and activate a new language. Under Accounting>Settings>Terms and Conditions input something, save and then click on the near lanuage button. A popup will appear with only the possibility to close and save but with no text. This is because no row is fetched from the ir.translation table, because the domain for the search is ``` ['&', ['res_id', '=', None], ['name', '=like', 'res.config.settings,%'], ['name', '=', 'undefined'] ] ``` * wrong res.
Original PR description
Install accounting and activate a new language. Under
Accounting>Settings>Terms and Conditions input something, save and then
click on the near lanuage button.
A popup will appear with only the possibility to close and save but with
no text.
This is because no row is fetched from the ir.translation table, because
the domain for the search is
```
['&',
['res_id', '=', None],
['name', '=like', 'res.config.settings,%'],
['name', '=', 'undefined']
]
```
* wrong res.id "None" instead of the correct one (1)
* wrong name pointing to somewhat related to 'res.config.settings'
(the field name is "res.company,invoice_terms")
* another wrong condition on name equal "undefined"
Adding more checks on unassigned values as well as a check to avoid
double entry in the domain.
opw-2091779
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#39410### Description of the issue/feature this PR addresses: stdnum.ar.cbu is not available in odoo saas environment because is using an old version of stdnum package. ### Current behavior before PR: In demo https://demo2.odoo.com/ when try to install l10n_ar module it raise the next error ```python Odoo Server Error Traceback (most recent call last): File "/home/odoo/src/odoo/13.0/odoo/http.py", line 619, in _handle_exception return super(JsonRequest, self)._handle_exception(
Original PR description
### Description of the issue/feature this PR addresses: stdnum.ar.cbu is not available in odoo saas environment because is using an old version of stdnum package. ### Current behavior before PR: In…
### Description of the issue/feature this PR addresses:
stdnum.ar.cbu is not available in odoo saas environment because is using an old version of stdnum package.
### Current behavior before PR:
In demo https://demo2.odoo.com/ when try to install l10n_ar module it raise the next error
```python
Odoo Server Error
Traceback (most recent call last):
File "/home/odoo/src/odoo/13.0/odoo/http.py", line 619, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/home/odoo/src/odoo/13.0/odoo/http.py", line 309, in _handle_exception
raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
File "/home/odoo/src/odoo/13.0/odoo/tools/pycompat.py", line 14, in reraise
raise value
File "/home/odoo/src/odoo/13.0/odoo/http.py", line 664, in dispatch
result = self._call_function(**self.params)
File "/home/odoo/src/odoo/13.0/odoo/http.py", line 345, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/home/odoo/src/odoo/13.0/odoo/service/model.py", line 93, in wrapper
return f(dbname, *args, **kwargs)
File "/home/odoo/src/odoo/13.0/odoo/http.py", line 338, in checked_call
result = self.endpoint(*a, **kw)
File "/home/odoo/src/odoo/13.0/odoo/http.py", line 909, in __call__
return self.method(*args, **kw)
File "/home/odoo/src/odoo/13.0/odoo/http.py", line 510, in response_wrap
response = f(*args, **kw)
File "/home/odoo/src/odoo/13.0/addons/web/controllers/main.py", line 1242, in call_button
action = self._call_kw(model, method, args, kwargs)
File "/home/odoo/src/odoo/13.0/addons/web/controllers/main.py", line 1230, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/home/odoo/src/odoo/13.0/odoo/api.py", line 410, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/home/odoo/src/odoo/13.0/odoo/api.py", line 397, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "<decorator-gen-58>", line 2, in button_immediate_install
File "/home/odoo/src/odoo/13.0/odoo/addons/base/models/ir_module.py", line 72, in check_and_log
return method(self, *args, **kwargs)
File "/home/odoo/src/odoo/13.0/odoo/addons/base/models/ir_module.py", line 463, in button_immediate_install
return self._button_immediate_function(type(self).button_install)
File "/home/odoo/src/odoo/13.0/odoo/addons/base/models/ir_module.py", line 573, in _button_immediate_function
modules.registry.Registry.new(self._cr.dbname, update_module=True)
File "/home/odoo/src/odoo/13.0/odoo/modules/registry.py", line 86, in new
odoo.modules.load_modules(registry._db, force_demo, status, update_module)
File "/home/odoo/src/odoo/13.0/odoo/modules/loading.py", line 420, in load_modules
loaded_modules, update_module, models_to_check)
File "/home/odoo/src/odoo/13.0/odoo/modules/loading.py", line 312, in load_marked_modules
perform_checks=perform_checks, models_to_check=models_to_check
File "/home/odoo/src/odoo/13.0/odoo/modules/loading.py", line 179, in load_module_graph
load_openerp_module(package.name)
File "/home/odoo/src/odoo/13.0/odoo/modules/module.py", line 365, in load_openerp_module
__import__('odoo.addons.' + module_name)
File "/home/odoo/src/odoo/13.0/addons/l10n_ar/__init__.py", line 3, in <module>
from . import models
File "/home/odoo/src/odoo/13.0/addons/l10n_ar/models/__init__.py", line 14, in <module>
from . import res_partner_bank
File "/home/odoo/src/odoo/13.0/addons/l10n_ar/models/res_partner_bank.py", line 3, in <module>
import stdnum.ar.cbu
ImportError: No module named 'stdnum.ar.cbu'
```
**IMPORTANT**: This do not happend when installing l10n_ar in 13.0 runbot instance.
### Desired behavior after PR is merged:
We add a try except in order to avoid this error when using an enviorment that have python-stdnum < 1.11. Now the raised error does not occurs and we add information in the log about what happens.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#40133Create a pricelist item with a fixed price, e.g. 10.20. The amount is displayed as 10.200....01. To avoid this, we format the float correctly. opw-2122622 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40347 Forward-Port-Of: odoo/odoo#40321
Original PR description
Create a pricelist item with a fixed price, e.g. 10.20. The amount is displayed as 10.200....01. To avoid this, we format the float correctly. opw-2122622 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40347 Forward-Port-Of: odoo/odoo#40321
The field `account_id` has been removed from the tax, it is not on the repartition line. opw-2121720 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40334
Original PR description
The field `account_id` has been removed from the tax, it is not on the repartition line. opw-2121720 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40334
- Create Product A: Routes: MTO and Manufacture Manufacturing Lead Time: 20 days - Create Product B: Routes: MTO and Buy Add a supplier with Delivery Lead Time: 10 days - Create a BOM: 1 unit of B to produce 1 unit of A - Create a SO for A, validate A MO is created with a Deadline set at SO order date - 20 days => OK A PO is created with order date set at SO order date - 10 days => Not OK, it should be - 30 days. In v13, the raw materials expected date is the order date.
Original PR description
- Create Product A: Routes: MTO and Manufacture Manufacturing Lead Time: 20 days - Create Product B: Routes: MTO and Buy Add a supplier with Delivery Lead Time: 10 days - Create a BOM: 1 unit of B to…
- Create Product A: Routes: MTO and Manufacture Manufacturing Lead Time: 20 days - Create Product B: Routes: MTO and Buy Add a supplier with Delivery Lead Time: 10 days - Create a BOM: 1 unit of B to produce 1 unit of A - Create a SO for A, validate A MO is created with a Deadline set at SO order date - 20 days => OK A PO is created with order date set at SO order date - 10 days => Not OK, it should be - 30 days. In v13, the raw materials expected date is the order date. In v12, this date is computed as: order date minus Manufacturing Lead Time However, in both versions the PO order date is computed as the raw materials expected date minus Delivery Lead Time of the supplier. This comes from a change in the semantic of 'Planned Date' and 'Planned End Date'. In v13, the Manufacturing Lead Time is only taken into account in the Deadline, while in v12 it was taken into account in the Planned Date. However, the expected date of the raw materials still relies on the latter, not on the Deadline. In order to solve this, we apply the 'Manufacturing Lead Time' of the product and the company to 'Planned Date', 'Planned End Date' and 'Deadline' when the MO is created. opw-2118951 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40315
Before that, an error message was shown to the user when Banxico didn't answer, saying that the rate of the main currency was not supported by Banxico (whatever the currency, it happened with EUR on runbot: http://runbot.odoo.com/runbot/build/683935). This was due to the way the values returned by Banxico were managed if this answer meant no information could be retrieved. v12 API requires to return False in this case, not a (probably vert) partial mapping of exchange rates. Forward-Port-Of: od
Original PR description
Before that, an error message was shown to the user when Banxico didn't answer, saying that the rate of the main currency was not supported by Banxico (whatever the currency, it happened with EUR on runbot: http://runbot.odoo.com/runbot/build/683935). This was due to the way the values returned by Banxico were managed if this answer meant no information could be retrieved. v12 API requires to return False in this case, not a (probably vert) partial mapping of exchange rates. Forward-Port-Of: odoo/enterprise#6683
Steps to reproduce the ubg: - On Safari 13.0 go to sign - Click on send button on a sign.template record - Click on Employee or HR Responsible Bug: The dropdown menu with all the possible selections was not displayed. opw:2087891 Forward-Port-Of: odoo/enterprise#6717
Original PR description
Steps to reproduce the ubg: - On Safari 13.0 go to sign - Click on send button on a sign.template record - Click on Employee or HR Responsible Bug: The dropdown menu with all the possible selections was not displayed. opw:2087891 Forward-Port-Of: odoo/enterprise#6717
Forward-Port-Of: odoo/enterprise#6676
Original PR description
Forward-Port-Of: odoo/enterprise#6676
When submitting the British VAT report, if the VAT number of the current company is not set, the error message should also be properly displayed. opw-2121120 Forward-Port-Of: odoo/enterprise#6729
Original PR description
When submitting the British VAT report, if the VAT number of the current company is not set, the error message should also be properly displayed. opw-2121120 Forward-Port-Of: odoo/enterprise#6729