Daily updates from Odoo
Tuesday, November 19, 2019
20 changes · master
Enhancements to existing features
The documentation was improved to better explain how company-specific display behavior works. This helps implementers and developers understand the expected behavior more easily, reducing confusion when configuring or extending multi-company features.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Developers can now use more flexible dynamic filters in views without being blocked by overly strict validation. This helps teams build adaptable business screens while reducing unnecessary development friction.
Original PR description
We do not want to block developers from using dynamic domains like:
```python
domain="country_id and [('country_id', 'in', [False, country_id])] or []"
```Resolved issues and error corrections
This corrects a small typo that could cause analytic account filtering rules to be built incorrectly. The fix helps ensure users see the right analytic records when the system applies those filters.
Original PR description
Leftover typo from #36804 . -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an error when a product is created or edited from the website and its image is deleted. If no image URL is available, the system now handles it gracefully instead of showing a traceback, making product editing more reliable.
Original PR description
Task : https://www.odoo.com/web?#id=2063293&action=327&model=project.task&view_type=form&menu_id=4720 Pad : https://pad.odoo.com/p/r.c134d9b0d8ea08eb773491d23bb96507 I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update keeps accounting reports working after a related change in the main Odoo platform. It prevents disruptions caused by an internal method change, with no expected change to everyday report usage.
Original PR description
Followup of odoo/odoo#38859
The Approvals app now tracks changes using the correct underlying field reference instead of only the field name. This helps ensure tracked approval changes are linked reliably and avoids confusion or errors in audit history.
Original PR description
This commit replaces the name of the tracked field by its reference. TaskID: 2088634
Miscellaneous changes
Avoid redirect from `/favicon.ico` to `/<lang>/facivon.ico` at each request Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40487
Original PR description
Avoid redirect from `/favicon.ico` to `/<lang>/facivon.ico` at each request Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40487
Task: https://www.odoo.com/web?#id=37726&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.f2cd5345ee05b29072f47d4d393f5900 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#33674
Original PR description
Task: https://www.odoo.com/web?#id=37726&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.f2cd5345ee05b29072f47d4d393f5900 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#33674
Issue was blocking the system to confirm a SO/Invoice after redirection from paypal. In V13 is getting the value of the paypal_urls using paypal_get_form_action_url() returning the correct string, not a dict anymore Closing opw-2119027 opw-2122833 Forward-Port-Of: odoo/odoo#40432
Original PR description
Issue was blocking the system to confirm a SO/Invoice after redirection from paypal. In V13 is getting the value of the paypal_urls using paypal_get_form_action_url() returning the correct string, not a dict anymore Closing opw-2119027 opw-2122833 Forward-Port-Of: odoo/odoo#40432
In e29c08969 source mode was reintroduced. Since complex template seemed broken when it was edited, the feature of forcing source mode when there is a `% if ` or `% set` template directive of 12.3 was reintroduced. Since the direct breaking of the template was mostly solved with the added line: `options.prettifyHtml = false;` the force source mode is not so much necessary and there was report that it was not very clear. In this commit it is removed, and if necessary could be reintroduced lat
Original PR description
In e29c08969 source mode was reintroduced. Since complex template seemed broken when it was edited, the feature of forcing source mode when there is a `% if ` or `% set` template directive of 12.3 was reintroduced. Since the direct breaking of the template was mostly solved with the added line: `options.prettifyHtml = false;` the force source mode is not so much necessary and there was report that it was not very clear. In this commit it is removed, and if necessary could be reintroduced later with clearer implementation. opw-2123730 fix #40410 Forward-Port-Of: odoo/odoo#40421
Open Mass Mailing in debug mode, create a new mass mailing, choose a template for the body, check with the inspector the iframe. The head of the iframe does not have the debug assets. This is because the global variable relative to the debug mode gets temporary overwritten before solving the promise. For Gorash this has been done for: * Performance as all the editor assets must be inserted into the iframe assets * As an indication to bugfixers that the fix must not be done in this
Original PR description
Open Mass Mailing in debug mode, create a new mass mailing, choose a template for the body, check with the inspector the iframe. The head of the iframe does not have the debug assets. This is because the global variable relative to the debug mode gets temporary overwritten before solving the promise. For Gorash this has been done for: * Performance as all the editor assets must be inserted into the iframe assets * As an indication to bugfixers that the fix must not be done in this bundle as it is the exact same content as outside of the iframe and the exact same content as previous Odoo versions. Removing the override given that: * If someone enable debug=assets he/she is aware of the performance hit * A ticket has been opened because the iframe is hard to debug without debug assets. opw-2117649 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40270
Remove warnings Add missing parameter posonlyargs (cf [position swap](https://docs.python.org/3/whatsnew/changelog.html#python-3-8-0-beta-3)) Forward-Port-Of: odoo/odoo#40355
Original PR description
Remove warnings Add missing parameter posonlyargs (cf [position swap](https://docs.python.org/3/whatsnew/changelog.html#python-3-8-0-beta-3)) Forward-Port-Of: odoo/odoo#40355
Description of the issue/feature this PR addresses: Without the product_uom_category_id set you cannot edit this tree view. There is a domain [('category_id', '=', product_uom_category_id)] triggered from this view whcich is not fulfilled if we do not have the field set in the tree. Fixes https://github.com/odoo/odoo/issues/39543 Current behavior before PR: You cannot edit the tree view its definition for `view_stock_move_raw_tree` as you'll get an error saying: ``` Error while validating
Original PR description
Description of the issue/feature this PR addresses: Without the product_uom_category_id set you cannot edit this tree view. There is a domain [('category_id', '=', product_uom_category_id)] triggered…
Description of the issue/feature this PR addresses: Without the product_uom_category_id set you cannot edit this tree view. There is a domain [('category_id', '=', product_uom_category_id)] triggered from this view whcich is not fulfilled if we do not have the field set in the tree.
Fixes https://github.com/odoo/odoo/issues/39543
Current behavior before PR: You cannot edit the tree view its definition for `view_stock_move_raw_tree` as you'll get an error saying:
```
Error while validating view
Field 'product_uom_category_id' used in attributes must be present in view but is missing:
- 'product_uom_category_id' in domain="[('category_id', '=', product_uom_category_id)]"
Error context:
View `stock.move.raw.tree`
[view_id: 617, xml_id: mrp.view_stock_move_raw_tree, model: stock.move, parent_id: n/a]
```
Desired behavior after PR is merged: You're able to edit the tree view definition as the domain is fulfilled.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#39551If a Bill of Material is created without code (eg. when created as a new group from a kanban view grouped by BoM) we would get a traceback instead of an error. With this changeset, we get a "You cannot create a new Bill of Material from here." error if it is being tried. opw-2124162 fix #38904 Forward-Port-Of: odoo/odoo#40377 Forward-Port-Of: odoo/odoo#40289
Original PR description
If a Bill of Material is created without code (eg. when created as a new group from a kanban view grouped by BoM) we would get a traceback instead of an error. With this changeset, we get a "You cannot create a new Bill of Material from here." error if it is being tried. opw-2124162 fix #38904 Forward-Port-Of: odoo/odoo#40377 Forward-Port-Of: odoo/odoo#40289
_Probably not the best way, to check to avoid xss and stuff_ Forward-Port-Of: odoo/odoo#40438 Forward-Port-Of: odoo/odoo#39755
Original PR description
_Probably not the best way, to check to avoid xss and stuff_ Forward-Port-Of: odoo/odoo#40438 Forward-Port-Of: odoo/odoo#39755
Forward-Port-Of: odoo/odoo#40419
Original PR description
Forward-Port-Of: odoo/odoo#40419
The mail_notification_paynow template expects a model_description parameter or defaults to the model _description, "Journal Entries". We add, similar to 4a3fd02af4a on sale.order, a type_name field to get the correct type name in an extensible way. Similar to 8c91b193fca3b, 65b6375cf3f9b. opw 2120545 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR gu
Original PR description
The mail_notification_paynow template expects a model_description parameter or defaults to the model _description, "Journal Entries". We add, similar to 4a3fd02af4a on sale.order, a type_name field to get the correct type name in an extensible way. Similar to 8c91b193fca3b, 65b6375cf3f9b. opw 2120545 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40216
Adds Lithuanian Business Accounting Standard (BAS) reports: * Balance Sheet * Profit/Loss Report Forward-port of v12 pr 5634 Forward-Port-Of: odoo/enterprise#6710
Original PR description
Adds Lithuanian Business Accounting Standard (BAS) reports: * Balance Sheet * Profit/Loss Report Forward-port of v12 pr 5634 Forward-Port-Of: odoo/enterprise#6710
Due to the usage of the sign_request_ids field in a @depends, this module depends on the module defining the hr_contract_sign field. https://github.com/odoo/enterprise/blame/13.0/hr_contract_salary/models/hr_contract.py#L46 Forward-Port-Of: odoo/enterprise#6764
Original PR description
Due to the usage of the sign_request_ids field in a @depends, this module depends on the module defining the hr_contract_sign field. https://github.com/odoo/enterprise/blame/13.0/hr_contract_salary/models/hr_contract.py#L46 Forward-Port-Of: odoo/enterprise#6764
Purpose ======= 1/ When creating a salary structure (Payroll > Configuration > Structures), give in the name and type. Save. All works fine 2/ Redo the same but open one of the salary rules under and discard it. Try to save the structure. You get an error The operation cannot be completed: - Create/update: a mandatory field is not set. - Delete: another model requires the record being deleted. If possible, archive it instead. Model: Salary Rule (hr.salary.rule), Field: Py
Original PR description
Purpose ======= 1/ When creating a salary structure (Payroll > Configuration > Structures), give in the name and type. Save. All works fine 2/ Redo the same but open one of the salary rules under and discard it. Try to save the structure. You get an error The operation cannot be completed: - Create/update: a mandatory field is not set. - Delete: another model requires the record being deleted. If possible, archive it instead. Model: Salary Rule (hr.salary.rule), Field: Python Condition (condition_python) Forward-Port-Of: odoo/enterprise#6655