Daily updates from Odoo
Monday, November 25, 2019
26 changes · master
Enhancements to existing features
Views opened from the Product Margin report no longer show unnecessary Create and Edit buttons. This reduces confusion and helps users focus on reviewing margin information rather than making changes from report drill-downs.
Original PR description
Description of the issue/feature this PR addresses: Fixes https://github.com/odoo/odoo/issues/39069 Current behavior before PR: Desired behavior after PR is merged: Create and Edit Buttons are not needed on views being opened from Product Margin report -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Web Studio “add chatter” option now looks better aligned and responds more quickly when users interact with it. This creates a smoother, more polished editing experience without changing business workflows.
Original PR description
task - https://www.odoo.com/web#id=2094895&action=327&model=project.task&view_type=form&menu_id=4720 pad - https://pad.odoo.com/p/r.9e4262257b785c8623839c8ffa87bfb3 - The label 'add chatter' widget was not vertically centered. By this commit the design issue has been improved. - Also the transition effect speed has been increased for better user experience.
The payroll account test setup for Belgian localization was adjusted so it runs after installation, avoiding failures caused by company setup data not being available early enough. This improves test reliability without changing business payroll behavior for users.
Original PR description
Rule parameter tests are tagged as post install because when creating a company, the required field `extract_show_ocr_option_selection` has a column in database (with a non null constraint) but the field is not yet loaded in the registry. Therefore, the default value is not used when inserting in the database and the contraint fails.
Resolved issues and error corrections
This change fixes an internal test that could fail when Odoo runs with stricter logging settings. It helps keep automated checks stable across different server configurations without changing business features or user workflows.
The accounting menu label now uses the same “Refunds” wording as other menus. This reduces confusion for users by keeping terminology consistent across the system.
Original PR description
Description of the issue/feature this PR addresses: Fix wording to be like other menus Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The LDAP login integration now handles names and other values containing non-English or accented characters correctly. This prevents errors during later processing and improves reliability for companies using LDAP directories with international user data.
Original PR description
Non-ascii characters in LDAP don't cause a python unicode string in returned ldap entries, this commit fixes this. Before this commit, further string operations on ldap values with non-ascii characters fail. Cherry-pick of #12745 by @hbrunn
The map view now ignores drag, zoom, and hover actions when users interact with an alert message placed over the map. This prevents accidental map movement and makes the notice less alarming by showing it as an informational message.
Original PR description
Task : https://www.odoo.com/web?#id=%20&action=327&model=project.task&view_type=form&menu_id=4720 PAD : https://pad.odoo.com/p/openerp-project.task-E057WKI46W
The barcode settings page now hides the default barcode nomenclature option unless debug mode is enabled. This reduces clutter and helps prevent regular users from changing an advanced configuration by mistake.
Original PR description
Task: https://www.odoo.com/web#id=2128359&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.2e11b3bdf793ef0a351394f97b30db91
Code cleanup and technical improvements
The Survey app code and templates were reorganized to make future enhancements easier to build and maintain. This cleanup removes unused or duplicated code and separates survey pages, statistics, and management templates without intended changes for end users.
Original PR description
PURPOSE Purpose is to perform some cleaning in survey models: naming, ordering, dead code [0]. As new features are about to land in survey, notably live interactions [1] and new survey building [2] performing a pre cleaning is necessary [3]. SPECIFICATIONS This merge contains three commits doing * code move; * dead code removal; * templates split to ease understanding and reading; See sub commits for more details. LINKS [0] Related to Task ID 2144393 (surveys split / cleaning) [1] Task ID 1972640 (live interactions) [2] Task ID 2119587 (new frontend for building surveys) [3] Task ID 2061901 (survey models cleaning and preparation) PR #40623
The appraisal module’s sample survey data was cleaned up to better align with related updates. This is an internal housekeeping change that improves demo data quality without changing day-to-day user workflows.
Miscellaneous changes
A customer reported an issue when he tried to add a link on the blog covers of his blog. The link is displayed as text and it's added to all the covers.  According to SBU, the user should not do this. This commit prevents the user from adding a link on a blog cover. OPW-2119924 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40783 Forward-Port-Of: odoo/odoo
Original PR description
A customer reported an issue when he tried to add a link on the blog covers of his blog. The link is displayed as text and it's added to all the covers.  According to SBU, the user should not do this. This commit prevents the user from adding a link on a blog cover. OPW-2119924 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40783 Forward-Port-Of: odoo/odoo#40608
Description of the issue/feature this PR addresses: Task-ID: https://www.odoo.com/web?#id=2046885&action=327&model=project.task&view_type=form&menu_id=4720 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39009
Original PR description
Description of the issue/feature this PR addresses: Task-ID: https://www.odoo.com/web?#id=2046885&action=327&model=project.task&view_type=form&menu_id=4720 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39009
In the pivot view of report.pos.order that is a view mainly over pos.order, the "Count" measure is a little rubish giving more or less the number of different products in the grouped order lines. With this changeset, we have the field "Order" as measure that allow us to know the number of orders a grouping is corresponding to. opw-2127275 Forward-Port-Of: odoo/odoo#40723
Original PR description
In the pivot view of report.pos.order that is a view mainly over pos.order, the "Count" measure is a little rubish giving more or less the number of different products in the grouped order lines. With this changeset, we have the field "Order" as measure that allow us to know the number of orders a grouping is corresponding to. opw-2127275 Forward-Port-Of: odoo/odoo#40723
task: https://www.odoo.com/web#view_type=form&model=project.task&id=42243&active_id=42243&menu_id= pad: https://pad.odoo.com/p/r.0cc60a058652f804d7198ca71209f126 Forward-Port-Of: odoo/odoo#40776
Original PR description
task: https://www.odoo.com/web#view_type=form&model=project.task&id=42243&active_id=42243&menu_id= pad: https://pad.odoo.com/p/r.0cc60a058652f804d7198ca71209f126 Forward-Port-Of: odoo/odoo#40776
It was discussed previously from: - https://github.com/odoo/odoo/commit/b79d05fff0cacb4d99ebc1b60f44d8dab757b806 I quote @odony commit message: ``` Having it in INFO should be sufficient for its purpose, and will avoid impacting all CI builds done on a system that does not have the lib installed. For the record, this is not a hard requirement because the lib was not available in Debian stable packages at the time of release. It is only enabled on demand for those who want the fea
Original PR description
It was discussed previously from: - https://github.com/odoo/odoo/commit/b79d05fff0cacb4d99ebc1b60f44d8dab757b806 I quote @odony commit message: ``` Having it in INFO should be sufficient for its purpose, and will avoid impacting all CI builds done on a system that does not have the lib installed. For the record, this is not a hard requirement because the lib was not available in Debian stable packages at the time of release. It is only enabled on demand for those who want the feature and can install it manually. Fixes #22426 Closes #22459 ``` Forward-Port-Of: odoo/odoo#40738
This optimizes the prefetching of the other fields when you don't need the translated field. Forward-Port-Of: odoo/odoo#40706 Forward-Port-Of: odoo/odoo#40651
Original PR description
This optimizes the prefetching of the other fields when you don't need the translated field. Forward-Port-Of: odoo/odoo#40706 Forward-Port-Of: odoo/odoo#40651
The title says it all -_- Forward-Port-Of: odoo/odoo#39779 Forward-Port-Of: odoo/odoo#39699
Original PR description
The title says it all -_- Forward-Port-Of: odoo/odoo#39779 Forward-Port-Of: odoo/odoo#39699
Reproduce the issue - Install Projects - Create a project - Create a task with a deadline The deadline format is correct in the form view but not in the kanban view. Cause In the kanban view, there is some code applied on the `date_deadline` field to add a class when the deadline is near. As it uses a `span` with a `t-esc`, the only way to get the date is to do `record.date_deadline.raw_value` which return the raw value of the datetime
Original PR description
Reproduce the issue
- Install Projects
- Create a project
- Create a task with a deadline
The deadline format is correct in the form view but not in the
kanban view.
Cause
In the kanban view, there is some code applied on the `date_deadline`
field to add a class when the deadline is near.
As it uses a `span` with a `t-esc`, the only way to get the date
is to do `record.date_deadline.raw_value` which return the raw
value of the datetime object (a big string with all the infos).
This commit creates a char field for the formatted date and uses it
only for the display.
OPW-2122928
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#40599Description of the issue/feature this PR addresses: Because of the way odoo has to search with related fields in models without auto join, the performance in the sale order lines is diminishing. As the related and stored field salesman_id exists we can use it to make the search direct. Current behavior before PR: Bad performance Desired behavior after PR is merged: Good performance @Tecnativa TT20614 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.c
Original PR description
Description of the issue/feature this PR addresses: Because of the way odoo has to search with related fields in models without auto join, the performance in the sale order lines is diminishing. As the related and stored field salesman_id exists we can use it to make the search direct. Current behavior before PR: Bad performance Desired behavior after PR is merged: Good performance @Tecnativa TT20614 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40565
…ss computation We are initializing over the limit to make sure we will compute it at least once. If the target goal is set to 0, we are facing a division by zero error when displaying the gamification goal just after initialization. Description of the issue/feature this PR addresses: opw-2127205 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/o
Original PR description
…ss computation We are initializing over the limit to make sure we will compute it at least once. If the target goal is set to 0, we are facing a division by zero error when displaying the gamification goal just after initialization. Description of the issue/feature this PR addresses: opw-2127205 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40703 Forward-Port-Of: odoo/odoo#40666
Bug === In the feed view, if you click on an emoji (which is inside of a comment) there will be a traceback Fix === In the file ``stream_post_comments`` we bind ``click .o_mail_emoji`` to the emoji mixin method. This method will insert the emoji in the text. But, this event is also triggered if the user click on an emoji in read only mode. So, we need to change the target of the event (and to select only emojis which are in the dropdown menu). Task #2121750 Forward-Port-Of: odoo/en
Original PR description
Bug === In the feed view, if you click on an emoji (which is inside of a comment) there will be a traceback Fix === In the file ``stream_post_comments`` we bind ``click .o_mail_emoji`` to the emoji mixin method. This method will insert the emoji in the text. But, this event is also triggered if the user click on an emoji in read only mode. So, we need to change the target of the event (and to select only emojis which are in the dropdown menu). Task #2121750 Forward-Port-Of: odoo/enterprise#6626
When copying previous week, the bounds of the previous week must be computed in UTC. Ex: 18/11/2019 at 00:00:01 in UTC+1 is 17/11/2019 23:00:01 in UTC Let's consider the previous week with the following bounds [B1, B2] All the copied slots must include in the previous week meaning that: - All the start_datetime's slots >= B1 - All the end_datetime's slots <= B2 opw:2091602 Forward-Port-Of: odoo/enterprise#6760
Original PR description
When copying previous week, the bounds of the previous week must be computed in UTC. Ex: 18/11/2019 at 00:00:01 in UTC+1 is 17/11/2019 23:00:01 in UTC Let's consider the previous week with the following bounds [B1, B2] All the copied slots must include in the previous week meaning that: - All the start_datetime's slots >= B1 - All the end_datetime's slots <= B2 opw:2091602 Forward-Port-Of: odoo/enterprise#6760
Task : https://www.odoo.com/web?#id=2095236&action=327&model=project.task&view_type=form&menu_id=4720 Pad : https://pad.odoo.com/p/openerp-project.task-WK8XD1ME4G Forward-Port-Of: odoo/enterprise#6643
Original PR description
Task : https://www.odoo.com/web?#id=2095236&action=327&model=project.task&view_type=form&menu_id=4720 Pad : https://pad.odoo.com/p/openerp-project.task-WK8XD1ME4G Forward-Port-Of: odoo/enterprise#6643
Task: https://www.odoo.com/web#id=2126097&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.63737a7423deddbe92bb6b204c28c505 Forward-Port-Of: odoo/enterprise#6830
Original PR description
Task: https://www.odoo.com/web#id=2126097&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.63737a7423deddbe92bb6b204c28c505 Forward-Port-Of: odoo/enterprise#6830
PR linked to #40599 (community) As I removed the date_format, the FSM app crashed because it's using it. I added a field `planned_date_begin_formatted` and used it only on the project_enterprise module. The FSM app is using the `date_format` to display the date into the following format `HH:mm A` (08:00 PM for instance) Forward-Port-Of: odoo/enterprise#6826
Original PR description
PR linked to #40599 (community) As I removed the date_format, the FSM app crashed because it's using it. I added a field `planned_date_begin_formatted` and used it only on the project_enterprise module. The FSM app is using the `date_format` to display the date into the following format `HH:mm A` (08:00 PM for instance) Forward-Port-Of: odoo/enterprise#6826
Task ID: https://www.odoo.com/web?#id=2083554&action=327&model=project.task&view_type=form&menu_id=4720 PAD: https://pad.odoo.com/p/r.2f687b0da932d17f7091bb3be6ae1625 Forward-Port-Of: odoo/enterprise#6173
Original PR description
Task ID: https://www.odoo.com/web?#id=2083554&action=327&model=project.task&view_type=form&menu_id=4720 PAD: https://pad.odoo.com/p/r.2f687b0da932d17f7091bb3be6ae1625 Forward-Port-Of: odoo/enterprise#6173