Monday, December 2, 2019
35 changes · master
Enhancements to existing features
The accounting account form has been adjusted to make it easier for users to work with account information. This should reduce friction during day-to-day accounting setup and maintenance without changing core accounting behavior.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Users composing an SMS can now send the message to their own phone number. This makes the SMS composer behave as expected when someone intentionally includes themselves as a recipient, while leaving general notification safeguards unchanged.
Original PR description
After this commit: the author of an sms can send it to himself
The live chat demo now includes more realistic sample conversations spread across several months, with different operators and customer ratings. This gives evaluators and demo users a clearer view of how live chat activity and feedback can look in practice.
Mail notifications now use Odoo’s standard action links instead of manually built links. This helps inbox users open related records inside Odoo correctly, rather than having those links treated like external web pages.
Original PR description
Note that this also add data-oe-model and data-oe-id in XML. This allow us to avoid to load these links as external URL when a user receive it in inbox instead of external mail client. See file addons/mail/static/src/js/thread_widget.js -> _onClickRedirect Task ID: 1895451 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This pull request appears to update the Survey area, but no detailed file or commit information was provided. The change likely brings minor improvements or maintenance that support the survey experience without indicating a major business impact.
Resolved issues and error corrections
This fixes an outdated automated tour used in the website eLearning area so it matches the current code. The change helps keep publishing course content reliable by preventing test failures caused by obsolete test steps.
Original PR description
Fine tunning of 07f70e3c1 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Features or functions removed from Odoo
This change removes older dynamic filtering logic in the sale timesheet workflow and replaces it with clearer, more maintainable links between projects, tasks, and sales orders. For users, the invoicing and task selection behavior should remain aligned with the right sales orders while reducing complexity behind the scenes.
Original PR description
* dynamic domain on task was not exactly pulling its weight as it only added a check of the SO lines linked to tasks belonging to the SO the project is linked to (if there's one) which is pretty straightforward to implement with a related field * the dynamic domain on the invoicing wizard is a more complex beast as we want to link to any "to invoice" SO which is linked to the task through one of the project's (other) tasks. Task 2115472
Code cleanup and technical improvements
This change reorganizes purchase order line preparation so it can be reused by approval-related purchasing flows without depending on stock operations. It should not change day-to-day behavior, but it makes the purchasing logic easier to share and maintain across Odoo modules.
Original PR description
**[MOV]** ***: _prepare_purchase_order_line** > Move the method `_prepare_purchase_order_line` from 'stock.rule' to 'purchase.order.line'. > The purpose is to reuse it in approvals_purchase. > >task-2040710
Miscellaneous changes
This fix restores the mobile viewport setting used by Odoo's web client test pages. It helps ensure mobile tests reflect real phone and tablet behavior, reducing the risk of layout issues being missed before release.
Original PR description
After commit odoo/enterprise@8a38a60b1ff03836d0029bfec6c50ca777817146 mobile tests didn't run correctly because of missing viewport META in HEAD. This commit add the missing META. This META must be before all JavaScript file to ensure that JavaScript also know that we work in a viewport. Note that "runbot" run tests in a chromium headless with a size screen reduced and so it worked without this fix. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change reverts a recent logging configuration adjustment that could cause command-line log level settings to override configured log handlers unexpectedly. It helps preserve predictable logging behavior for deployments and troubleshooting.
Original PR description
Configuring the non-root logger based on --log-level had the side-effect (unclear whether it was intended or not as none of the relevant commits really documented the idea) that log-level could…
Configuring the non-root logger based on --log-level had the side-effect (unclear whether it was intended or not as none of the relevant commits really documented the idea) that log-level could override log handlers being set on the root logger e.g. if `log_handler = :INFO` is set in the config file, `--log-level=warn` on the CLI will override it. This could be replicated by swapping `pseudo_config` and `logconfig`, *however* it would also make the sub-loggers override differently (currently on an exact logger match log-handler overrides log-level). The ideal fix would likely be to sequence log-level from the configuration file, log-handler from the configuration file, log-level from the CLI and log-handler from the CLI. However that doesn't really work with the current structure. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a duplicate setup entry in the Accounting module for the same responsible user field. Removing the duplicate reduces confusion and helps keep the system configuration consistent without changing user workflows.
Original PR description
Description of the issue/feature this PR addresses: The field user_id was created twice in the model with the same values and options, only a different help message. This removes the duplicated one. Fixes https://github.com/odoo/odoo/issues/40521 Current behavior before PR: `user_id` is defined twice. The second time (which is the best definition) at https://github.com/odoo/odoo/blob/3e1c5b3f4417d0f3b2d6e1f605f2c66d3ce96869/addons/account/models/account_move.py#L190 Desired behavior after PR is merged: `user_id` is just defined once. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A small typo in the Indian payroll module was corrected so the related form view validates properly. This prevents installation failures for the module and helps ensure payroll setup can proceed as expected.
Original PR description
Task:https://www.odoo.com/web#id=2146360&action=333&active_id=1251&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.a0e94250cd8b3cddc672f54b6c5399e3
The settings screen now provides a clearer explanation for the Firebase URL field in the mobile app configuration. This helps administrators enter the correct information and reduces setup confusion.
Original PR description
Related to https://github.com/odoo/enterprise/pull/6414
This update renames an internal message-posting option so its expected value is clearer to developers. It should not change day-to-day user workflows, but it helps reduce future implementation mistakes across several business apps.
Bug === The file "public_root.js" try to load "/web/webclient/locale/en_US" with ajax.loadJS we do not have the address to the Odoo server, so we try to load the file locally but this file might not exist on the website which is using the widget Fix === Overwrite ``ajax.loadJS`` and ignore ajax loading (also printing a warning message in the JS console) Task #2081146 Forward-Port-Of: odoo/odoo#39757
Original PR description
Bug === The file "public_root.js" try to load "/web/webclient/locale/en_US" with ajax.loadJS we do not have the address to the Odoo server, so we try to load the file locally but this file might not exist on the website which is using the widget Fix === Overwrite ``ajax.loadJS`` and ignore ajax loading (also printing a warning message in the JS console) Task #2081146 Forward-Port-Of: odoo/odoo#39757
We change the locale variable from en_GB to en_US. But we need to re-generate variables. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41131
Original PR description
We change the locale variable from en_GB to en_US. But we need to re-generate variables. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41131
Use case: Plan a production of 10 units on 2 workorders. Produce 4 units of lot1. Record the production and produce the 6 next ones with the same lot1. On the second workorder, the suggested quantity is 4 and not 10. This issue is due to the fact that we fill the next workorder quantity only at the first production batch and we don't check that the same lot can be used again. This commit call the mathod to update the quantity on the next workorder if the first lot is produced again.
Original PR description
Use case: Plan a production of 10 units on 2 workorders. Produce 4 units of lot1. Record the production and produce the 6 next ones with the same lot1. On the second workorder, the suggested quantity is 4 and not 10. This issue is due to the fact that we fill the next workorder quantity only at the first production batch and we don't check that the same lot can be used again. This commit call the mathod to update the quantity on the next workorder if the first lot is produced again. opw: 2127665 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41068
Managers could see only their sessions like other operators. Now they can see all the sessions so they can check and help the operators. task-2048498 Forward-Port-Of: odoo/odoo#39961
Original PR description
Managers could see only their sessions like other operators. Now they can see all the sessions so they can check and help the operators. task-2048498 Forward-Port-Of: odoo/odoo#39961
When printing the 'Picking Operations' report in case of a receipt, lines are duplicated. This is because we need to print the `move_line_nosuggest_ids` as displayed in the view. opw-2125049 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41161
Original PR description
When printing the 'Picking Operations' report in case of a receipt, lines are duplicated. This is because we need to print the `move_line_nosuggest_ids` as displayed in the view. opw-2125049 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41161
Test import with a faulty file (e.g. missing a required column). The error message is only partially translated. German example: "Missing required value for the field 'Code' (code) in Zeile 2" The error message is supposed to be translated (we have _(msg)); however the faulty import killed the first cursor, and we query the translation before the rollback, making that second query fail. Then, we need to have the correct translation for the field name. And then again, in _ we have _ge
Original PR description
Test import with a faulty file (e.g. missing a required column). The error message is only partially translated. German example: "Missing required value for the field 'Code' (code) in Zeile 2" The…
Test import with a faulty file (e.g. missing a required column). The error message is only partially translated. German example: "Missing required value for the field 'Code' (code) in Zeile 2" The error message is supposed to be translated (we have _(msg)); however the faulty import killed the first cursor, and we query the translation before the rollback, making that second query fail. Then, we need to have the correct translation for the field name. And then again, in _ we have _get_cr that would get the closed cursor from the previous with. Yet again, there's an untranslated error message before. Since there's no rollback, we get it before killing the cursor. That might be overdoing things though. opw 2121636 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41098 Forward-Port-Of: odoo/odoo#40645
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40694
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40694
This commit fixes 2 issues, both coming from a misbehavior in `get_nearest_lang()`: 1. Anyone could reach the website in a lang available in backend but not in frontend. Eg, french is activated but not a website lang, going to `/fr` would show the page in french. 2. As a logged in user coming from backend in a lang not available in frontend (has request.lang set to that lang), the website would show a 500 error page since it would not filter out the current request lang. Bo
Original PR description
This commit fixes 2 issues, both coming from a misbehavior in `get_nearest_lang()`: 1. Anyone could reach the website in a lang available in backend but not in frontend. Eg, french is activated but…
This commit fixes 2 issues, both coming from a misbehavior in
`get_nearest_lang()`:
1. Anyone could reach the website in a lang available in backend but not in
frontend. Eg, french is activated but not a website lang, going to `/fr`
would show the page in french.
2. As a logged in user coming from backend in a lang not available in frontend
(has request.lang set to that lang), the website would show a 500 error page
since it would not filter out the current request lang.
Both these issues are fixed here by ensuring langs are filtered out if they do
not belong to the frontend (website langs).
Step to reproduce (bug 1):
- Install french in backend lang (not on website)
- Visit `127.0.0.X/fr_FR`, the frontend will be displayed in french even if
it not a lang available in frontend.
Step to reproduce (bug 2):
- Install french on frontend and remove english from frontend
- Navigate to the backend /web
- Navigate to frontend, it will crash
Fixes #40572 and fixes #40078
Forward-Port-Of: odoo/odoo#40799task: https://www.odoo.com/web#id=40224&action=327&model=project.task&view_type=form&menu_id=4720 pad: https://pad.odoo.com/p/r.ea9fb9164b66e7bd24bb544f0220bfc3 Forward-Port-Of: odoo/odoo#40774
Original PR description
task: https://www.odoo.com/web#id=40224&action=327&model=project.task&view_type=form&menu_id=4720 pad: https://pad.odoo.com/p/r.ea9fb9164b66e7bd24bb544f0220bfc3 Forward-Port-Of: odoo/odoo#40774
- Install project_timesheet_holidays - Create a company with any user (except the SUPERUSER) An AccessError is risen. This is because the new project is created in the new company, but the user is not in this company. The record rule `project_comp_rule` prevents the constraint to be evaluated. `sudo` seems the only solution here... opw-2146153 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --
Original PR description
- Install project_timesheet_holidays - Create a company with any user (except the SUPERUSER) An AccessError is risen. This is because the new project is created in the new company, but the user is not in this company. The record rule `project_comp_rule` prevents the constraint to be evaluated. `sudo` seems the only solution here... opw-2146153 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41124