Tuesday, December 10, 2019
34 changes
Resolved issues and error corrections
This fix keeps the available task choices on helpdesk tickets consistent when logging timesheets, especially when projects, teams, companies, or customers change. It prevents valid project tasks from disappearing and avoids unnecessarily clearing a selected task in some sales-related helpdesk flows.
Original PR description
Existing static domain on task_id would be immediately swapped out for a dynamic (onchange) version thereof. Use conditional trick to merge the entire thing into the static domain, and remove it from the onchange. Task 2115472
Features or functions removed from Odoo
Payroll payslips were simplified by removing outdated dynamic filtering logic and an unused input field. This reduces unnecessary complexity in the payroll interface and helps keep payslip configuration clearer for users.
Original PR description
Task 2115472
Miscellaneous changes
The body of the e-mail was never translated and the sentence was not very nice. This fixes two things: 1. The term is translatable (and added to the `.pot` file) 2. The term has been improved Forward-Port-Of: odoo/enterprise#7181
Original PR description
The body of the e-mail was never translated and the sentence was not very nice. This fixes two things: 1. The term is translatable (and added to the `.pot` file) 2. The term has been improved Forward-Port-Of: odoo/enterprise#7181
Since rev https://github.com/odoo/enterprise/commit/6114fd824320a7e50025e71a2b236bd71ca7fbd9, the image stripe for sidebar icons was changed and few icons were re-arranged in the stripe. The scss was not updated with the changed stripe and so in some cases sidebar displayed wrong icons. This commit makes the required changes in the scss to properly display the icons according to new image stripe. Task : https://www.odoo.com/web#id=2067485&model=project.task&view_type=form&menu_id=5195
Original PR description
Since rev https://github.com/odoo/enterprise/commit/6114fd824320a7e50025e71a2b236bd71ca7fbd9, the image stripe for sidebar icons was changed and few icons were re-arranged in the stripe. The scss was not updated with the changed stripe and so in some cases sidebar displayed wrong icons. This commit makes the required changes in the scss to properly display the icons according to new image stripe. Task : https://www.odoo.com/web#id=2067485&model=project.task&view_type=form&menu_id=5195 Pad : https://pad.odoo.com/p/r.dd8ec245950c2af28ef90d53d17e8026 Forward-Port-Of: odoo/enterprise#5737
At best `('task_id', '=', True)` might be true for task id 1, but otherwise it'd never be true, so the field would never be readonly. I feel the original intent was `('task_id', '!=', False)`: * always allow timesheets on a ticket *not* linked to a task * if a ticket is linked to a task, only allow timesheets if the task is still active & open ping @tivisse @nim-odoo Forward-Port-Of: odoo/enterprise#7165 Forward-Port-Of: odoo/enterprise#7130
Original PR description
At best `('task_id', '=', True)` might be true for task id 1, but otherwise it'd never be true, so the field would never be readonly.
I feel the original intent was `('task_id', '!=', False)`:
* always allow timesheets on a ticket *not* linked to a task
* if a ticket is linked to a task, only allow timesheets if the task is still active & open
ping @tivisse @nim-odoo
Forward-Port-Of: odoo/enterprise#7165
Forward-Port-Of: odoo/enterprise#7130TaskID: 2148606 Forward-Port-Of: odoo/enterprise#7142
Original PR description
TaskID: 2148606 Forward-Port-Of: odoo/enterprise#7142
Fixing the following: - Avoid overlapping of the total amount - If not multiline setting > show '...' in last line - Seq number on same line with date for minipage 2 and 3 Limitation is set to show 1 invoice per line (max 9): if more & multiline setting > add on following page(s) if more & no multiline setting > show 8 & 9th row with '...' if less & multiline / not multiline > no impact. Had to be sure fix is compliant to: https://www.checkdepot.net/checks/laser/Odoo.htm Was n
Original PR description
Fixing the following: - Avoid overlapping of the total amount - If not multiline setting > show '...' in last line - Seq number on same line with date for minipage 2 and 3 Limitation is set to show 1 invoice per line (max 9): if more & multiline setting > add on following page(s) if more & no multiline setting > show 8 & 9th row with '...' if less & multiline / not multiline > no impact. Had to be sure fix is compliant to: https://www.checkdepot.net/checks/laser/Odoo.htm Was nicely tested by customer of ticket & JOV [forwardport up to master] opw-2123856 opw-1941278 of JUC Forward-Port-Of: odoo/enterprise#7090
…m date filter previous behavior: drafted depreciation of posted assets would appear in the assets report even when "posted entries only" was selected when using custom dates current behavior: drafted depreciation of asset only appear if "posted entries only" is unselected even when using custom dates opw-2124831 Forward-Port-Of: odoo/enterprise#6839
Original PR description
…m date filter previous behavior: drafted depreciation of posted assets would appear in the assets report even when "posted entries only" was selected when using custom dates current behavior: drafted depreciation of asset only appear if "posted entries only" is unselected even when using custom dates opw-2124831 Forward-Port-Of: odoo/enterprise#6839
### Issue - Install Accounting - Customers > Follow-up Reports - Select one of them - You can set a summary text or keep the original - Print or Send by email There are too many line breaks ### Cause - PDF: The `\n` in the summary are interpreted by the `white-space: pre-wrap` CSS property - Mail: the `\n` is replaced by a `<br>` - All: when saving the summary, the `\n` are replaced by `<br>\n` ### Solution - PDF: Removing the `white-space: pre-wrap` CSS property
Original PR description
### Issue
- Install Accounting
- Customers > Follow-up Reports
- Select one of them
- You can set a summary text or keep the original
- Print or Send by email
There are too many line breaks
### Cause
- PDF: The `\n` in the summary are interpreted by the `white-space: pre-wrap`
CSS property
- Mail: the `\n` is replaced by a `<br>`
- All: when saving the summary, the `\n` are replaced by `<br>\n`
### Solution
- PDF: Removing the `white-space: pre-wrap` CSS property
- Mail: the `\n` is deleted
- All: when saving the summary, the `\n` are replaced by `<br>`
**OPW-2128174**
Forward-Port-Of: odoo/enterprise#6990