Friday, December 13, 2019
13 changes · master
Resolved issues and error corrections
The obsolete Aged Partner Balance report has been fully removed from Accounting after earlier deprecation work left it partially available. This prevents errors when users try to open or duplicate the old report in Studio, and keeps the report menu from showing an option that no longer works.
Original PR description
Before this commit: when try to open or duplicate Aged Partner Balance report with the studio it gives traceback. As deprecated pdf reports are removed by this commit: https://github.com/odoo/odoo/commit/e51b4f659fc5e4253d3156754ada21166c8d1bf8 'Aged Partner Balance' report is removed from manifest but was not removed report. So, it is giving traceback. After this commit: 'Aged Partner Balance' report is removed, so it will not be shown in the reports. Task: https://www.odoo.com/web?#id=2070274&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.06489d5b18e61ff8b5b2e1b05b2a4148 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures payment edits are reflected when selecting eligible bank partners, reducing the risk of choosing outdated or incorrect payment-related information. It helps accounting teams keep batch and SEPA payment processing aligned with recent payment changes.
Original PR description
Enterprise version of odoo/odoo#40957
Miscellaneous changes
### Description of the issue/feature this PR addresses: It's only for some use cases like paying a hotel or buying food ### Current behavior before PR: 1. Not able to generate a "Factura B" from Responsable Inscripto responsibility type company ### Desired behavior after PR is merged: 1. Able to generate a "Factura B" from Responsable Inscripto responsibility type company -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-
Original PR description
### Description of the issue/feature this PR addresses: It's only for some use cases like paying a hotel or buying food ### Current behavior before PR: 1. Not able to generate a "Factura B" from Responsable Inscripto responsibility type company ### Desired behavior after PR is merged: 1. Able to generate a "Factura B" from Responsable Inscripto responsibility type company -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41861
Previously, the code of the IoT Box was retrieved from the branch that was used during the build but the drivers were retrieved from the connected Odoo DB. Both could be in different versions, which forced used to make old drivers compatible with the new Box or new drivers compatible with old versions of the Box. All of this made it quite hard to modify the existing code, even for new versions of the Box in master. When connecting the IoT Box to an Odoo DB, we now retrieve the version
Original PR description
Previously, the code of the IoT Box was retrieved from the branch that was used during the build but the drivers were retrieved from the connected Odoo DB. Both could be in different versions, which forced used to make old drivers compatible with the new Box or new drivers compatible with old versions of the Box. All of this made it quite hard to modify the existing code, even for new versions of the Box in master. When connecting the IoT Box to an Odoo DB, we now retrieve the version of Odoo that is used and checkout the Box to this branch. This means that we can now modify the code of the Box in master without having to worry about users using the latest build with older DBs. TaskID: 2120749 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40251
Makes it way easier to realise that a cache access blew up because of a @depends_context('active_ids'), which returns a list, which is not hashable. Forward-Port-Of: odoo/odoo#41852 Forward-Port-Of: odoo/odoo#41842
Original PR description
Makes it way easier to realise that a cache access blew up because of
a @depends_context('active_ids'), which returns a list, which is not
hashable.
Forward-Port-Of: odoo/odoo#41852
Forward-Port-Of: odoo/odoo#41842- Set active = false on menu that has a parent - Delete the parent menu. It crashes in the unlink method of ir_ui_menu because it didn't set parent=null on records that are inactive. Because the search method to get children of a menu item only returns node where active=true if `active_test` is not passed in the context to disable this active test filter. Forward-Port-Of: odoo/odoo#41830
Original PR description
- Set active = false on menu that has a parent - Delete the parent menu. It crashes in the unlink method of ir_ui_menu because it didn't set parent=null on records that are inactive. Because the search method to get children of a menu item only returns node where active=true if `active_test` is not passed in the context to disable this active test filter. Forward-Port-Of: odoo/odoo#41830
…dered customers this is a clean version of the fix made in 577dac5baee5e503baba9f30dff67e69daafa00b requested here: https://github.com/odoo/odoo/commit/577dac5baee5e503baba9f30dff67e69daafa00b#r36404308 opw-2148894 Forward-Port-Of: odoo/odoo#41836
Original PR description
…dered customers this is a clean version of the fix made in 577dac5baee5e503baba9f30dff67e69daafa00b requested here: https://github.com/odoo/odoo/commit/577dac5baee5e503baba9f30dff67e69daafa00b#r36404308 opw-2148894 Forward-Port-Of: odoo/odoo#41836
Currently, when uploading a presentation/web page/video/quiz/certification to a slide, when choosing the image/pdf/doc we are uploading, if there is already an image/pdf/doc selected and we cancel the selection, there is a traceback. This commit fixes the traceback. task-id: 2146217 Forward-Port-Of: odoo/odoo#40895
Original PR description
Currently, when uploading a presentation/web page/video/quiz/certification to a slide, when choosing the image/pdf/doc we are uploading, if there is already an image/pdf/doc selected and we cancel the selection, there is a traceback. This commit fixes the traceback. task-id: 2146217 Forward-Port-Of: odoo/odoo#40895
Steps to reproduce: -install point_of_sale -open a session and make a few sales -> closes the session -go to point of sale > reporting > sales detail -select a specific start date and end date => the start and end date are ignored by the report Previous behavior: the start and end date option have no effect on the report Current behavior: the domain is taken into account when generating a report opw-2149216 Forward-Port-Of: odoo/odoo#41773
Original PR description
Steps to reproduce: -install point_of_sale -open a session and make a few sales -> closes the session -go to point of sale > reporting > sales detail -select a specific start date and end date => the start and end date are ignored by the report Previous behavior: the start and end date option have no effect on the report Current behavior: the domain is taken into account when generating a report opw-2149216 Forward-Port-Of: odoo/odoo#41773
Install point_of_sale and a localization (i.e. l10n_be) with a tax configured with 0% and no account. Assign the tax to a product available on POS. Open POS session, sell such product, close session and validate. Error message will popup, blocking the action because the tax used for the product has no associated account for posting the entry. This should not be the case because the tax is 0% so it should not be posted. Skipping taxes based on the amount to avoid the issue. opw-215517
Original PR description
Install point_of_sale and a localization (i.e. l10n_be) with a tax configured with 0% and no account. Assign the tax to a product available on POS. Open POS session, sell such product, close session and validate. Error message will popup, blocking the action because the tax used for the product has no associated account for posting the entry. This should not be the case because the tax is 0% so it should not be posted. Skipping taxes based on the amount to avoid the issue. opw-2155173 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41796
whenever we crop any image we set few data attributes to the cropped image. but if we change a cropped image from media dialog (ImageWidget) we should remove crop related attributes from that newly added image so that newly added image can be cropped with correct data. since https://github.com/odoo/odoo/commit/a473453b3166a381130d9bd6ec4851b9e1ecab26 we are setting 'crop:originalSrc' data to the cropped image but not removing from media dialog. this commit also avoids unnecessary creatio
Original PR description
whenever we crop any image we set few data attributes to the cropped image. but if we change a cropped image from media dialog (ImageWidget) we should remove crop related attributes from that newly added image so that newly added image can be cropped with correct data. since https://github.com/odoo/odoo/commit/a473453b3166a381130d9bd6ec4851b9e1ecab26 we are setting 'crop:originalSrc' data to the cropped image but not removing from media dialog. this commit also avoids unnecessary creation of an attachment. Forward-Port-Of: odoo/odoo#41722 Forward-Port-Of: odoo/odoo#41610
When fetching transactions, we tried to find partner_id based on counterpartName, we can also try finding the partner using account_number. Forward-Port-Of: odoo/enterprise#7248 Forward-Port-Of: odoo/enterprise#7222
Original PR description
When fetching transactions, we tried to find partner_id based on counterpartName, we can also try finding the partner using account_number. Forward-Port-Of: odoo/enterprise#7248 Forward-Port-Of: odoo/enterprise#7222
1. In the next case: 1.1 - Create a new customer invoice 1.2 - Validate the invoice with a CFDI error (Without product for example) 1.3 - Cancel the invoice In this case, the PAC status not must be ``cancelled`` because the PAC wasn't cancel the document, only was a local process, then, the PAC status must be False to avoid show the button "UPDATE SAT STATUS" and call the method in these cases. 2. The method that updates the SAT status in the invoice/payments was improved: -
Original PR description
1. In the next case: 1.1 - Create a new customer invoice 1.2 - Validate the invoice with a CFDI error (Without product for example) 1.3 - Cancel the invoice In this case, the PAC status not must be ``cancelled`` because the PAC wasn't cancel the document, only was a local process, then, the PAC status must be False to avoid show the button "UPDATE SAT STATUS" and call the method in these cases. 2. The method that updates the SAT status in the invoice/payments was improved: - Added a timer to avoid errors when try to update the status and the SAT is down. Note: Many companies have cron to update the PAC status every so often and could generate many invoices each minute. Forward-Port-Of: odoo/enterprise#7080