Tuesday, December 17, 2019
20 changes · master
Enhancements to existing features
This update corrects grammar in the Time Off area, making labels or messages easier for employees and administrators to understand. It is a minor wording improvement with no expected change to business processes or system behavior.
Resolved issues and error corrections
Billing users had lost access to part of the bank reconciliation setup after a recent internal change. This fix restores the needed permissions so they can read and create reconciliation model lines as intended.
Original PR description
The recent refactoring made at 30cf7bc798ddede8e610001146f4a76352aa582f introduces a new object for the different writeoff lines that could be created from a reconciliation model. Unfortunately, Billing users were forgotten during that refactoring which made them unable to read/use the reconciliation models anymore. This patch grants them the Read and Create permission on the new account.reconcile.model.line object, as they already have to the reconciliation model. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
**website_sale_stock** Description of the issue/feature this PR addresses: Controller get_combination_info_website overrides the context information from another module Current behavior before PR: Context information from another module will be forgotten Desired behavior after PR is merged: When there is context information from another module, the dict context will only be updated Fixes #40995 Closes #40995 Modified PR for #41036 -- I confirm I have signed the CLA and rea
Original PR description
**website_sale_stock** Description of the issue/feature this PR addresses: Controller get_combination_info_website overrides the context information from another module Current behavior before PR: Context information from another module will be forgotten Desired behavior after PR is merged: When there is context information from another module, the dict context will only be updated Fixes #40995 Closes #40995 Modified PR for #41036 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41997
Steps to reproduce: -install website, website_partner, contacts and studio -go to contacts and open any partner -click the studio icon (top-right corner of the screen) -add the 'website_description' field to the partner Previous behavior: the description field is not translatable and attempting to change the "translatable" option in technical > fields spawns an error Current behavior: the description field is translatable opw-2155115 Forward-Port-Of: odoo/odoo#41990
Original PR description
Steps to reproduce: -install website, website_partner, contacts and studio -go to contacts and open any partner -click the studio icon (top-right corner of the screen) -add the 'website_description' field to the partner Previous behavior: the description field is not translatable and attempting to change the "translatable" option in technical > fields spawns an error Current behavior: the description field is translatable opw-2155115 Forward-Port-Of: odoo/odoo#41990
Steps to produce: 1. Go to 'Contacts' 2. Select a contact 3. Click on "More" stat button To fix this, we need to force the padding to avoid touch_device rules. Close this pr: https://github.com/odoo/enterprise/pull/7307 Forward-Port-Of: odoo/odoo#42008
Original PR description
Steps to produce: 1. Go to 'Contacts' 2. Select a contact 3. Click on "More" stat button To fix this, we need to force the padding to avoid touch_device rules. Close this pr: https://github.com/odoo/enterprise/pull/7307 Forward-Port-Of: odoo/odoo#42008
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41959
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41959
### Issue - Install website - Add another language - Edit > Click on a menu item > Edit menu - Add mega menu & save - Change language - Click on the translate button - Try to translate a mega menu's item You can't, it always closes. ### Cause This is the default bootstrap behavior. ### Solution Override the default bootstrap behavior. **OPW-2151710** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.co
Original PR description
### Issue
- Install website
- Add another language
- Edit > Click on a menu item > Edit menu
- Add mega menu & save
- Change language
- Click on the translate button
- Try to translate a mega menu's item
You can't, it always closes.
### Cause
This is the default bootstrap behavior.
### Solution
Override the default bootstrap behavior.
**OPW-2151710**
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#41911This avoids KeyError: 'name' raised by the code below ```python if parent_field_type in ['many2one', 'many2many']: fields = {'id': fields['id'], 'name': fields['name']} ``` -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40768
Original PR description
This avoids KeyError: 'name' raised by the code below
```python
if parent_field_type in ['many2one', 'many2many']:
fields = {'id': fields['id'], 'name': fields['name']}
```
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#40768A new currency has been introduced in Mauritania in 2018: https://en.wikipedia.org/wiki/Mauritanian_ouguiya opw-2156411 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41975
Original PR description
A new currency has been introduced in Mauritania in 2018: https://en.wikipedia.org/wiki/Mauritanian_ouguiya opw-2156411 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41975
…dered customers this is a clean version of the fix made in 577dac5baee5e503baba9f30dff67e69daafa00b requested here: https://github.com/odoo/odoo/commit/577dac5baee5e503baba9f30dff67e69daafa00b#r36404308 opw-2148894 Forward-Port-Of: odoo/odoo#41849 Forward-Port-Of: odoo/odoo#41836
Original PR description
…dered customers this is a clean version of the fix made in 577dac5baee5e503baba9f30dff67e69daafa00b requested here: https://github.com/odoo/odoo/commit/577dac5baee5e503baba9f30dff67e69daafa00b#r36404308 opw-2148894 Forward-Port-Of: odoo/odoo#41849 Forward-Port-Of: odoo/odoo#41836
Forward-Port-Of: odoo/odoo#41604
Original PR description
Forward-Port-Of: odoo/odoo#41604
Since commit https://github.com/odoo/odoo/commit/91560fae56f1cba09141eefa1d0da03f4a7b3f72, we are using sudo to write to write calendar_last_notif_ack, but we need to keep the real partner stored in the context. Description of the issue/feature this PR addresses: opw-2133566 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41947
Original PR description
Since commit https://github.com/odoo/odoo/commit/91560fae56f1cba09141eefa1d0da03f4a7b3f72, we are using sudo to write to write calendar_last_notif_ack, but we need to keep the real partner stored in the context. Description of the issue/feature this PR addresses: opw-2133566 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41947
Task #2125856 Forward-Port-Of: odoo/odoo#40433
Original PR description
Task #2125856 Forward-Port-Of: odoo/odoo#40433
There is actually nothing preventing changing the company of some records even there is some journal entries/items that are using them. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41878 Forward-Port-Of: odoo/odoo#41856
Original PR description
There is actually nothing preventing changing the company of some records even there is some journal entries/items that are using them. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41878 Forward-Port-Of: odoo/odoo#41856
Before this fix, when a refresh of the google token was triggered and error 400 where returned, if the user did not have write rights on res_users, an access rights was raised Now, the write is done and the real error is raised for the client. As the token is now properly reset on the partner, he is properly redirected to Google to get a new Authorisation token. OPW-2123045 Forward-Port-Of: odoo/odoo#41651
Original PR description
Before this fix, when a refresh of the google token was triggered and error 400 where returned, if the user did not have write rights on res_users, an access rights was raised Now, the write is done and the real error is raised for the client. As the token is now properly reset on the partner, he is properly redirected to Google to get a new Authorisation token. OPW-2123045 Forward-Port-Of: odoo/odoo#41651
Be in multi-company with companies C1, C2. Let user U1 in company C1 create a vendor bill V. Then U1 change to company C2. Another user U2, in company C1, tries to print the vendor bill. Traceback: Access error trying to access U1 to render the template opw 2145738 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Fo
Original PR description
Be in multi-company with companies C1, C2. Let user U1 in company C1 create a vendor bill V. Then U1 change to company C2. Another user U2, in company C1, tries to print the vendor bill. Traceback: Access error trying to access U1 to render the template opw 2145738 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41644 Forward-Port-Of: odoo/odoo#41542
Issue On the navigateur Edge, if you go to Manufacturing - Planning, when you move the mouse over a stage, you get an error Cause _onMouseMove call elementsFromPoint but on edge it should call msElementsFromPoint Solution Call msElementsFromPoint if elementsFromPoint is not declared. OPW-2156176 Forward-Port-Of: odoo/enterprise#7315
Original PR description
Issue
On the navigateur Edge, if you go to Manufacturing - Planning,
when you move the mouse over a stage, you get an error
Cause
_onMouseMove call elementsFromPoint but on edge it should call
msElementsFromPoint
Solution
Call msElementsFromPoint if elementsFromPoint is not declared.
OPW-2156176
Forward-Port-Of: odoo/enterprise#7315### Issue - Install Timesheet - Timesheet > Settings > Encoding Unit > Day(s) - Click quickly on all the buttons in the grid There are some inconsistencies (negative values, not saved values) ### Cause RPCs concurrency, each RPC call override all the grid values. If you are too fast and your server can't follow, you see wrong values. ### Solution Use mutex & disable the button while the rpc associated is not done. **OPW-2121906** Forward-
Original PR description
### Issue
- Install Timesheet
- Timesheet > Settings > Encoding Unit > Day(s)
- Click quickly on all the buttons in the grid
There are some inconsistencies (negative values, not saved values)
### Cause
RPCs concurrency, each RPC call override all the grid values.
If you are too fast and your server can't follow, you see wrong
values.
### Solution
Use mutex & disable the button while the rpc associated is not done.
**OPW-2121906**
Forward-Port-Of: odoo/enterprise#7290
Forward-Port-Of: odoo/enterprise#7132Forward-Port-Of: odoo/enterprise#7225
Original PR description
Forward-Port-Of: odoo/enterprise#7225
Manually forwardported because nothing beats love-infused artisan handcraft, which is what Odoo is all about. Changes in this version: - account invoice (line) -> account move (line) - specific_product -> specific_products (discount_specific_product_id -> discount_specific_product_ids) - removal of account_invoice_cancel, it's now native (button_draft) - _prepare_invoice_line does not take the qty positional argument anymore - action_create_invoice -> _create_invoices - tax computations
Original PR description
Manually forwardported because nothing beats love-infused artisan handcraft, which is what Odoo is all about. Changes in this version: - account invoice (line) -> account move (line) - specific_product -> specific_products (discount_specific_product_id -> discount_specific_product_ids) - removal of account_invoice_cancel, it's now native (button_draft) - _prepare_invoice_line does not take the qty positional argument anymore - action_create_invoice -> _create_invoices - tax computations needs an almost_equal in test Older changes: - customer field on partner has been removed - tax_ids needs to be explicitly set to false on products - (saas-12.3): addition of website_sale_coupon_delivery (ca7da746d81d6517c4afc3f5f85d66e5fe205d1d), the last commit (fixing the tax computation after delivery recomputation) of the original PR is not needed anymore. Forward-port of: https://github.com/odoo/enterprise/pull/6433/ Forward-Port-Of: odoo/enterprise#7066