Thursday, December 19, 2019
17 changes · master
New functionality added to Odoo
This update adds Polish states to the country and address data. Users can now select the appropriate Polish state when entering or maintaining addresses, improving data accuracy for contacts and businesses in Poland.
Original PR description
Description of the issue/feature this PR addresses: Polish states Current behavior before PR: Polish states are not available Desired behavior after PR is merged: The possibility of choosing Polish states in address -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Enhancements to existing features
The push notification component now stores its Firebase support files in the expected shared library location. This keeps the module’s assets better organized and helps reduce maintenance issues without changing the user experience.
Resolved issues and error corrections
This update fixes several small issues in the website editor's left panel so options refresh correctly and controls display more consistently. It helps users edit pages with fewer confusing or misplaced settings.
The consolidation chart's Groups button now filters results to show only the groups linked to the current chart. This prevents users from seeing unrelated groups and makes consolidation navigation clearer and more accurate.
Original PR description
"Groups" button on consolidation chart view used to display all groups when clicked, instead of only showing the groups linked to the current chart.
Miscellaneous changes
Ensure that expression.OR and expression.AND and some other expression.py methods do not propagate or rely on TRUE_DOMAIN and FALSE_DOMAIN that may be muted on some instance. For example, if we did: self.search(expression.OR([])) then in the search method we do something like: received_domain.append(('res_field', '=', False)) before this commit, FALSE_DOMAIN would be altered for any succeeding code that try to use it in `[(0, '=', 1), ('res_field', '=', 'False')]`. Without the changese
Original PR description
Ensure that expression.OR and expression.AND and some other
expression.py methods do not propagate or rely on TRUE_DOMAIN and
FALSE_DOMAIN that may be muted on some instance.
For example, if we did:
self.search(expression.OR([]))
then in the search method we do something like:
received_domain.append(('res_field', '=', False))
before this commit, FALSE_DOMAIN would be altered for any succeeding code
that try to use it in `[(0, '=', 1), ('res_field', '=', 'False')]`.
Without the changeset, the added test would fail with:
[(1, '=', 1), ('id', '=', 1)] != [(1, '=', 1)]
[(0, '=', 1), ('id', '=', 1)] != [(0, '=', 1)]
[(0, '=', 1), ('id', '=', 1)] != [(0, '=', 1)]
[(1, '=', 1), ('id', '=', 1)] != [(1, '=', 1)]
[(1, '=', 1), ('id', '=', 1)] != [(1, '=', 1)]
note: another commit referenced in #41968 should make the TRUE_DOMAIN
and FALSE_DOMAIN immutable.
related to work on opw-2154448
Forward-Port-Of: odoo/odoo#42216
Forward-Port-Of: odoo/odoo#42107Before this commit, users encountered some difficulties to tap/click on the "optional columns" dropdown in list views. This issue only occured on Chrome: rather annoying to use the mobile app. "width: 10px" was used in inline list view but didn't have any sense in the other case. Worse still, Chrome miscalculated the size of the clickable area by a smaller one. This is due to the fact that we add some padding that exceed 10px. See: odoo/enterprise@2f13205 opw-2071605 Description o
Original PR description
Before this commit, users encountered some difficulties to tap/click on the "optional columns" dropdown in list views. This issue only occured on Chrome: rather annoying to use the mobile app. "width: 10px" was used in inline list view but didn't have any sense in the other case. Worse still, Chrome miscalculated the size of the clickable area by a smaller one. This is due to the fact that we add some padding that exceed 10px. See: odoo/enterprise@2f13205 opw-2071605 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42183
(one step, propagation_cancel = True) Before this - If we have follwing configuration - Manufacturing -> Propagate Cancel -> True Buy -> Propagate Cancel -> True * BOM of a Car - 1) Component 1 -> Iron (MTO & Buy) Now create a SO of product Car and confirm it. It will create a MO (Car) and then PO (Iron). Now if PO is cancelled, it will cancel its move_dest_ids and on change of it MO will be cancelled but delivery move will be remain as it. To cancel this, just called action_
Original PR description
(one step, propagation_cancel = True) Before this - If we have follwing configuration - Manufacturing -> Propagate Cancel -> True Buy -> Propagate Cancel -> True * BOM of a Car - 1) Component 1 -> Iron (MTO & Buy) Now create a SO of product Car and confirm it. It will create a MO (Car) and then PO (Iron). Now if PO is cancelled, it will cancel its move_dest_ids and on change of it MO will be cancelled but delivery move will be remain as it. To cancel this, just called action_cancel() method which already takes care of cancelling moves. Task-2117832 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41824
My individual CLA. I need it for a PR. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41829
Original PR description
My individual CLA. I need it for a PR. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41829
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42141
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42141
Validating a move line will remove the reservation on other move line that will take quantity on the same quant. The querry searching for those move lines needs the state of their relative stock move to be neither 'done' nor 'cancel'. This constraint add a join in the SQL querry that slow largely the request This commit removes the `move` state in the querry and replace it by the the move line state to speed it up. Thanks to 39b65ef and 23e77b8, it's will give the same result as the
Original PR description
Validating a move line will remove the reservation on other move line that will take quantity on the same quant. The querry searching for those move lines needs the state of their relative stock move to be neither 'done' nor 'cancel'. This constraint add a join in the SQL querry that slow largely the request This commit removes the `move` state in the querry and replace it by the the move line state to speed it up. Thanks to 39b65ef and 23e77b8, it's will give the same result as the move line state is related stored of its relative move. Forward-Port-Of: odoo/odoo#42133
Accountant who change the lock date is not always a pos user, and then cannot read pos sessions, which prevent him to change the lock date. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41994
Original PR description
Accountant who change the lock date is not always a pos user, and then cannot read pos sessions, which prevent him to change the lock date. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41994
Commit 2106dd3cd10da44cd0b25897aaa5104f93aea703 changed the model of account.move.reversal but didn't change the demo data of l10n_ar Second commit fixes a missing field in `view_account_journal_form` -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42159
Original PR description
Commit 2106dd3cd10da44cd0b25897aaa5104f93aea703 changed the model of account.move.reversal but didn't change the demo data of l10n_ar Second commit fixes a missing field in `view_account_journal_form` -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42159
Not having a tax group, we can have a side effect. It hasn't failed before because the field is required only on screen, but not on DB. Forward-port of #39780 as the bot seems to not work. @Tecnativa Forward-Port-Of: odoo/odoo#42052 Forward-Port-Of: odoo/odoo#42046
Original PR description
Not having a tax group, we can have a side effect. It hasn't failed before because the field is required only on screen, but not on DB. Forward-port of #39780 as the bot seems to not work. @Tecnativa Forward-Port-Of: odoo/odoo#42052 Forward-Port-Of: odoo/odoo#42046
If an operator executes the /lead commands, the visitor was not linked to the visitor. This commit fixed that. The visitor is now linked to the lead but the visitor does not take the lead's name. (As '/lead something' creates a lead with 'something' as name. 'Something is not the contact name) This PR also includes somes fixes : - Add acls to salesmen to see visitors and page views : The security file was not loaded in the manifest. Also, the tracking model name has changed to website_t
Original PR description
If an operator executes the /lead commands, the visitor was not linked to the visitor. This commit fixed that. The visitor is now linked to the lead but the visitor does not take the lead's name. (As '/lead something' creates a lead with 'something' as name. 'Something is not the contact name) This PR also includes somes fixes : - Add acls to salesmen to see visitors and page views : The security file was not loaded in the manifest. Also, the tracking model name has changed to website_track. - Allow only livechat users to see lead livechat sessions Done in v13 and not in master as this functionality is needed to make crm visitor integration work properly. Task ID: 2081534 Forward-Port-Of: odoo/odoo#38706
Company used to get defaults was user.company_id and not current company in the environment. Fixes #41679 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41791
Original PR description
Company used to get defaults was user.company_id and not current company in the environment. Fixes #41679 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41791
If a visitor has access to a task through access_token, he should have access to the task attachments. He already see the list of attachment and their name, but since the task access_token is not propagated to the attachment he doesn't have the rights to see them. In this PR, we generate the attachments access_token and provide them to the user that is viewing a task with an access_token. opw-2125252 Forward-Port-Of: odoo/odoo#41881
Original PR description
If a visitor has access to a task through access_token, he should have access to the task attachments. He already see the list of attachment and their name, but since the task access_token is not propagated to the attachment he doesn't have the rights to see them. In this PR, we generate the attachments access_token and provide them to the user that is viewing a task with an access_token. opw-2125252 Forward-Port-Of: odoo/odoo#41881
Issue - Download the customer db: stargue-inc - Go on the website in mobile mode Traceback & the second item in the carousel is not displayed. Cause Traceback: we use `this.$iframe` without checking if it's defined Second item not displayed: the first video promise is overriden by the second video promise. Solution Check if this.$iframe is defined and resolve the old promise instead of overriding it. OPW-2152690 -- I confirm I have sig
Original PR description
Issue
- Download the customer db: stargue-inc
- Go on the website in mobile mode
Traceback & the second item in the carousel is not displayed.
Cause
Traceback: we use `this.$iframe` without checking if it's defined
Second item not displayed: the first video promise is overriden
by the second video promise.
Solution
Check if this.$iframe is defined and resolve the old promise
instead of overriding it.
OPW-2152690
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#42098