Monday, January 6, 2020
17 changes · master
Enhancements to existing features
This update removes unused code from the sales and purchasing integration area. It helps keep the system easier to maintain without changing how users work with sales or purchases.
Original PR description
Simply delete unused code
This change adds a simpler built-in way for Odoo records to access their related model information. It reduces repetitive internal code and makes future development easier without changing day-to-day user workflows.
Original PR description
**Description of the issue/feature this PR addresses:** Add a property in the records to get always the `ir.model` record. **Current behavior before PR:** You have a record A. If you want to know the corresponding id of its model in `ir.model`, you always have to do something like: ```python A.env['ir.model']._get(A._name) ``` **Desired behavior after PR is merged:** You simply do `A._model_id`, to get the id of its model in `ir.model`. I think this can simplify a lot of code in many places. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Negative numbers in the web interface are now shortened in the same readable way as positive numbers, such as showing large values with a “k” suffix. This makes financial and numeric screens easier to scan and keeps number formatting consistent for users.
Original PR description
Before this commit, negative numbers are never rendered as human readable (e.g. 34000 -> 34k). TaskID: 2160790 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Helpdesk team chatter now shows the number of attached documents instead of only an attachment icon. This makes it easier for users to understand available documents at a glance and removes a confusing horizontal line display issue when opening attachments.
Original PR description
Task:https://www.odoo.com/web?#id=2149348&action=327&model=project.task&view_type=form&menu_id=4720 Pad:https://pad.odoo.com/p/r.c571cb87014d2b1905019b23189c8abb
Resolved issues and error corrections
Calendar event popovers now correctly display reference field values instead of leaving them blank. This improves accuracy when users open calendar items that include links to other business records.
Original PR description
Before this change, fields.Reference displayed into the popover of a calendar view was always empty. This was because the popover view generated from a double click on an element in the calendar view creates its own recordModel in JS and the function to create this record did not handle the reference field case. This commit detects if a reference field is defined into the record and adds the necessary processing to process its value and creates the corresponding dataPoint. opw 2151635 Co-authored-by: Aaron Bohy <aab@odoo.com> Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Features or functions removed from Odoo
This update removes obsolete work order fields that were no longer used in the manufacturing app. It helps keep the system simpler and easier to maintain without changing day-to-day user workflows.
Original PR description
Remove color and capacity fields of mpr.workorder unused and coming from commit : 2ddc35a5300e89981c0572ae6749aee946f34e9d . Also clean unused import too.
Miscellaneous changes
**[FIX] product_expiry: editable expiration_date** > Before this commit, in the move line view, the field `expiration_date` was readonly even when it must be editable. It was because the condition who defines if the field is readonly or not was wrong. Also, removed the field `expiration_date_readonly` as it mainly referred to picking_type_use_existing_lots`, and use this latter instead. **[FIX] product_expiry: default expiration_date** > Before this commit, the default `expiration_date` w
Original PR description
**[FIX] product_expiry: editable expiration_date** > Before this commit, in the move line view, the field `expiration_date` was readonly even when it must be editable. It was because the condition who defines if the field is readonly or not was wrong. Also, removed the field `expiration_date_readonly` as it mainly referred to picking_type_use_existing_lots`, and use this latter instead. **[FIX] product_expiry: default expiration_date** > Before this commit, the default `expiration_date` wasn't set when the move line was created with the help of multiple assign serial numbers button or when user wrote/copy-pasted a list of SN/LN. task-2166230 Forward-Port-Of: odoo/odoo#42568
Before this commit, a promotion program such as 'Buy 10, get 2 fore free' would have only added a single product in the reward. This commit fixes this problem by ensuring that the quantity for the reward product is computed as the number of times the program is applicable multiplied by the configured reward quantity, instead of just counting the number of times the program is applicable. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Por
Original PR description
Before this commit, a promotion program such as 'Buy 10, get 2 fore free' would have only added a single product in the reward. This commit fixes this problem by ensuring that the quantity for the reward product is computed as the number of times the program is applicable multiplied by the configured reward quantity, instead of just counting the number of times the program is applicable. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40384
See individual commits for details. opw-2122553 Forward-Port-Of: odoo/odoo#42520
Original PR description
See individual commits for details. opw-2122553 Forward-Port-Of: odoo/odoo#42520
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR
Original PR description
Issue
- Have firefox
- Go to any chatter
- Open full editor
- Write some "test" words with line breaks
- Select one of your "test" words
- Drag & drop it somewhere else in the editor
Welcome on test.com! (redirected)
Cause
Summernote doesn't preventDefault on drop event, so firefox
think we want to go to another URL.
Solution
Add the preventDefault manually.
This reveals another issue which is solved by importing
this PR's code https://github.com/summernote/summernote/pull/3327
(with adaptation for our dinosaurus version)
OPW-2158112
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#42719
Forward-Port-Of: odoo/odoo#42470so a credit note is included in GSTR-1 report opw-2161465 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42495 Forward-Port-Of: odoo/odoo#42404
Original PR description
so a credit note is included in GSTR-1 report opw-2161465 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42495 Forward-Port-Of: odoo/odoo#42404
Forward-Port-Of: odoo/odoo#42701
Original PR description
Forward-Port-Of: odoo/odoo#42701
Steps to reproduce the bug: - Select multicompany configuration in General Settings - For two companies (i.e. My company (Chicago) and My company (San Francisco)) select the option Inter-Company Transactions: Synchronize sales/purchase orders - Change the intercompany_user_id ("Assigned to") from Odoobot (default) to Mitchell Admin - Go to My Company (San Francisco) and create a purchase order on the vendor My Company (Chicago) - Confirm the purchase order Bug: A UserError was raise
Original PR description
Steps to reproduce the bug:
- Select multicompany configuration in General Settings
- For two companies (i.e. My company (Chicago) and My company (San Francisco)) select the option Inter-Company Transactions: Synchronize sales/purchase orders
- Change the intercompany_user_id ("Assigned to") from Odoobot (default) to Mitchell Admin
- Go to My Company (San Francisco) and create a purchase order on the vendor My Company (Chicago)
- Confirm the purchase order
Bug:
A UserError was raised due to intercompany access rights
opw:2154172
Forward-Port-Of: odoo/enterprise#7387Fixes #7340 opw-2166819 Forward-Port-Of: odoo/enterprise#7532
Original PR description
Fixes #7340 opw-2166819 Forward-Port-Of: odoo/enterprise#7532
account_invoice_extract should contact autocomplete on /enrich url instead of /check_vat Forward-Port-Of: odoo/enterprise#7305 Forward-Port-Of: odoo/enterprise#7244
Original PR description
account_invoice_extract should contact autocomplete on /enrich url instead of /check_vat Forward-Port-Of: odoo/enterprise#7305 Forward-Port-Of: odoo/enterprise#7244
Steps to reproduce: -install accounting -go to accounting > settings > activate batch payments -go to accounting > customers > batch payments -create a batch payment with no payment and save Previous behavior: you get an Odoo Server Error "Error while validating constraint: tuple index out of range" Current behavior: you get a proper ValidationError with a clear error message opw-2161867 Forward-Port-Of: odoo/enterprise#7442
Original PR description
Steps to reproduce: -install accounting -go to accounting > settings > activate batch payments -go to accounting > customers > batch payments -create a batch payment with no payment and save Previous behavior: you get an Odoo Server Error "Error while validating constraint: tuple index out of range" Current behavior: you get a proper ValidationError with a clear error message opw-2161867 Forward-Port-Of: odoo/enterprise#7442
Issue - Install Accounting - Have an OFX file with special chars - On the dashboard, import bank statement Traceback Cause It seems that OFX parser does'nt support special chars. Solution As the ofxparse library does'nt provide any methods/params to handle special chars, we remove them before parsing the content. OPW-2154598 Forward-Port-Of: odoo/enterprise#7440
Original PR description
Issue
- Install Accounting
- Have an OFX file with special chars
- On the dashboard, import bank statement
Traceback
Cause
It seems that OFX parser does'nt support special chars.
Solution
As the ofxparse library does'nt provide any methods/params to
handle special chars, we remove them before parsing the content.
OPW-2154598
Forward-Port-Of: odoo/enterprise#7440