Wednesday, January 22, 2020
29 changes · master
Enhancements to existing features
The mail-related test suites now run after installation, making checks closer to real development and automated build conditions. This helps catch performance regressions and unexpected database query increases earlier, without changing business functionality.
Original PR description
- take advantage of runbot multi-build capabilities - get similar result when running them locally during dev - better detect when other modules add extra queries Query counts are split in the base value (testing with just test_mail installed) + the extra modules overhead. Part of task-2178641
This update removes outdated internal cleanup notes across several areas and fixes how point of sale order lines receive their sequence when created. Businesses benefit from more consistent point of sale order handling and cleaner maintenance with no major workflow changes expected.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change makes it easier for developers and partners to customize how Point of Sale XML output is prepared without replacing a larger piece of code. It should reduce maintenance effort for custom POS implementations while preserving existing behavior for users.
Original PR description
Before, extending the xml rendering environment was a matter of overriding the whole method. This commit enables a clean extenstion point to alter the rendering dict in the mean time till a thourough…
Before, extending the xml rendering environment was a matter of overriding the whole method. This commit enables a clean extenstion point to alter the rendering dict in the mean time till a thourough refactoring in the near future according to the new js guidlines. **Description of the issue/feature this PR addresses:** - Missing (clean) extension point made alterations to the xml rendering context a real pain **Current behavior before PR:** - Unclean extension forces to rewrite the whole method. - Maintainability of downstream code is suboptimal. **Desired behavior after PR is merged:** - Clean extension is possible - (As if the this js code was already refactored according to the new style) **Note:** Please do not close, even if not immediately accepted (`wishlist` tag). This PR is meant to be carried along and actively maintained, until this semantic will be completed this way or another. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr @xoe-labs
The manufacturing planning screen now shows replenishment limits as inclusive values, using “less than or equal to” instead of “less than.” This makes the minimum and maximum replenishment guidance match the actual business rules and reduces confusion when reviewing supply needs.
Original PR description
Task : https://www.odoo.com/web#id=2169622&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.619f52f92f38f4d3a34af48994f58a66
Notebook tabs in forms now use the full available width on small screens and display cleaner active-tab styling. This gives mobile users a more consistent, polished form navigation experience with less wasted space.
Original PR description
Task : https://www.odoo.com/web#id=2150993&action=333&active_id=1520&model=project.task&view_type=form&menu_id=4720 Pad : https://pad.odoo.com/p/r.bbdc3c63f98c8fbfb8259e97d2cf8850
Resolved issues and error corrections
This fix corrects country links for Polish regional data so records point to the right country. It helps prevent incorrect location data from affecting Polish localization setup and related business documents.
Original PR description
regression introduced from https://github.com/odoo/odoo/commit/1857f738ec366b7d14ccd67679e33d7462ac244a Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
When migrating a database, load_marked_modules will be called multiple times, alternating to upgrade and to install modules. The main reason for this is still a litle confusing but it as the side effect to log "Unmet dependencies" error multiple time in add_modules, even if the dependency will be resolved later. This commit removes the error level for this log, and replace it by another check, performed at the end, logging any module in "to install"/"to upgrade" state. Description of t
Original PR description
When migrating a database, load_marked_modules will be called multiple times, alternating to upgrade and to install modules. The main reason for this is still a litle confusing but it as the side effect to log "Unmet dependencies" error multiple time in add_modules, even if the dependency will be resolved later. This commit removes the error level for this log, and replace it by another check, performed at the end, logging any module in "to install"/"to upgrade" state. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43693
The field service test setup has been adjusted so it works correctly when the core field service app is installed on its own. This prevents test failures caused by relying on sales or accounting-related test setup that may not be present.
Original PR description
When installing only industry_fsm, an error will occur while running tests since TestFsmFlow inherit test class from account creating account.account.tag in setUpClass. This commit fixes class inheritance between industry_fsm and industry_fsm_sale Test classes.
Row header labels in the grid view now display with an ellipsis when they are too long instead of overflowing or appearing poorly clipped. This improves readability in areas such as Timesheets without changing user workflows.
Original PR description
Before this commit, on web_grid view the row header has attribute
text-overflow ellipsis but it dosn't work because the rule display flex
is applied for all descendant. So the text-overflow is not effective.
After this commit, the display rule is applied to the direct child
and not all descendant.
DOM of grid view:
Before
```
...
tbody
tr
th
div display:flex;
div display:flex;text-overflow:ellipsis;
```
After
```
...
tbody
tr
th
div display:flex;
div text-overflow:ellipsis;
```
Ref:
https://www.w3.org/TR/css-overflow-3/#propdef-text-overflow
Step to reproduce:
* open Timesheet app (BUG)Closing the home menu now fully resets any search text entered by the user. This prevents old search terms from reappearing later, making app navigation clearer and less confusing.
Original PR description
Before this commit, the search query of the home menu was not properly cleared when quitting the menu. Now, it is completely reset.
Description of the issue/feature this PR addresses: When a user with stock_user and another admin right who give access to limited sms template (event manager for example) try to validate a picking sending a validation sms, he got a access right error. Current behavior before PR: Access right error. Desired behavior after PR is merged: No error -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43760
Original PR description
Description of the issue/feature this PR addresses: When a user with stock_user and another admin right who give access to limited sms template (event manager for example) try to validate a picking sending a validation sms, he got a access right error. Current behavior before PR: Access right error. Desired behavior after PR is merged: No error -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43760
This commit fixes the visitor's time_statistics computation. When creating a new visitor, last connection datetime is not set, so it's not retrieved in the search_read and crash at search_read_result[visitor.id]. This fix also speeds up and simplifies the time_statistics computation. As time_connection_datetime is always set (for already created visitor) and in the depends, no need to read values before looping, the data is already fetched in memory. We can then use directly the value fo
Original PR description
This commit fixes the visitor's time_statistics computation. When creating a new visitor, last connection datetime is not set, so it's not retrieved in the search_read and crash at search_read_result[visitor.id]. This fix also speeds up and simplifies the time_statistics computation. As time_connection_datetime is always set (for already created visitor) and in the depends, no need to read values before looping, the data is already fetched in memory. We can then use directly the value for each visitor in self. Task ID: 2120464 Original PR #40199 This PR force FW of missing commit in the original FW branch : https://github.com/odoo/odoo/pull/41273 Forward-Port-Of: odoo/odoo#43758
Problem: Unable to install `auth_ldap` if `python-ldap` is installed (while it worked in 12.0) Reason: At 795c7b0a9415d04 the external dependencies was changed from trying to import 'ldap' to checking than 'pyldap' package was installed. The problem is that pyldap is a unmaintained library that should no longer be used, as explained on the package page: https://pypi.org/project/pyldap/ > The pyldap fork was merged back into python-ldap, and released as python-ldap 3.0.0. Risk: - If
Original PR description
Problem: Unable to install `auth_ldap` if `python-ldap` is installed (while it worked in 12.0) Reason: At 795c7b0a9415d04 the external dependencies was changed from trying to import 'ldap' to checking than 'pyldap' package was installed. The problem is that pyldap is a unmaintained library that should no longer be used, as explained on the package page: https://pypi.org/project/pyldap/ > The pyldap fork was merged back into python-ldap, and released as python-ldap 3.0.0. Risk: - If somebody is using pyldap version <= 2.4, this commit will prevent updating the auth_ldap module. - With a bad dep, making a `-u auth_ldap` crashes but using the interface just logs a warning and does nothing - _But_ having pyldap version >= 3.0 installs python-ldap automatically, so will not cause any issue. Forward-Port-Of: odoo/odoo#40249
https://github.com/odoo/enterprise/pull/7407#discussion_r362451701 opw-2128922 Forward-Port-Of: odoo/odoo#43249 Forward-Port-Of: odoo/odoo#42595
Original PR description
https://github.com/odoo/enterprise/pull/7407#discussion_r362451701 opw-2128922 Forward-Port-Of: odoo/odoo#43249 Forward-Port-Of: odoo/odoo#42595
…model account.tax.report.line - translation provided in Dutch task : 2042430 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#35437
Original PR description
…model account.tax.report.line - translation provided in Dutch task : 2042430 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#35437
Task: https://www.odoo.com/web?#id=2155804&action=327&model=project.task&view_type=form&menu_id=4720 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43721
Original PR description
Task: https://www.odoo.com/web?#id=2155804&action=327&model=project.task&view_type=form&menu_id=4720 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43721
Display the `display_name` rathe rthan the `name` in order to include the variant specification. opw-2170400 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43725
Original PR description
Display the `display_name` rathe rthan the `name` in order to include the variant specification. opw-2170400 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43725
Description of the issue/feature this PR addresses: Better search results on contacts Current behavior before PR: If you search on '0492700' the results will only match if the field mobile contains '0492700' while the phone number will find anything that contains '0492700'. The behavior is inconsistent and gives back confusing results. Desired behavior after PR is merged: Mobile phone numbers that contain '0492700' are also found, just like the phone number. -- I confirm I have sig
Original PR description
Description of the issue/feature this PR addresses: Better search results on contacts Current behavior before PR: If you search on '0492700' the results will only match if the field mobile contains '0492700' while the phone number will find anything that contains '0492700'. The behavior is inconsistent and gives back confusing results. Desired behavior after PR is merged: Mobile phone numbers that contain '0492700' are also found, just like the phone number. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43629
same as in https://github.com/odoo/odoo/pull/37769 CC @Tecnativa -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37814
Original PR description
same as in https://github.com/odoo/odoo/pull/37769 CC @Tecnativa -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37814
- Create some stock in WH/Stock for product A - Create some stock in WH/Stock/Shelf 1 for product B - Create a Repair Order for Product A in WH/Stock - Add a line in Parts with B, leave the location to WH/Stock - Process the order until the end Negative quant is created in WH/Stock for B instead of using the quantity in WH/Stock/Shelf 1. We do a best effort in order to reserve the quantity in the sub-locations. opw-2177352 Description of the issue/feature this PR addresses:
Original PR description
- Create some stock in WH/Stock for product A - Create some stock in WH/Stock/Shelf 1 for product B - Create a Repair Order for Product A in WH/Stock - Add a line in Parts with B, leave the location to WH/Stock - Process the order until the end Negative quant is created in WH/Stock for B instead of using the quantity in WH/Stock/Shelf 1. We do a best effort in order to reserve the quantity in the sub-locations. opw-2177352 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43662 Forward-Port-Of: odoo/odoo#43631
Correct the rounding of several currencies which should be 0.001. opw-2172122 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43643
Original PR description
Correct the rounding of several currencies which should be 0.001. opw-2172122 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43643
- Create a FIFO product, Automated - Make some stock - Create a SO, add the product - On the SO, add an analytic account - Validate the picking, create the invoice => the analytic info are propagated to the invoice, as expected - Validate the invoice The analytic info is propagated on the COGS entries, in particular the the output account, which is incorrect. opw-2008567 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after
Original PR description
- Create a FIFO product, Automated - Make some stock - Create a SO, add the product - On the SO, add an analytic account - Validate the picking, create the invoice => the analytic info are propagated to the invoice, as expected - Validate the invoice The analytic info is propagated on the COGS entries, in particular the the output account, which is incorrect. opw-2008567 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43654
The UUID in the payment view now is shown, this to know which is the fiscal folio in the payment, like in the invoices.  Forward-Port-Of: odoo/enterprise#7271
Original PR description
The UUID in the payment view now is shown, this to know which is the fiscal folio in the payment, like in the invoices.  Forward-Port-Of: odoo/enterprise#7271
Steps to reproduce: -install projects -install studio -go to projects > all tasks > activate the gantt view -group the tasks by stages Previous behavior: the stages folds are not ordered by sequence Current behavior: grouped by attributes are now ordered by default opw-2128922 Forward-Port-Of: odoo/enterprise#7697 Forward-Port-Of: odoo/enterprise#7407
Original PR description
Steps to reproduce: -install projects -install studio -go to projects > all tasks > activate the gantt view -group the tasks by stages Previous behavior: the stages folds are not ordered by sequence Current behavior: grouped by attributes are now ordered by default opw-2128922 Forward-Port-Of: odoo/enterprise#7697 Forward-Port-Of: odoo/enterprise#7407
On mobile, in form view with a notebook (in every app) the line just below the tabs is too short and when a tab is selected, the line under this tab doesn't disappear. Also, this line should go from one side to the other. This commit fixes those issues by introducing a wrapper element that handles the scrolling of the tabs. This is required since applying an `overflow` on an element creates a stacking context preventing the children from stacking over their parent (and over its bottom b
Original PR description
On mobile, in form view with a notebook (in every app) the line just below the tabs is too short and when a tab is selected, the line under this tab doesn't disappear. Also, this line should go from one side to the other. This commit fixes those issues by introducing a wrapper element that handles the scrolling of the tabs. This is required since applying an `overflow` on an element creates a stacking context preventing the children from stacking over their parent (and over its bottom border to hide it). This commit is also an opportunity to clean up some redundant styles for those tabs. Task ID: 2150993 Forward-Port-Of: odoo/enterprise#7845
Some changes similar to 672eb8f34dc7c7d67624d820c77e3c3a2e375100 are missing, which prevents to register payments on several invoices in one shot. opw-2179550 Forward-Port-Of: odoo/enterprise#7853
Original PR description
Some changes similar to 672eb8f34dc7c7d67624d820c77e3c3a2e375100 are missing, which prevents to register payments on several invoices in one shot. opw-2179550 Forward-Port-Of: odoo/enterprise#7853
Fixes the strange term 'too further apart', which is not good English. Forward-Port-Of: odoo/enterprise#7582
Original PR description
Fixes the strange term 'too further apart', which is not good English. Forward-Port-Of: odoo/enterprise#7582
Running the cron `HR Contract: update state` crashes when `l10n_be_hr_payroll` is installed. Commit https://github.com/odoo/odoo/commit/f17655dd773096f2d37ece392dfe removed the `pending` state with the `blocked` `kanban_state`. opw-2169776 Forward-Port-Of: odoo/enterprise#7851
Original PR description
Running the cron `HR Contract: update state` crashes when `l10n_be_hr_payroll` is installed. Commit https://github.com/odoo/odoo/commit/f17655dd773096f2d37ece392dfe removed the `pending` state with the `blocked` `kanban_state`. opw-2169776 Forward-Port-Of: odoo/enterprise#7851
For instance, the belgian structured communication never appeared because it was parsed but never set on the bank statement line. Forward-Port-Of: odoo/enterprise#7759
Original PR description
For instance, the belgian structured communication never appeared because it was parsed but never set on the bank statement line. Forward-Port-Of: odoo/enterprise#7759