Odoo Changelog — 2020-01-28

Tuesday, January 28, 2020

36 changes · master

Improvements(5)

Enhancements to existing features

Master hr improve nit

Coremasterhrhr_expensehr_holidays

Updates help text on employee work information fields to better explain who is responsible for coaching, time off approvals, and expense approvals. This helps HR users understand what each responsible person field means and what happens when no approver is set.

Original PR description

Task : https://www.odoo.com/web#id=2168330&action=327&model=project.task&view_type=form&menu_id=4720

Pad: https://pad.odoo.com/p/r.a8dff92edca2e7c537e89e03eb5dce09

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#employee#approvals#help-text

[IMP] sale: set IDs on elements for easier xpaths

PR #44072

Coremastersale

The sales invoice creation wizard now has unique identifiers on key buttons and sections. This makes future customizations safer and easier by avoiding fragile references to duplicate or unnamed screen elements.

Original PR description

Description of the issue/feature this PR addresses: Set unique ID's on button and div elements.

Current behavior before PR:
1. Before this commit there were two buttons on this wizard with the same name 'create_invoices' that do different things. One creates the invoice and the other one creates and opens the invoices.
2. Before the commit there are two divs without an ID. 

Desired behavior after PR is merged:
1. By setting an unique ID on both buttons we can do a clean and easy xpath. Something like `<xpath expr="//button[@id='create_invoice_open']" position="replace"/>` instead of having to use indexes or dangerous behaviours
2. By setting an ID on the divs we can easily xpath by name.


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#sales#invoicing#customization

[IMP] event: improve the kanban view

PR #40428

Coremasterevent

The event kanban card layout was adjusted to make room for additional footer information, such as social media statistics. This keeps event cards visually consistent while enabling clearer reporting in related integrations.

Original PR description

Purpose
=======
In "Event social Facebook", we want to insert some statistics
in the footer of the kanban card.

So, we added a div element, to be able to add the fotter bellow
the card.

Adjust the CSS to keep the same view.

Task #1999230

#kanban#events#social statistics

[IMP] *: user ast.literal_eval when possible

PR #7894

Enterprisemasteraccount_reportsaccount_winbooks_importl10n_es_reportsl10n_in_reportsl10n_mx_reportsmarketing_automationplanningsale_subscriptionsocial_push_notifications

Several business areas now use a simpler and more reliable way to interpret saved filter criteria and domains. This is an internal improvement that should help maintain consistency across reports, imports, subscriptions, planning, marketing automation, and social notifications without changing day-to-day workflows.

Original PR description

To evaluate a domain, it is easier to use ast

Goes with odoo/odoo#43831

#domain evaluation#reports#automation#maintenance

Master hr improve nit

PR #7778

Enterprisemastertimesheet_grid

The help text for the Timesheet responsible field on employee work information was updated to better explain who approves an employee's timesheets. This helps HR and managers understand what happens when no specific approver is assigned.

Original PR description

Task :https://www.odoo.com/web#id=2168330&action=327&model=project.task&view_type=form&menu_id=4720

Pad :https://pad.odoo.com/p/r.a8dff92edca2e7c537e89e03eb5dce09

#timesheets#employees#approvals#help-text

Bug Fixes(3)

Resolved issues and error corrections

[FIX] event: fixed the invoice payment state test in the barcode inte…

PR #43822

Coremasterevent_sale

The event barcode interface now checks invoice payment status using the correct payment field. This prevents registrations from being evaluated against outdated invoice status data after accounting model changes.

Original PR description

…rface

PURPOSE

There has been a few changes in the accounting module since the version 12.4.
The field 'invoice_ids' in the 'sale.order' model is now related to the 'account.move'
model instead of the 'account.invoice' model. The field that contain the payment state
is now called 'invoice_payment_state'. This field changed name again in master into
'payment_state'.

SPECIFICATION

Change the call from 'invoice.state' into 'invoice.payment_state'.

LINKS

Task ID : 2180184


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#event#barcode#invoicing

Refactoring(1)

Code cleanup and technical improvements

Master activity view owl mcm

PR #42278

Coremastermailweb

The activity view has been modernized behind the scenes using Odoo's newer interface framework. This helps keep the mail activity experience maintainable and ready for future improvements, with little expected change for day-to-day users.

Original PR description

This PR migrates the activity view renderer to owl

#activity view#modernization#user interface

Other(27)

Miscellaneous changes

[FW][FIX] stock: recompute move state

PR #44145

Coremasterstock

Before this commit, a move can be 'assigned' even if it has no reserved quantity. How to reproduce: * For a tracked product, add some quantities for a LN/SN. Create an another LN/SN with no quantity; * Create a delivery for this product; * Confirm it and check availability; * On the move line, change the SN/LN for the one without quantity. → The move has no reserved quantity but is still marked as `assigned`. task-2171546 Forward-Port-Of: odoo/odoo#43979

Original PR description

Before this commit, a move can be 'assigned' even if it has no reserved quantity.

How to reproduce:
* For a tracked product, add some quantities for a LN/SN. Create an another LN/SN with no quantity;
* Create a delivery for this product;
* Confirm it and check availability;
* On the move line, change the SN/LN for the one without quantity.
  → The move has no reserved quantity but is still marked as `assigned`.

task-2171546

Forward-Port-Of: odoo/odoo#43979

Task : https://www.odoo.com/web#id=2168330&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.a8dff92edca2e7c537e89e03eb5dce09 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Description of the issue/feature this PR addresses: Set unique ID's on button and div elements. Current behavior before PR: 1. Before this commit there were two buttons on this wizard with the same name 'create_invoices' that do different things. One creates the invoice and the other one creates and opens the invoices. 2. Before the commit there are two divs without an ID. Desired behavior after PR is merged: 1. By setting an unique ID on both buttons we can do a clean and easy xpath. Something like `<xpath expr="//button[@id='create_invoice_open']" position="replace"/>` instead of having to use indexes or dangerous behaviours 2. By setting an ID on the divs we can easily xpath by name. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Purpose ======= In "Event social Facebook", we want to insert some statistics in the footer of the kanban card. So, we added a div element, to be able to add the fotter bellow the card. Adjust the CSS to keep the same view. Task #1999230

…rface PURPOSE There has been a few changes in the accounting module since the version 12.4. The field 'invoice_ids' in the 'sale.order' model is now related to the 'account.move' model instead of the 'account.invoice' model. The field that contain the payment state is now called 'invoice_payment_state'. This field changed name again in master into 'payment_state'. SPECIFICATION Change the call from 'invoice.state' into 'invoice.payment_state'. LINKS Task ID : 2180184 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

PostgresSQL TRIM function does not trim line return and other space characters that are not white space. For references having a non trimmed character regexp_split_to_array would create an array with an empty element. Such element could be matched to a counterpart with no numerics in the reference. TRIM(' \n001') => '\n001' regexp_split_to_array('\n001') => {"", "001"} By replacing the TRIM function by a substring using a regexp we also remove the other space characters such as tab and line return. **Description of the issue/feature this PR addresses:** When clicking on the Reconcile button of a journal if your bank statement lines references have new lines in them or other non whitespace spacing characters (`\n`, `\t`, ...) you will end up with a matching with way to many entries. It will matches with all account.move with `/` in name. **Current behavior before PR:** Reference are split after being wrongly trimmed. Which leads to a list of reference that can contain empty string. **Desired behavior after PR is merged:** References are trimmed and doesn't try to match with other entries on an empty string. ----- How to test it in postgres: Query: ``` SELECT regexp_split_to_array(TRIM(REGEXP_REPLACE(move_ref, '[^0-9|^\s]', '', 'g')), '\s+') AS before_ref_array, regexp_split_to_array(substring(REGEXP_REPLACE(move_ref, '[^0-9|^\s]', '', 'g'), '\S(?:.*\S)*'), '\s+') AS after_ref_array, regexp_split_to_array(TRIM(REGEXP_REPLACE(st_line_name, '[^0-9|^\s]', '', 'g')), '\s+') AS before_move_array, regexp_split_to_array(substring(REGEXP_REPLACE(st_line_name, '[^0-9|^\s]', '', 'g'), '\S(?:.*\S)*'), '\s+') AS after_move_array, regexp_split_to_array(TRIM(REGEXP_REPLACE(move_ref, '[^0-9|^\s]', '', 'g')),'\s+') && regexp_split_to_array(TRIM(REGEXP_REPLACE(st_line_name, '[^0-9|^\s]', '', 'g')), '\s+') AS before_matching_rule, regexp_split_to_array(substring(REGEXP_REPLACE(move_ref, '[^0-9|^\s]', '', 'g'), '\S(?:.*\S)*'), '\s+') && regexp_split_to_array(substring(REGEXP_REPLACE(st_line_name, '[^0-9|^\s]', '', 'g'), '\S(?:.*\S)*'), '\s+') AS after_matching_rule FROM (SELECT '/'::text AS move_ref, 'PAIEMENT PAR CARTE MSFT *<E999999XYZ> 11/11'::text AS st_line_name) AS example; ``` Note: This is one example (used in query upper) that we get in some bank statement lines: ``` PAIEMENT PAR CARTE MSFT *<E999999XYZ> 11/11 ``` Result: ``` before_ref_array | after_ref_array | before_move_array | after_move_array | before_matching_rule | after_matching_rule ------------------+-----------------+-------------------+------------------+----------------------+--------------------- {""} | | {"",999999,1111} | {999999,1111} | t | ``` Note that the substring will also return nothing to split when there is not at least one numeric char in this context. While it returns null instead of False it's equivalent. **Recomended reading about trimming `:space:` class characters in postgreSQL:** https://stackoverflow.com/questions/22699535/trim-trailing-spaces-with-postgresql/22701212#22701212 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43604 Forward-Port-Of: odoo/odoo#43425

Improvements(5)

Master hr improve nit

[IMP] sale: set IDs on elements for easier xpaths

[IMP] event: improve the kanban view

[IMP] *: user ast.literal_eval when possible

Master hr improve nit

Bug Fixes(3)

[FIX] event: fixed the invoice payment state test in the barcode inte…

Refactoring(1)

Master activity view owl mcm

Other(27)

[FW][FIX] stock: recompute move state

Improvements(5)

Master hr improve nit

[IMP] sale: set IDs on elements for easier xpaths

[IMP] event: improve the kanban view

[IMP] *: user ast.literal_eval when possible

Master hr improve nit

Bug Fixes(3)

[FIX] event: fixed the invoice payment state test in the barcode inte…

Refactoring(1)

Master activity view owl mcm

Other(27)

[FW][FIX] stock: recompute move state

[FIX] website: fix first/last process steps lines not showing after edit

[FIX] l10n_uk_reports: invalid fields

[FW][FIX] upgrades path

[FW][FIX] stock_landed_costs: skip cancel move

[FW][FIX] hr_work_entry: Closed contract

[FW][FIX] website_event_track: Adapt broken CSS class for ribbons and tracks filter

[FW][FIX] Commit _merge_quants when running the scheduler

[FW][FIX] account: opening with multiple lines on the same account

[FW][FIX] stock: _search_picking_for_assignation and immediate transfer

[FW][FIX] mrp: allow to use variant in order to build another variant

[FW][FIX] base: Changing company_id of a partner with child_ids

[FW][FIX] sale: allow inheriting and modifying function values

[FW][FIX] pos_restaurant: Fixes

[FW][FIX] website: prevent duplicate of facebook snippet after CTRL+Z

[FW][FIX] core: ignore studio_customization when checking modules states

[FW][FIX] product: Add products without 'combination_indices' to cart.

[FW]Bug fix when there are no items in cart

[FW][FIX] stock: fix typos in UserErrors

[FW]13.0 fix misc 5 las

[FW][FIX] point_of_sale: sale details from frontend.

[FW][FIX] l10n_be: update translations

[FW][FIX] Trim all space chars in reconciliation match

[FW][FIX] sale_subscription: propagate analytic tags

[FW][FIX] hr_work_entry: Fix multi closed contract without end date

[FW][FIX] delivery_fedex: ETD system parameter access rights

[FW][FIX] industry_fsm_sale: wrong data referance of 'service on timeshee…

[FW][FIX] account_reports: Fix unaffected earnings in Trial Balance Report

[FW][FIX] mrp_plm: BoM and Routing changes