Daily updates from Odoo
Friday, January 31, 2020
32 changes · master
Enhancements to existing features
The system-only "Exception" activity type is no longer shown to users when they manually schedule an activity. It remains available behind the scenes so Odoo can still create warning activities automatically when needed.
Original PR description
Task-https://www.odoo.com/web?#id=2168569&action=327&model=project.task&view_type=form&menu_id=4720 Pad-https://pad.odoo.com/p/r.39029a07ff849809d1b84d4c202a9acc Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Event managers can now view and edit an event's description directly from the Events application. This makes it easier to maintain event information in Odoo and prepares the field to be filled from upcoming Facebook synchronization.
Original PR description
Event holds a description field that is not displayed nor editable in frontend. IN this commit we display it in backend form view, allowing to edit it. With the upcoming facebook synchronization it allows to directly populate it with facebook information. See Enterprise PR odoo/enterprise#8058 . Task ID 1999230 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
The document indexing feature no longer depends on a PDF processing library that is unavailable on some supported Ubuntu systems. If the library is missing, the system logs a warning and continues indexing other document types, reducing installation and maintenance issues.
Original PR description
As pdfminer does not have a Debian package in Ubuntu Bionic, it cannot be declared as a strong requirement. With this commit, a warning is logged if the library is not installed. It does not prevent to index other types of documents.
This fixes an issue that could prevent survey date or time selection limits from working correctly. Survey participants should now have a smoother experience when answering questions that use date or time inputs.
Original PR description
Fixing 59a50e7628e3, were minDate & maxDate are declared before usage. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects a typo that prevented the event registration close action from being properly referenced. It helps ensure event organizers can close registrations as expected, avoiding confusion or manual workarounds.
Original PR description
Bug === Typo error in the name of the action. Introduced in e2f16573d257257198b1fabb9fe5f619614fb1cf Task 2186587
This fix ensures the media icon is shown on social posts even before they are sent. Users can now clearly see when a draft or scheduled live post includes media, reducing confusion during publishing preparation.
Original PR description
Bug === No icon displayed if the post is not yet sent.
The Field Service worksheet screen no longer shows the “Design Worksheet Template” button on mobile devices. This avoids showing an action that is not practical on smaller screens, making the mobile experience cleaner and easier to use.
Original PR description
Task : https://www.odoo.com/web?#id=2152318&action=327&model=project.task&view_type=form&menu_id=4720 Pad : https://pad.odoo.com/p/r.66310d7ccc0377249827064ccf6f0ae3
The asset report no longer relies on account groups to build a hierarchy, because that structure is not appropriate for assets. This prevents misleading or incorrect asset report organization and keeps the report aligned with how assets are managed.
Original PR description
Since 1789db58dc3fef6358bf2465cfd9ca120bbd6120 we need to have account groups in order to have a hierarchy, but it doesn't make sense for assets.
This update fixes a problem that could occur when uninstalling the Sale Timesheet Enterprise app. It ensures related setup data is handled before the underlying components are removed, helping avoid uninstall errors for administrators.
Original PR description
Purpose ======= It's better to manipulate the models before they disappear. TaskID: 2185403
Miscellaneous changes
### Issue - Studio - Add an required html field - Create new record - Leave it empty It is saved ### Cause The isSet function of FieldHtml widget, have a "/" in the <br> tag and summernote empty = <p><br></p>. If you add a space, the value becomes <p> <p>. ### Solution Remove the "/" and the spaces, check if value != <p></p> && <p><br></p> **OPW-2183687** -- I confirm I have signed the CLA and read the PR guidel
Original PR description
### Issue
- Studio
- Add an required html field
- Create new record
- Leave it empty
It is saved
### Cause
The isSet function of FieldHtml widget, have a "/" in the <br> tag
and summernote empty = <p><br></p>. If you add a space, the value
becomes <p> <p>.
### Solution
Remove the "/" and the spaces, check if value != <p></p> &&
<p><br></p>
**OPW-2183687**
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#44250Description of the issue/feature this PR addresses: When using documents, on vendor bills the document_number is set manually by the number given from the vendor, the odoo sequence is not used. In this case We allow to delete vendor bills with document_number/move_name Current behavior before PR: If you create a vendor bill using with documents (l10n_latam_invoice_document), you can not deleted (no matter you've never poste it) Desired behavior after PR is merged: Be able to delete it
Original PR description
Description of the issue/feature this PR addresses: When using documents, on vendor bills the document_number is set manually by the number given from the vendor, the odoo sequence is not used. In this case We allow to delete vendor bills with document_number/move_name Current behavior before PR: If you create a vendor bill using with documents (l10n_latam_invoice_document), you can not deleted (no matter you've never poste it) Desired behavior after PR is merged: Be able to delete it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43312
### Issue - Install eCommerce - Add Stripe - Pay with invalid cart Traceback ### Cause When I improved stripe error, I didn't checked if an error could have no event ### Solution Check if the error has an event **OPW-2186385** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44398
Original PR description
### Issue
- Install eCommerce
- Add Stripe
- Pay with invalid cart
Traceback
### Cause
When I improved stripe error, I didn't checked if
an error could have no event
### Solution
Check if the error has an event
**OPW-2186385**
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#44398- Activate automatic invoicing after successful payment - Go to the eCommerce with the public user - Purchase an item An error occurs because a `list` has no attribute `id`. The root cause is the following line: https://github.com/odoo/odoo/commit/3abe78087a0426ad2783942baa01e1d5fbdff2d9#diff-39d0613187d36f16c541734e80925e9dR556 We should allow any user having the right to create an invoice to actually create an invoice. Co-authored-by: Nicolas Martinelli <nim@odoo.com> opw-
Original PR description
- Activate automatic invoicing after successful payment - Go to the eCommerce with the public user - Purchase an item An error occurs because a `list` has no attribute `id`. The root cause is the following line: https://github.com/odoo/odoo/commit/3abe78087a0426ad2783942baa01e1d5fbdff2d9#diff-39d0613187d36f16c541734e80925e9dR556 We should allow any user having the right to create an invoice to actually create an invoice. Co-authored-by: Nicolas Martinelli <nim@odoo.com> opw-2185680 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44364
Description of the issue/feature this PR addresses: <b> Task:</b> https://www.odoo.com/web?#id=2090409&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720 <b> Pad:</b> https://pad.odoo.com/p/r.f32d03b5bb2c8fa79701a57f5dd437db Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39169
Original PR description
Description of the issue/feature this PR addresses: <b> Task:</b> https://www.odoo.com/web?#id=2090409&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720 <b> Pad:</b> https://pad.odoo.com/p/r.f32d03b5bb2c8fa79701a57f5dd437db Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39169
[Task ID - 2180226](https://www.odoo.com/web?#id=2180226&action=333&active_id=1725&model=project.task&view_type=form&menu_id=4720) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43839
Original PR description
[Task ID - 2180226](https://www.odoo.com/web?#id=2180226&action=333&active_id=1725&model=project.task&view_type=form&menu_id=4720) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43839
Fix the access error you could get when filtering on ratings when not logged in or when the user had not the rights. (e.g : filtering the channel review messages) Task ID : 2167776 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42847
Original PR description
Fix the access error you could get when filtering on ratings when not logged in or when the user had not the rights. (e.g : filtering the channel review messages) Task ID : 2167776 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42847
Description of the issue/feature this PR addresses: <b>Task:</b>https://www.odoo.com/web?#id=2146510&action=327&model=project.task&view_type=form&menu_id=4720 <b>Pad:</b>https://pad.odoo.com/p/r.b29acc41ee064079a2b416271cac884e Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42279
Original PR description
Description of the issue/feature this PR addresses: <b>Task:</b>https://www.odoo.com/web?#id=2146510&action=327&model=project.task&view_type=form&menu_id=4720 <b>Pad:</b>https://pad.odoo.com/p/r.b29acc41ee064079a2b416271cac884e Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42279
As the keywords are added in the DOM and its' table is also toggled at the same time, we've to put the toggling of the table after the keywords pushed in to the DOM. And on a product template: the field "Accessory Products" help message says "Accessories show up when the customerreviews the cart before payment (cross-sell strategy)." Added missing space between customer and reviews. Task Link - https://www.odoo.com/web#id=2063206&action=327&model=project.task&view_type=form&menu_id=472
Original PR description
As the keywords are added in the DOM and its' table is also toggled at the same time, we've to put the toggling of the table after the keywords pushed in to the DOM. And on a product template: the field "Accessory Products" help message says "Accessories show up when the customerreviews the cart before payment (cross-sell strategy)." Added missing space between customer and reviews. Task Link - https://www.odoo.com/web#id=2063206&action=327&model=project.task&view_type=form&menu_id=4720 Pad Link - https://pad.odoo.com/p/r.a5d1e2443ce76780880c8bb27d472cc6 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38931
Open POS, make an order, on the payment screen select email, select a customer, pay and validate. The receipt will be not an attachment, but a code image. The side effect is the visualization dependant on the viewer (email client, webmail, etc.) opw-2179303 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44336 Forward-Port-Of: odoo/odoo#44316
Original PR description
Open POS, make an order, on the payment screen select email, select a customer, pay and validate. The receipt will be not an attachment, but a code image. The side effect is the visualization dependant on the viewer (email client, webmail, etc.) opw-2179303 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44336 Forward-Port-Of: odoo/odoo#44316
Fill bank account information for the current company Create an Invoice by hand, under "Other info" tab the Bank Account section is filled. Now create a Sale order, confirm it and create the invoice. The invoice created from the sale order is missing the Bank Account section, this in turn disable the QR code generation. Adding th erequired information when creating the invoice from the sale order fix the issue opw-2181580 -- I confirm I have signed the CLA and read the PR guideli
Original PR description
Fill bank account information for the current company Create an Invoice by hand, under "Other info" tab the Bank Account section is filled. Now create a Sale order, confirm it and create the invoice. The invoice created from the sale order is missing the Bank Account section, this in turn disable the QR code generation. Adding th erequired information when creating the invoice from the sale order fix the issue opw-2181580 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44323 Forward-Port-Of: odoo/odoo#44245
In case of font-awesome icon when the browser is being zoomed, we can get a decimal font-size. There is a system that transform font-awesome in image links so they are readable in any email client (supporting image) but it did not take into account decimal font-size. With this changeset, we only send a integer font size: we do not try to get the original value because styling is relative on elements, a 90% zoom ratio could lead to a 98% font-awesome icon ratio. Also improve edition of font-aw
Original PR description
In case of font-awesome icon when the browser is being zoomed, we can get a decimal font-size. There is a system that transform font-awesome in image links so they are readable in any email client (supporting image) but it did not take into account decimal font-size. With this changeset, we only send a integer font size: we do not try to get the original value because styling is relative on elements, a 90% zoom ratio could lead to a 98% font-awesome icon ratio. Also improve edition of font-awesome icon edition after first save by reverting the transformation to image on edit. Thanks to that, the original size will also be reinstated and will not depend on zoom on previous save. opw-2156069 Forward-Port-Of: odoo/odoo#43949
Task : https://www.odoo.com/web#id=2180132&action=333&active_id=965&model=project.task&view_type=form&menu_id=4720 Pad : https://pad.odoo.com/p/r.0cd9ee143d0c6918cb71f05d8cf68510 Forward-Port-Of: odoo/odoo#44080
Original PR description
Task : https://www.odoo.com/web#id=2180132&action=333&active_id=965&model=project.task&view_type=form&menu_id=4720 Pad : https://pad.odoo.com/p/r.0cd9ee143d0c6918cb71f05d8cf68510 Forward-Port-Of: odoo/odoo#44080
There is nothing left preventing to delete an account.move.line making the related account.move unbalanced. --issue: 2185112 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44171
Original PR description
There is nothing left preventing to delete an account.move.line making the related account.move unbalanced. --issue: 2185112 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44171
`action_invoice_paid` should be called when the computed field `invoice_payment_state` is set. However, the recomputation doesn't go through `create` or `write` (since the field is protected). A workaround is to call it at reconciliation. Indeed, an invoice can only be paid when it is reconciled. For invoices with an amount of zero, we call the method at posting. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged:
Original PR description
`action_invoice_paid` should be called when the computed field `invoice_payment_state` is set. However, the recomputation doesn't go through `create` or `write` (since the field is protected). A workaround is to call it at reconciliation. Indeed, an invoice can only be paid when it is reconciled. For invoices with an amount of zero, we call the method at posting. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44259
Under Projects, click on Overview, click on the smart button "Vendor Bills". The list will display account moves based only on the analytic account and not the actual type of the move opw-2180598 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44302
Original PR description
Under Projects, click on Overview, click on the smart button "Vendor Bills". The list will display account moves based only on the analytic account and not the actual type of the move opw-2180598 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44302
Was still using the old "selection:" form instead of ir.model.field.selection Forward-Port-Of: odoo/odoo#44277 Forward-Port-Of: odoo/odoo#44221
Original PR description
Was still using the old "selection:" form instead of ir.model.field.selection Forward-Port-Of: odoo/odoo#44277 Forward-Port-Of: odoo/odoo#44221
After getting some experience with them, they turn out to be inconvenient and not very useful, as most of their outcome is to make it harder to find the actual error message. Forward-Port-Of: odoo/odoo#44311
Original PR description
After getting some experience with them, they turn out to be inconvenient and not very useful, as most of their outcome is to make it harder to find the actual error message. Forward-Port-Of: odoo/odoo#44311
Task: https://www.odoo.com/web#id=2152432&action=327&model=project.task&view_type=form&menu_id=4720 Forward-Port-Of: odoo/enterprise#8040
Original PR description
Task: https://www.odoo.com/web#id=2152432&action=327&model=project.task&view_type=form&menu_id=4720 Forward-Port-Of: odoo/enterprise#8040
task: 1952265 Forward-Port-Of: odoo/enterprise#8029
Original PR description
task: 1952265 Forward-Port-Of: odoo/enterprise#8029
There are existing fields designed to contain this information in both account.payment and hr.employee models. Not using them means, for example, that a partner with bank accounts A and B could have a payment made to his account B that will actually be encoded in the file as targeting account A. Forward-Port-Of: odoo/enterprise#8054 Forward-Port-Of: odoo/enterprise#8049
Original PR description
There are existing fields designed to contain this information in both account.payment and hr.employee models. Not using them means, for example, that a partner with bank accounts A and B could have a payment made to his account B that will actually be encoded in the file as targeting account A. Forward-Port-Of: odoo/enterprise#8054 Forward-Port-Of: odoo/enterprise#8049
Country code of the user installing voip module can be empty, leading to an AttributeError. We should not prevent installation of the App. opw-2186350 Forward-Port-Of: odoo/enterprise#8022
Original PR description
Country code of the user installing voip module can be empty, leading to an AttributeError. We should not prevent installation of the App. opw-2186350 Forward-Port-Of: odoo/enterprise#8022
Was still using the old "selection:" form instead of ir.model.field.selection Forward-Port-Of: odoo/enterprise#8030 Forward-Port-Of: odoo/enterprise#8014
Original PR description
Was still using the old "selection:" form instead of ir.model.field.selection Forward-Port-Of: odoo/enterprise#8030 Forward-Port-Of: odoo/enterprise#8014