Tuesday, February 4, 2020
6 changes · master
Resolved issues and error corrections
This update cleans up outdated internal code patterns that were causing deprecation warnings during development and testing. It helps keep Odoo easier to maintain and better prepared for future dependency and platform updates, with little expected impact on day-to-day users.
Original PR description
@Julien00859 already made a pass on this at some point but there's a bunch of warnings either dynamic or from not the stdlib left over. Some of them can't really be fixed in-code and have been explicitly ignored instead: * `setuptools` uses the deprecated `imp` module until v41.6.0 * `zeep` uses defusedxml.lxml which was never intended to be a public / production API, not sure what to do there (cf mvantellingen/python-zeep#956) * there are a ton of invalid escapes in non-raw string literals, they're unlikely to ever be relevant so ignore them
Invoices that are marked as in payment will now show the outstanding credit widget. This helps accounting users apply available credits at the right stage, reducing confusion and avoiding missed credit allocations.
Original PR description
… in_payment -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes a duplicate test module name in the stock app that could prevent one set of tests from running. It helps keep automated checks reliable, reducing the risk of unnoticed issues reaching users.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
System notifications now show sender names with normal punctuation instead of visible web-safe codes. This makes message alerts easier to read, for example showing Bob's friend rather than Bob's friend, while preserving existing security handling for web content.
Original PR description
The title of notification is the author name escaped (for security reasons). https://github.com/odoo/odoo/blob/e3fa264d1053e0f0a5181da56f205cc05cc06316/addons/mail/static/src/js/services/mail_manager.js#L987-L989 When forwarded to the system notification, it does not need to be escaped though, as the system notification is not HTML based. Without this patch, a user named `Bob's friend` sending a message was creating a notification with the title `Bob's friend` Fixes odoo/odoo#24846 PS: PR targeting master as low issue and not worth to potentially break user's notifications for a corner case.
This change removes deprecated internal calls and updates an outdated test method so the affected apps remain compatible with newer supporting libraries. It helps reduce future maintenance risk without changing day-to-day user workflows.
Original PR description
cf odoo/odoo#44164
The reconciliation screen now properly exits amount editing when users click away or press Enter, even if they did not change the value. This prevents the editing field from getting stuck and makes bank reconciliation smoother for accounting users.
Original PR description
…on widget Commit: https://github.com/odoo/enterprise/commit/a1f6cf1367d254a6515546599ac624a823916890 changed the event on input from keyup,blur to change which was wrong. Change event only trigger when an input value has changed, or in our case when we edit the amount of a line, we want the input to disappear when we click elsewhere or when we press enter and no change were made to the value. This commit fixes this by reintroducing the keyup and blur event.