Wednesday, February 5, 2020
7 changes · master
Resolved issues and error corrections
Fixes a rare timing issue in Odoo Discuss where switching conversations immediately after marking Inbox messages as read could show the wrong, empty message list. This helps users reliably see the selected conversation and reduces intermittent failures in automated checks.
Original PR description
Follow up on 4f5334a081ee0e551fc2848aa230dabc96984862 Before this commit, thread was not re-rendered correctly in Discuss App when user clicked on "Mark as Read" from Inbox and then changed…
Follow up on 4f5334a081ee0e551fc2848aa230dabc96984862 Before this commit, thread was not re-rendered correctly in Discuss App when user clicked on "Mark as Read" from Inbox and then changed conversation in a narrow time frame. This issue was discovered from a test that failed undeterministically on rare occasions (once every hundreds of builds on Runbot): ``` QUnit test failed: "mail > Discuss > all messages in "Inbox" in "History" after marked all as read" [message: "there should be 30 messages in History", actual: "0", expected: "30"] ``` This test crashed due to the rendering of Inbox after message fadeout animation that overwrote the rendering of History. As a result, thread widget indefinitely displays Inbox content, which is empty. The HTML content of Discuss during the crash shows that breadcrumb and discuss sidebar correctly have "History" as the active thread, but thread widget still shows "Inbox" as content: http://runbot.odoo.com/runbot/build/1092504 This commit fixes the issue by re-rendering of the thread with message fadeout animation only if the active thread has not changed.
This update fixes wording mistakes where purchase order screens incorrectly referenced sales orders. It improves clarity for users working with the purchase product matrix without changing business processes.
Original PR description
Some typos. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The website editor now properly recognizes negative numbers in its left-side settings panel. This prevents valid negative values from appearing as blank fields, reducing confusion when editing layouts or styles.
Original PR description
A negative value, even if legit, was not understood by the editor and induced empty inputs in the left panel.
This fixes the user interface for advanced pricelist rules in the Product area. It helps users manage pricing rules more clearly and reduces confusion when configuring product prices.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The timesheet grid now returns an empty list when there are no columns to add, instead of returning nothing. This prevents a crash in the timesheet interface and keeps the user experience stable in edge cases.
Original PR description
The method `_searchColToAddButton` currently returns an Array or `null` if the array is empty. It should always consitently return an array. Currently, the code calling the method crashes if it gets back `null`. It's expecting an array and iterates over it. `null` is not iterable.
This update corrects a sales subscription dashboard view so users see the intended reporting layout. It also removes an unused purchase report view customization that had no business impact, reducing maintenance noise.
This update adds an extra wait step after selecting documents in automated tests. It helps prevent occasional false test failures, supporting more stable releases without changing user-facing behavior.
Original PR description
After the fix of #7911, some tests could still fail, this commits makes sure that we wait after each document selection.