Monday, February 10, 2020
31 changes · master
Enhancements to existing features
This update corrects an internal file reference in Odoo's base language component. It helps ensure the system points to the intended file, reducing the chance of incorrect behavior in related language functionality.
Original PR description
Follow-up on https://github.com/odoo/odoo/commit/22f02af6bf002324ebafc38d4eefeda60063247a Use the correct reference for the file. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The web test suite has been updated to use browser-native event handling, making automated tests closer to real user behavior. This helps improve confidence in the reliability of web and Studio features without changing day-to-day functionality for users.
Resolved issues and error corrections
The blog next-post navigation no longer shows an incorrectly placed loading spinner. It also better handles half-screen cover images, making the transition between blog posts feel smoother and more polished for visitors.
Original PR description
Previously, when clicking on the next post at the bottom of a blog post, a spinning loader circle would always appear in the bottom left of the screen in an incorrect position. This commit removes that spinner. This commit also adds support for the half-screen cover size, which until now would animate as though it was full screen. All in all this just makes the transition animation much more seamless, which was the point of having it in the first place. task-2166790
Code cleanup and technical improvements
This update removes an old internal setting that is no longer used in the mailing and project areas. It helps keep the system easier to maintain without changing how users work with these apps.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: `_period_number` is not used since v9 Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Without these magic filters the various options in the activity widget (late, today, future) will show all activities instead. opw-2172833 Forward-Port-Of: odoo/odoo#44917 Forward-Port-Of: odoo/odoo#44535
Original PR description
Without these magic filters the various options in the activity widget (late, today, future) will show all activities instead. opw-2172833 Forward-Port-Of: odoo/odoo#44917 Forward-Port-Of: odoo/odoo#44535
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45000
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45000
### Description of the issue/feature this PR addresses: The read access verification is not performed on the field that is meant to be read. ### Current behavior before PR: Read access check is made on `__last_update` field. ### Desired behavior after PR is merged: Read access check is made on the `field` keyword argument. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43826
Original PR description
### Description of the issue/feature this PR addresses: The read access verification is not performed on the field that is meant to be read. ### Current behavior before PR: Read access check is made on `__last_update` field. ### Desired behavior after PR is merged: Read access check is made on the `field` keyword argument. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43826
Forward-Port-Of: odoo/odoo#44969 Forward-Port-Of: odoo/odoo#44626
Original PR description
Forward-Port-Of: odoo/odoo#44969 Forward-Port-Of: odoo/odoo#44626
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44957 Forward-Port-Of: odoo/odoo#44665
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44957 Forward-Port-Of: odoo/odoo#44665
When snippets deeply alter the DOM (e.g. image reordering in gallery), the related option might be destroyed since they are referencing old DOM. If such a case occurred, the destroyed option was still waiting for an option update response by the editor before being considered as finished... which then never occurred and blocked the editor. Forward-Port-Of: odoo/odoo#44796
Original PR description
When snippets deeply alter the DOM (e.g. image reordering in gallery), the related option might be destroyed since they are referencing old DOM. If such a case occurred, the destroyed option was still waiting for an option update response by the editor before being considered as finished... which then never occurred and blocked the editor. Forward-Port-Of: odoo/odoo#44796
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44941
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44941
### Issue - Install Blog - Go on a Blog post - Customize > Enable Share links & Sidebar - Click on a social share link Redirected to # ### Cause The website_blog.js has been refactored from v12 to v13, it seems that the onShareLink method has been forgotten in the event handlers. ### Solution I added it and make it working with the actual view. **OPW-2170706** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-P
Original PR description
### Issue - Install Blog - Go on a Blog post - Customize > Enable Share links & Sidebar - Click on a social share link Redirected to # ### Cause The website_blog.js has been refactored from v12 to v13, it seems that the onShareLink method has been forgotten in the event handlers. ### Solution I added it and make it working with the actual view. **OPW-2170706** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44583
When the apply-to data attribute was first introduced, a mistake was made when storing the results of the methods calls, using _.each instead of _.map to associate each target element with the promise of the method execution, as a result, Promise.all would resolve immediately instead of waiting. While there are no currently documented bug caused by this, they are just waiting to happen. This commit fixes that. Forward-Port-Of: odoo/odoo#44959
Original PR description
When the apply-to data attribute was first introduced, a mistake was made when storing the results of the methods calls, using _.each instead of _.map to associate each target element with the promise of the method execution, as a result, Promise.all would resolve immediately instead of waiting. While there are no currently documented bug caused by this, they are just waiting to happen. This commit fixes that. Forward-Port-Of: odoo/odoo#44959
Selecting a css color equals to a theme color via the custom color was not selecting the theme color. Opening and closing the custom color without picking a color was unselecting the selected color. Now the custom color picker has the selected color as default even if it does not appear in the palette as selected. This bug was apearing in the paralax snippet as no custom color is displayed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr For
Original PR description
Selecting a css color equals to a theme color via the custom color was not selecting the theme color. Opening and closing the custom color without picking a color was unselecting the selected color. Now the custom color picker has the selected color as default even if it does not appear in the palette as selected. This bug was apearing in the paralax snippet as no custom color is displayed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43844
Since we use Promise instead of jQuery deferred, the onRemove method class was no longer triggered before the actual removal of the elements. Original fix with https://github.com/odoo/odoo/pull/43918 This PR is the same with the async/await form, not breaking the history of half of the removeSnippet method's lines. Co-authored-by: fja-odoo <fja@odoo.com> Forward-Port-Of: odoo/odoo#44905 Forward-Port-Of: odoo/odoo#44900
Original PR description
Since we use Promise instead of jQuery deferred, the onRemove method class was no longer triggered before the actual removal of the elements. Original fix with https://github.com/odoo/odoo/pull/43918 This PR is the same with the async/await form, not breaking the history of half of the removeSnippet method's lines. Co-authored-by: fja-odoo <fja@odoo.com> Forward-Port-Of: odoo/odoo#44905 Forward-Port-Of: odoo/odoo#44900
Some dialog promise on web editor where not resolved on close blocking the editor. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43827
Original PR description
Some dialog promise on web editor where not resolved on close blocking the editor. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43827
Description of the issue/feature this PR addresses: Followup on 5ce8f1e375334e942ea807042e0348383492779c Current behavior before PR: Before this commit, There would be traceback on Launching Plan with `Responsible` set to `other` and No `Responsible Person` defined on activity due to Extra argument.  Desired behavior after PR is merged: In this commit, We remove that extra Argum
Original PR description
Description of the issue/feature this PR addresses: Followup on 5ce8f1e375334e942ea807042e0348383492779c Current behavior before PR: Before this commit, There would be traceback on Launching Plan with `Responsible` set to `other` and No `Responsible Person` defined on activity due to Extra argument.  Desired behavior after PR is merged: In this commit, We remove that extra Argument. Cc: @tde-banana-odoo Wouldn't be better to Display activity name in the warning. (Maybe in Master as IMP)  -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44922
The filter for Purchase orders in the Purchase report did not filter out Sent RFQ, despite the fact that they were not really ordered yet. opw:2158248 Forward-Port-Of: odoo/odoo#43620 Forward-Port-Of: odoo/odoo#43526
Original PR description
The filter for Purchase orders in the Purchase report did not filter out Sent RFQ, despite the fact that they were not really ordered yet. opw:2158248 Forward-Port-Of: odoo/odoo#43620 Forward-Port-Of: odoo/odoo#43526
When grouping records in kanban view, if a quick create widget was already opened, clicking on the "+" to launch another quick creation would crash. Fixes https://github.com/odoo/odoo/issues/44680 Forward-Port-Of: odoo/odoo#44888
Original PR description
When grouping records in kanban view, if a quick create widget was already opened, clicking on the "+" to launch another quick creation would crash. Fixes https://github.com/odoo/odoo/issues/44680 Forward-Port-Of: odoo/odoo#44888
The typical command to launch odoo in the install documentation is usable as it is after following the complete instructions. There is two changes done here: - Remove the ../my_modules from the command, as it is a directory not used in the page at all. - Remove the db-filter option not mandatory since the 11.0 version and add a '-d' argument. This will create the db instead of showing the database selector to the reader. -- I confirm I have signed the CLA and read the PR guidelines at www
Original PR description
The typical command to launch odoo in the install documentation is usable as it is after following the complete instructions. There is two changes done here: - Remove the ../my_modules from the command, as it is a directory not used in the page at all. - Remove the db-filter option not mandatory since the 11.0 version and add a '-d' argument. This will create the db instead of showing the database selector to the reader. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44640 Forward-Port-Of: odoo/odoo#43653
Some fixes for the website form recently merged. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44790
Original PR description
Some fixes for the website form recently merged. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44790
Make sure `force_company` context key is set on the SO if it exists. This is necessary to retrieve the fiscal position. opw-2186682 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44902 Forward-Port-Of: odoo/odoo#44451
Original PR description
Make sure `force_company` context key is set on the SO if it exists. This is necessary to retrieve the fiscal position. opw-2186682 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44902 Forward-Port-Of: odoo/odoo#44451
This restores the behavior for 12.0; we don't want those amount within the national tax report. Forward-Port-Of: odoo/odoo#44847
Original PR description
This restores the behavior for 12.0; we don't want those amount within the national tax report. Forward-Port-Of: odoo/odoo#44847
This route was public by mistake, probably introduced to test during ddf32f4 but no reason to make it public, public user has not the write access on models anyway. Courtesy of Swapnesh Shah Forward-Port-Of: odoo/odoo#44893
Original PR description
This route was public by mistake, probably introduced to test during ddf32f4 but no reason to make it public, public user has not the write access on models anyway. Courtesy of Swapnesh Shah Forward-Port-Of: odoo/odoo#44893
- Go to Settings > Technical > Resource > Working Times - Have a Resource Calendar RC with Average hour per day != 8.00 - Have an Employee E with Working Hours == RC - Leaves > Configuration > Leave Types - Have a Leave Type LT with Take Leaves in Hours - Leaves > Managers > All > Allocations - Create an Allocation A with Employee E and Leave Type LT - Enter any number in Duration The number of hours entered changes as we leave the field. Being totally honest, what happens here is n
Original PR description
- Go to Settings > Technical > Resource > Working Times - Have a Resource Calendar RC with Average hour per day != 8.00 - Have an Employee E with Working Hours == RC - Leaves > Configuration > Leave Types - Have a Leave Type LT with Take Leaves in Hours - Leaves > Managers > All > Allocations - Create an Allocation A with Employee E and Leave Type LT - Enter any number in Duration The number of hours entered changes as we leave the field. Being totally honest, what happens here is not clear at all, but using the corresponding `resource_id.calendar_id` field seems to fix the problem. opw-2191795 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44880