Wednesday, February 12, 2020
23 changes · master
Enhancements to existing features
The project overview now includes helpful explanations for key financial fields such as other costs, re-invoiced costs, invoiced revenue, and revenue still to invoice. This makes the report easier to understand for users reviewing project profitability and billing status.
Original PR description
Purpose ======= The project overview is still as obscure as ever, so we are adding even more tooltips. Specifications ============== Add the following tooltips to the project overview: - Other costs: Any cost linked to the Analytic Account of the Project. - Re-invoiced costs: Costs from expenses that were reinvoiced to your customer (provided that the Analytic Account of the Project was set on the Expense). - Invoiced: Revenues linked to Timesheets already invoiced. - To Invoice: Revenues linked to Timesheets not yet invoiced. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The SMS preview wizard has been simplified so previews rely on a single record reference and compute the message preview more consistently. This also corrects an incorrect “No Records” warning that could appear even when previewable records existed, improving confidence when preparing SMS templates.
Original PR description
Task : https://www.odoo.com/web#id=2180132&action=333&active_id=965&model=project.task&view_type=form&menu_id=4720 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This update corrects invalid filtering rules used in several business workflows, including approvals, USPS delivery settings, and field service sales projects. The fix helps ensure users see the right records and reduces the chance of errors when opening or using these screens.
Original PR description
Cf odoo/odoo#44642
Code cleanup and technical improvements
This update standardizes how font sizes are defined across multiple Odoo Enterprise screens and reports. It prepares these areas to support responsive text sizing when that option is enabled, helping layouts adapt better across different devices and print contexts.
Miscellaneous changes
Description of the issue/feature this PR addresses: Picture of employees are maximized directly which is annoying when you move the mouse in kanban view. Desired behavior after PR is merged: Add the ability to put a waiting time before opening the zoom in option of the field in the view (default value is 0). In employee kanban view, the waiting time is set to 1000ms. taskID: 2191289 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forw
Original PR description
Description of the issue/feature this PR addresses: Picture of employees are maximized directly which is annoying when you move the mouse in kanban view. Desired behavior after PR is merged: Add the ability to put a waiting time before opening the zoom in option of the field in the view (default value is 0). In employee kanban view, the waiting time is set to 1000ms. taskID: 2191289 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44704
The coupon generation wizard for helpdesk tickets now hides internal company and ticket fields. This reduces clutter for users and helps keep the flow focused on creating the coupon.
Original PR description
in wizard for generating coupon from tickets, hide the company, tickets fields task-2191174
This fixes search screens that had no searchable field configured, which previously made searching those records impossible. Users can now find records in the affected areas as expected, reducing friction in daily work.
Original PR description
Without at least one field, performing a search in these models' search view is outright impossible.
Original PR description
This will allow to use responsive font-sizes once the related option is enabled.
Before this commit, it was possible to delete an expense product even if it was already set on expense notes. Description of the issue/feature this PR addresses: opw-2195962 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45187 Forward-Port-Of: odoo/odoo#45175
Original PR description
Before this commit, it was possible to delete an expense product even if it was already set on expense notes. Description of the issue/feature this PR addresses: opw-2195962 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45187 Forward-Port-Of: odoo/odoo#45175
The customer display sometimes displayed a warning message saying: "A script on this page may be busy, or it may have stopped responding. [...] Script: chrome://[...]". We then remove the time limit for the execution of Chrome scripts. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45140
Original PR description
The customer display sometimes displayed a warning message saying: "A script on this page may be busy, or it may have stopped responding. [...] Script: chrome://[...]". We then remove the time limit for the execution of Chrome scripts. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45140
To reproduce: - Create a second company with the same currency as the first, - Assign the first pricelist with that currency (based on _order) to the second company - Install the POS, or create a new pos.config while in the first company The above results in: raise ValidationError("The selected pricelists must belong to no company or the company of the point of sale") opw-2192658 Forward-Port-Of: odoo/odoo#45171 Forward-Port-Of: odoo/odoo#45038
Original PR description
To reproduce:
- Create a second company with the same currency as the first,
- Assign the first pricelist with that currency (based on _order) to
the second company
- Install the POS, or create a new pos.config while in the first
company
The above results in:
raise ValidationError("The selected pricelists must belong to no
company or the company of the point of sale")
opw-2192658
Forward-Port-Of: odoo/odoo#45171
Forward-Port-Of: odoo/odoo#45038From Odoo 13.0, the list of answers of a user displays the name of the answer itself, and not its parent's. Answers created directly on a question are given a name, but answers created from a comment are not. This commit fixes this behavior for a better consistency: all posts should have a displayable name. A migration step on saas~12.5 will populate from their parent's name the existing posts that don't have a name. Forward-Port-Of: odoo/odoo#45159
Original PR description
From Odoo 13.0, the list of answers of a user displays the name of the answer itself, and not its parent's. Answers created directly on a question are given a name, but answers created from a comment are not. This commit fixes this behavior for a better consistency: all posts should have a displayable name. A migration step on saas~12.5 will populate from their parent's name the existing posts that don't have a name. Forward-Port-Of: odoo/odoo#45159
Sometimes, constraints are not delayed during a module upgrade: the module is 'to upgrade' but in 'init' mode :-/ Fix this by relying on the module's state only. Forward-Port-Of: odoo/odoo#45147
Original PR description
Sometimes, constraints are not delayed during a module upgrade: the module is 'to upgrade' but in 'init' mode :-/ Fix this by relying on the module's state only. Forward-Port-Of: odoo/odoo#45147
When we valide a stock landed costs with a stock picking with multiple products, when two stock valuation layers is created, only one was link to the journal account move. task-2123752 Forward-Port-Of: odoo/odoo#44829
Original PR description
When we valide a stock landed costs with a stock picking with multiple products, when two stock valuation layers is created, only one was link to the journal account move. task-2123752 Forward-Port-Of: odoo/odoo#44829
Without at least one field, performing a search in these models' search view is outright impossible. Related to https://github.com/odoo/enterprise/pull/8363 Forward-Port-Of: odoo/odoo#45143
Original PR description
Without at least one field, performing a search in these models' search view is outright impossible. Related to https://github.com/odoo/enterprise/pull/8363 Forward-Port-Of: odoo/odoo#45143
In some case, a pre migration script will call `xml_import.parse` to force reload a no-update data in pre script. It is possible that field will be marked as recompute in the process. The problem is that the reference to the field added in `env.all.tocompute` won't be the same as the reference of the same field after calling setup_models, leading to an infinite loop while recomputing this field since `fields.__get__` wont find self in `env.all.tocompute`. This problem was discorvered tr
Original PR description
In some case, a pre migration script will call `xml_import.parse` to force reload a no-update data in pre script. It is possible that field will be marked as recompute in the process. The problem is that the reference to the field added in `env.all.tocompute` won't be the same as the reference of the same field after calling setup_models, leading to an infinite loop while recomputing this field since `fields.__get__` wont find self in `env.all.tocompute`. This problem was discorvered trying to migrate a database with all modules installed (no demo data) from 12.0 to 13.0 (for commit references: http://runbot.odoo.com/runbot/build/1176576 with database comming from http://runbot.odoo.com/runbot/build/1171714). This commit add a check before executing `setup_models` in order to log if some tocompute remains before breaking fields references and add a flush after pre scipts to fix the current issue. Forward-Port-Of: odoo/odoo#45109 Forward-Port-Of: odoo/odoo#45016
d92f76592c19 introduced a toastr when publishing a record. It was designed for the topbar publishing toggle button, but some other templates ended up also using that feature. As those templates were missing `data-description` which contains the model business name, it would show `You've published your undefined`. This is only related to a very few places having a publish button inside the page. This commit fixed that by ensuring every publish button template have the necessary code. A
Original PR description
d92f76592c19 introduced a toastr when publishing a record. It was designed for the topbar publishing toggle button, but some other templates ended up also using that feature. As those templates were missing `data-description` which contains the model business name, it would show `You've published your undefined`. This is only related to a very few places having a publish button inside the page. This commit fixed that by ensuring every publish button template have the necessary code. Also, a fallback is added in case tha `data-description` is missing somehow. task-2191735 Forward-Port-Of: odoo/odoo#44975
### Issue - Install MRP - MO > Import with BOM The lines are not populated but it was the case in v12. ### Cause In 7206b385b5, the lines generation are done in a onchange but they are not trigerred in imports ### Solution Call the onchange manually when we are in an import case **OPW-2188066** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45081
Original PR description
### Issue - Install MRP - MO > Import with BOM The lines are not populated but it was the case in v12. ### Cause In 7206b385b5, the lines generation are done in a onchange but they are not trigerred in imports ### Solution Call the onchange manually when we are in an import case **OPW-2188066** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45081
Steps to reproduce the bug: - Install l10n_sg - Create a new company C where country = Singapore - Set l10n_sg as the chart of accounts of C - Go to Tax report Bug: A traceback was raised. opw:2191692 Forward-Port-Of: odoo/enterprise#8351
Original PR description
Steps to reproduce the bug: - Install l10n_sg - Create a new company C where country = Singapore - Set l10n_sg as the chart of accounts of C - Go to Tax report Bug: A traceback was raised. opw:2191692 Forward-Port-Of: odoo/enterprise#8351
- Install `industry_fsm` - Delete the FSM project - Install `industry_fsm_report` The module can't be installed since a data is missing. We move the data update in a `post_init_hook`. opw-2180900 Forward-Port-Of: odoo/enterprise#8352 Forward-Port-Of: odoo/enterprise#8335
Original PR description
- Install `industry_fsm` - Delete the FSM project - Install `industry_fsm_report` The module can't be installed since a data is missing. We move the data update in a `post_init_hook`. opw-2180900 Forward-Port-Of: odoo/enterprise#8352 Forward-Port-Of: odoo/enterprise#8335
…ation After modifying start or/and end date on a contract, we remove already generated work entries that are outside new period. taskID: 2179816 original-commit: d6e6ebb Forward-Port-Of: odoo/enterprise#8349
Original PR description
…ation After modifying start or/and end date on a contract, we remove already generated work entries that are outside new period. taskID: 2179816 original-commit: d6e6ebb Forward-Port-Of: odoo/enterprise#8349
From an accounting perspective companies are allowed to create multiple RteICA accounts as long as they start with 2368. opw-2192156 Forward-Port-Of: odoo/enterprise#8361
Original PR description
From an accounting perspective companies are allowed to create multiple RteICA accounts as long as they start with 2368. opw-2192156 Forward-Port-Of: odoo/enterprise#8361
Without at least one field, performing a search in these models' search view is outright impossible. Related to https://github.com/odoo/odoo/pull/45143 Forward-Port-Of: odoo/enterprise#8363
Original PR description
Without at least one field, performing a search in these models' search view is outright impossible. Related to https://github.com/odoo/odoo/pull/45143 Forward-Port-Of: odoo/enterprise#8363
Steps to reproduce: - install sale_intrastat - attempt to create an invoice Previous behavior: you get a traceback "ValueError: Invalid field 'intrastat_product_origin_country_id' on model 'account.move.line'" this field only exists in belgian accounting Current behavior: the faulty field has been moved to another module and only affects belgian accounting opw-2194943 Forward-Port-Of: odoo/enterprise#8345
Original PR description
Steps to reproduce: - install sale_intrastat - attempt to create an invoice Previous behavior: you get a traceback "ValueError: Invalid field 'intrastat_product_origin_country_id' on model 'account.move.line'" this field only exists in belgian accounting Current behavior: the faulty field has been moved to another module and only affects belgian accounting opw-2194943 Forward-Port-Of: odoo/enterprise#8345