Monday, February 17, 2020
31 changes · master
Enhancements to existing features
The search view sidebar in Studio now shows clearer field labels for grouping and autocomplete options when properties are enabled. Dropdown text styling and spacing were adjusted to make the interface easier to scan and use.
Original PR description
PURPOSE For better user experience, in search view side bar, field label of group by and autocomplete field is displayed (while properties view is enable) and font weight is removed. LINKS task - 2186710
Resolved issues and error corrections
The manufacturing work order tablet view was adjusted to use a valid filter setup. This prevents errors caused by an outdated filter format and helps operators continue using tablet workflows reliably.
Original PR description
in view mrp_workorder_view_form_tablet, some domain contained
too much binary operator ('|'). Since e95ccf0908c263f6cf23c91c477a8e252e936ff1 ,
it is forbidden to have too much binary operator in domain.Miscellaneous changes
After a bad merge d785adba6c09b0773bdd874182f450ba2ebe7c6d the `eval` code was evaluated twice. Forward-Port-Of: odoo/odoo#45511
Original PR description
After a bad merge d785adba6c09b0773bdd874182f450ba2ebe7c6d the `eval` code was evaluated twice. Forward-Port-Of: odoo/odoo#45511
Field service project users can now enable or disable the extra quotations option after a project has been created. This fixes a configuration issue so teams can adjust quotation workflows without creating a new project.
Original PR description
extra quotations feature is set to value of setting parameters when new fsm project is created but, extra quotation feature was not possible to enabled or disabled from project afterwards. task-2192763
Set the following product configuration: Storable finished product with a flexible BOM made of storable components in manufacture + MTO: Component choice 1 Quantity = 0 with BOM made of component 1, quantity 1 with purchase mto route Component choice 2 Quantity = 0 with BOM made of component 2, quantity 1 with purchase mto route Create a MO for finished product, set the "to consume" quantity of "Component choice 1" to 1, and try to mark it as to do. The following issue is raised: Th
Original PR description
Set the following product configuration: Storable finished product with a flexible BOM made of storable components in manufacture + MTO: Component choice 1 Quantity = 0 with BOM made of component 1, quantity 1 with purchase mto route Component choice 2 Quantity = 0 with BOM made of component 2, quantity 1 with purchase mto route Create a MO for finished product, set the "to consume" quantity of "Component choice 1" to 1, and try to mark it as to do. The following issue is raised: The quantity to produce must be positive! This is because a procurement with 0 quantity will be solved in a MO producing 0 quantity. We fix this issue by ignoring procurements with 0 quantities. Also, this MO without initial demand is not considered assigned. We fix this issue by considering 0 move as assigned. task-2159374 Forward-Port-Of: odoo/odoo#45535 Forward-Port-Of: odoo/odoo#45499
In order to prevent `CacheMiss` errors. Closes #45242 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45519
Original PR description
In order to prevent `CacheMiss` errors. Closes #45242 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45519
When a package contains products with putaway to different locations, it could happen the move lines locations are took from putaway location. In this case, location dest of package and its move lines aren't consistent anymore. With this commit, when moves are assigned, package and its move lines `location_dest_id` are checked, and are all set to the first move line `location_dest_id` if there is a difference. task-2146583 task-2148494 Forward-Port-Of: odoo/odoo#45516 Forward-Port-Of: odoo
Original PR description
When a package contains products with putaway to different locations, it could happen the move lines locations are took from putaway location. In this case, location dest of package and its move lines aren't consistent anymore. With this commit, when moves are assigned, package and its move lines `location_dest_id` are checked, and are all set to the first move line `location_dest_id` if there is a difference. task-2146583 task-2148494 Forward-Port-Of: odoo/odoo#45516 Forward-Port-Of: odoo/odoo#43449
Description of the issue/feature this PR addresses: Will add the debit note concept in a simple way. Want to check how far we get with this already. Questions to be asked: - Many2one ok from Debit Note to originator invoice or should it be a many2many - What we create is like a copy of the original invoice and right now it also copies the lines automatically, but I would suppose that if you create a debit note, it would normally not contain the original products but just a correction l
Original PR description
Description of the issue/feature this PR addresses: Will add the debit note concept in a simple way. Want to check how far we get with this already. Questions to be asked: - Many2one ok from Debit…
Description of the issue/feature this PR addresses: Will add the debit note concept in a simple way. Want to check how far we get with this already. Questions to be asked: - Many2one ok from Debit Note to originator invoice or should it be a many2many - What we create is like a copy of the original invoice and right now it also copies the lines automatically, but I would suppose that if you create a debit note, it would normally not contain the original products but just a correction line? - I don't know if it would make a lot of sense to take them into account for reconciliation (e.g. you could reconcile with credit notes from the origin invoice) - I suppose you don't do debit note of debit notes or debit notes of credit notes like you don't do credit notes of credit notes. This is intended for v13 to be used by l10n_(ar/pe/cl)_edi and in master by the l10n_(ar/pe/cl) modules themselves. (document_type_id could maybe be added in latam_invoice_document)   -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45496 Forward-Port-Of: odoo/odoo#41806
Create a purchase order, confirm it and create the vendor bill. The source document will be not filled. Fixing the related variable. opw-2197272 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45456
Original PR description
Create a purchase order, confirm it and create the vendor bill. The source document will be not filled. Fixing the related variable. opw-2197272 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45456
When making a payment for multiple vendor bills at once, it is possible that payments will be generated without any recipient bank account for payment methods normally requiring one. In such cases, the user needs to be able to correct the payments by cancelling them. It was not possible. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.c
Original PR description
When making a payment for multiple vendor bills at once, it is possible that payments will be generated without any recipient bank account for payment methods normally requiring one. In such cases, the user needs to be able to correct the payments by cancelling them. It was not possible. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44422 Forward-Port-Of: odoo/odoo#44406
VAT, NIF in Spanish, is translated NIT in Spanish from Bolivia Clean and translate the files with the correct translation. opw-2197155 Forward-Port-Of: odoo/odoo#45506
Original PR description
VAT, NIF in Spanish, is translated NIT in Spanish from Bolivia Clean and translate the files with the correct translation. opw-2197155 Forward-Port-Of: odoo/odoo#45506
Description of the issue/feature this PR addresses: Making paperformat_id False on 'Company Document Layout' will also make paperformat_id False on Company while this is already required on Settings. Current behavior before PR: Don't Select Paperformat on  Try to Update Settings for any App ](https://user-images.githubusercontent.com/16624719/71549403-acff9480-29e2-11ea-8f04-c39932f33dc3.png) Try to Update Settings for any App  Desired behavior after PR is merged: In this commit, we make paperformat_id Required as Its already required on Other views. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42437
Create an immediate transfer for a receipt, add a move, set a quantity done and due to rev[0], an initial demand is set, then _autoconfirm_picking is called and action_confirm of picking calls _action_assign if the location source bypasses the reservation. Set again an inferior qty_done, the initial demand is also updated due to rev[0] and somehow the system tries to write on a now unlinked move line. fixes - never reserve an immediate transfer - never update the initial demand if the
Original PR description
Create an immediate transfer for a receipt, add a move, set a quantity done and due to rev[0], an initial demand is set, then _autoconfirm_picking is called and action_confirm of picking calls _action_assign if the location source bypasses the reservation. Set again an inferior qty_done, the initial demand is also updated due to rev[0] and somehow the system tries to write on a now unlinked move line. fixes - never reserve an immediate transfer - never update the initial demand if the move is reserved to fix the existing databases. [0] 8303b1a69e96807bcb548ef079dcb463e34df36b opw-2180556 Forward-Port-Of: odoo/odoo#45304 Forward-Port-Of: odoo/odoo#45218
Steps to reproduce the bug: - In debug mode, create a SO - Confirm the SO - Click on "Create invoice" - In the wizard, click on the debug logo - Set a User default value V for Downpayment amount - Close the wizard - Re-click on "Create invoice" Bug: The default value V was not suggested. Fine tuning of c258b8a0427bd5aface891ed1f4420174f4afde4 opw:2184367 Forward-Port-Of: odoo/odoo#45460
Original PR description
Steps to reproduce the bug: - In debug mode, create a SO - Confirm the SO - Click on "Create invoice" - In the wizard, click on the debug logo - Set a User default value V for Downpayment amount - Close the wizard - Re-click on "Create invoice" Bug: The default value V was not suggested. Fine tuning of c258b8a0427bd5aface891ed1f4420174f4afde4 opw:2184367 Forward-Port-Of: odoo/odoo#45460
======= PURPOSE ======= Avoid communication being lost on transfers due to the fact that nobody is following. ============= SPECIFICATION ============= When setting a delivery address, add the contact in question as a follower of the transfer. When a user validates a transfer, he should be automatically added as a follower of this transfer. =========== LINKS =========== task 2172675 pr #44350 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/s
Original PR description
======= PURPOSE ======= Avoid communication being lost on transfers due to the fact that nobody is following. ============= SPECIFICATION ============= When setting a delivery address, add the contact in question as a follower of the transfer. When a user validates a transfer, he should be automatically added as a follower of this transfer. =========== LINKS =========== task 2172675 pr #44350 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45466 Forward-Port-Of: odoo/odoo#44350
…ccounts When creating a payment, we are expecting only one destination account. However, when grouping payment by customer, it can happen that there are more than one receivable or payable accounts, which can create reconciliation issues afterward. Description of the issue/feature this PR addresses: opw-2166551 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward
Original PR description
…ccounts When creating a payment, we are expecting only one destination account. However, when grouping payment by customer, it can happen that there are more than one receivable or payable accounts, which can create reconciliation issues afterward. Description of the issue/feature this PR addresses: opw-2166551 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44130
When requesting multiple tracked content at the same time with the same visitor concurrent updates happen. The best way I got to consistently reproduce the issue is to open 2 tracked pages with chrome command line: google-chrome http://pcodoo:8069/contactus http://pcodoo:8069/. The first tracked page will update the visitor and lock it. When the second will try to create a track which has a FK referencing the visitor PSQL will try to SELECT FOR KEY SHARE the visitor but it is locked
Original PR description
When requesting multiple tracked content at the same time with the same visitor concurrent updates happen. The best way I got to consistently reproduce the issue is to open 2 tracked pages with chrome command line: google-chrome http://pcodoo:8069/contactus http://pcodoo:8069/. The first tracked page will update the visitor and lock it. When the second will try to create a track which has a FK referencing the visitor PSQL will try to SELECT FOR KEY SHARE the visitor but it is locked => Concurrent Update Error. Using FOR NO KEY UPDATE instead of FOR UPDATE performs a weaker lock that will not block SELECT FOR KEY SHARE. Fixes: #38372 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45463
- Open any product kanban view with missing images 404 status code are returned for missing images, while they are replaced by a placeholder. This can cause issues when configuring a specific 404 page in a reverse proxy: the proxy will serve the custom page instead of the placeholder. opw-2192663 opw-2192340 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and rea
Original PR description
- Open any product kanban view with missing images 404 status code are returned for missing images, while they are replaced by a placeholder. This can cause issues when configuring a specific 404 page in a reverse proxy: the proxy will serve the custom page instead of the placeholder. opw-2192663 opw-2192340 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45135 Forward-Port-Of: odoo/odoo#45086
Missing context key in case of reverse of a vendor bill it was then adding the anglo-saxon move lines. opw-2172562 Forward-Port-Of: odoo/odoo#45410
Original PR description
Missing context key in case of reverse of a vendor bill it was then adding the anglo-saxon move lines. opw-2172562 Forward-Port-Of: odoo/odoo#45410
Do not use an inactive mail server to send the requests. opw-2197011 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45335
Original PR description
Do not use an inactive mail server to send the requests. opw-2197011 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45335
Fixes de590816d8d06730d99499db9a068f8d0e2cd3f9 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45287
Original PR description
Fixes de590816d8d06730d99499db9a068f8d0e2cd3f9 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45287
Purpose ======= Having a char field referring to an Integer could lead to unwanted behavior if not managed correctly. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45389
Original PR description
Purpose ======= Having a char field referring to an Integer could lead to unwanted behavior if not managed correctly. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45389
Previouly, while scanning a package via barcode, `owner_id` wasn't being included in the move lines. This commit fixes that in both transfers and inventory adjustments and adds test case for owner when scanning a package. Task-2093527 Forward-Port-Of: odoo/enterprise#8467
Original PR description
Previouly, while scanning a package via barcode, `owner_id` wasn't being included in the move lines. This commit fixes that in both transfers and inventory adjustments and adds test case for owner when scanning a package. Task-2093527 Forward-Port-Of: odoo/enterprise#8467
- Users with no access rights to the model `planning.slot` are not able to delete projects or tasks if the module `project_forecast` is installed. Forward-Port-Of: odoo/enterprise#8463
Original PR description
- Users with no access rights to the model `planning.slot`
are not able to delete projects or tasks if the module
`project_forecast` is installed.
Forward-Port-Of: odoo/enterprise#8463Task 2091654 accidentally removed the possibility to create empty menu entries to create 'complex' menu hierarchies. This commit re-introduces this possibility by adding a radio selection 'Parent Menu' in the menu editor dialog. Task 2198566 Forward-Port-Of: odoo/enterprise#8487
Original PR description
Task 2091654 accidentally removed the possibility to create empty menu entries to create 'complex' menu hierarchies. This commit re-introduces this possibility by adding a radio selection 'Parent Menu' in the menu editor dialog. Task 2198566 Forward-Port-Of: odoo/enterprise#8487
Create a deferred revenue/expense Create an invocie which map to the deferred revenue/expense account Post the invoice so it will generate the deferred entry (in draft) Confirm the deferred Entry Reset to draft the invoice User will be unable to post the invoice again because of the deferred revenue/expense open but also unable to access it because the invoice is not in posted state (deadlock). Adding a condition to block 'reset to draft' button if there is some deferred revenue/exp
Original PR description
Create a deferred revenue/expense Create an invocie which map to the deferred revenue/expense account Post the invoice so it will generate the deferred entry (in draft) Confirm the deferred Entry Reset to draft the invoice User will be unable to post the invoice again because of the deferred revenue/expense open but also unable to access it because the invoice is not in posted state (deadlock). Adding a condition to block 'reset to draft' button if there is some deferred revenue/expense not in draft. opw-2180330 Forward-Port-Of: odoo/enterprise#8472 Forward-Port-Of: odoo/enterprise#8177
- Connect as admin, - make sur you have the group administration > settings, - remove any Planning group (nor user nor manager), - access the Planning app, notice you directly land in the configuration menu. Forward-Port-Of: odoo/enterprise#8454
Original PR description
- Connect as admin, - make sur you have the group administration > settings, - remove any Planning group (nor user nor manager), - access the Planning app, notice you directly land in the configuration menu. Forward-Port-Of: odoo/enterprise#8454
valueDate is the date considered by the bank to compute interests, what we want is the executionDate which correspond to the date of the transaction Forward-Port-Of: odoo/enterprise#8465
Original PR description
valueDate is the date considered by the bank to compute interests, what we want is the executionDate which correspond to the date of the transaction Forward-Port-Of: odoo/enterprise#8465
User can't validate picking due to the lack of access right. Forward-Port-Of: odoo/enterprise#8462 Forward-Port-Of: odoo/enterprise#8126
Original PR description
User can't validate picking due to the lack of access right. Forward-Port-Of: odoo/enterprise#8462 Forward-Port-Of: odoo/enterprise#8126
Since PR: https://github.com/odoo/odoo/pull/43222 the field 'length' has been renamed, 'packaging_length', and there were still references to the old name. Forward-Port-Of: odoo/enterprise#8461
Original PR description
Since PR: https://github.com/odoo/odoo/pull/43222 the field 'length' has been renamed, 'packaging_length', and there were still references to the old name. Forward-Port-Of: odoo/enterprise#8461
When installing the module, there is a KeyError for model hr.leave.type as there is an attempt for it's record insertion. The module has no direct/indirect dependency for hr_holidays module. Currently the record is removed. There was an alternate for adding hr_work_entry_holidays module dependency, but the leave type with string 'Heures Supplementaires' seemed inapt. So the record was removed. Certain created records getting updated later has missing model attribute, so those are fi
Original PR description
When installing the module, there is a KeyError for model hr.leave.type as there is an attempt for it's record insertion. The module has no direct/indirect dependency for hr_holidays module. Currently the record is removed. There was an alternate for adding hr_work_entry_holidays module dependency, but the leave type with string 'Heures Supplementaires' seemed inapt. So the record was removed. Certain created records getting updated later has missing model attribute, so those are filled. After the merge, l10n_fr_hr_payroll module can be installed successfully. Task: 2169189 Forward-Port-Of: odoo/enterprise#8401