Wednesday, February 19, 2020
14 changes · master
New functionality added to Odoo
A new test was added to verify that TaxCloud sales tax calculations work correctly through the full sales and payment process. This helps reduce the risk of billing or tax issues when customers complete payments using TaxCloud.
Original PR description
Purpose: Test full flow of taxcloud with payment Task-2121109
Enhancements to existing features
Additional automated checks were added for CRM lead conversion flows, especially around matching customers and detecting duplicates by email. This helps protect future CRM improvements from accidentally changing important sales workflow behavior.
Original PR description
PURPOSE As CRM is going to be updated (onchange -> compute, code improvements, better management of sales teams) having some tests is a necessary first step. SPECIFICATIONS Add tests. Amazing. Notably about matching partner / duplicate based on email as there is some weird behavior. LINKS Task ID 2088565
Resolved issues and error corrections
This update corrects rules used to show or hide fields in Project and CRM lead generation screens. It prevents avoidable interface errors so users can continue working without disruption.
Original PR description
Since the commit https://github.com/odoo/odoo/commit/e95ccf0908c263f6cf23c91c477a8e252e936ff1 invalid client-side domain will raise the error So purpose of the task is to fix the invalid client-side domain. Task 2196805 PR #45290
Miscellaneous changes
The widget Selectbo was performing a search_read on every field while only using the fields id and name. This search_read has become very costly in the latest version due to some new fields. We now limit the search_read to the useful fields. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#456
Original PR description
The widget Selectbo was performing a search_read on every field while only using the fields id and name. This search_read has become very costly in the latest version due to some new fields. We now limit the search_read to the useful fields. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45654
When a technical modal (like in hr_holidays in the dialog to take a time-off) contains a date widget, the date picker dialog is opened behind the modal and is not accessible. This issue was introduced by the commit odoo/odoo@65c8d33c2922bd90e2755cff0a6751c8b3b130d8, which aimed a fixing the stacking of the web-editor dialog, in fullscreen, inside an iframe (ie. as used in mass-mailing) but by trying to circumvent the inline styles set in the template 'web_editor.FieldTextHtml.fullscreen
Original PR description
When a technical modal (like in hr_holidays in the dialog to take a time-off) contains a date widget, the date picker dialog is opened behind the modal and is not accessible. This issue was introduced by the commit odoo/odoo@65c8d33c2922bd90e2755cff0a6751c8b3b130d8, which aimed a fixing the stacking of the web-editor dialog, in fullscreen, inside an iframe (ie. as used in mass-mailing) but by trying to circumvent the inline styles set in the template 'web_editor.FieldTextHtml.fullscreen' (https://github.com/odoo/odoo/commit/912996fe902c41cafa12dcfe09713ce9857f95ab#diff-76a385e3a3e67f1b88b34afd8181f732R13), the css styles were applied too widely. This commit fixes those styles by scoping them with a class specific to web-editor's dialogs. Task ID: 2198649 Forward-Port-Of: odoo/odoo#45513
On a standard odoo install, `MigrationManager._get_files` represent more than 4% of an install. This is because the legacy odoo/base/maintenance/migration path was added to upgrade.__path__ once by module, making the get_filed check 574^2 os.path.exists. This commit adds a check on initialize_sys_path to call it only once, and merge legacy path with upgrade-path management in order to benefit of the `up not in upgrade.__path__` check. A further improvement would be to fix MigrationMan
Original PR description
On a standard odoo install, `MigrationManager._get_files` represent more than 4% of an install. This is because the legacy odoo/base/maintenance/migration path was added to upgrade.__path__ once by module, making the get_filed check 574^2 os.path.exists. This commit adds a check on initialize_sys_path to call it only once, and merge legacy path with upgrade-path management in order to benefit of the `up not in upgrade.__path__` check. A further improvement would be to fix MigrationManager in order to skip _get_file work on a fresh install, (wip by rco-odoo) Enterprise 13.0 :3.7% http://runbot36.odoo.com/runbot/static/build/1304561-13-0-7addb9/logs/flame_flamegraph-install-all.svg Community 13.0: 2.4% Enterprise master: 4.9% Forward-Port-Of: odoo/odoo#45673 Forward-Port-Of: odoo/odoo#45662
Description of the issue/feature this PR addresses: Fix constrains on contract and time off. Current behavior before PR: When we change a contract to stage 'open', we write this contract on employee. But it causes error when it's a template contract (without employee). We check for all contract that there are no overlapping for a same employee. We can't create company (or team) time off if you have 2 or more template contract in your database. We can't create multiple company or te
Original PR description
Description of the issue/feature this PR addresses: Fix constrains on contract and time off. Current behavior before PR: When we change a contract to stage 'open', we write this contract on employee.…
Description of the issue/feature this PR addresses: Fix constrains on contract and time off. Current behavior before PR: When we change a contract to stage 'open', we write this contract on employee. But it causes error when it's a template contract (without employee). We check for all contract that there are no overlapping for a same employee. We can't create company (or team) time off if you have 2 or more template contract in your database. We can't create multiple company or team time off that overlaps. Desired behavior after PR is merged: When we change a contract to stage 'open', we write this contract on employee only if contract has an employee. We check that there are no overlapping for contract with employee. We can create company (or team) time off if you have 2 or more template contract in your database. If a time off is set across multiple contract, print those contracts in error message. We can create multiple company or team time off that overlaps. taskID: 2196185 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45476 Forward-Port-Of: odoo/odoo#45394
Introduced by: https://github.com/odoo/odoo/commit/31e1322b40ab33bf81d4c000f2b2a3f3eb8d0958 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45637
Original PR description
Introduced by: https://github.com/odoo/odoo/commit/31e1322b40ab33bf81d4c000f2b2a3f3eb8d0958 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45637
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45473 Forward-Port-Of: odoo/odoo#45289
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45473 Forward-Port-Of: odoo/odoo#45289
Steps to reproduce the bug: - The field expense_policy in the product.product form view was not visible before saving PS: The default value was always set to False even if the current user was in the right group. opw:2194236 Forward-Port-Of: odoo/odoo#45467
Original PR description
Steps to reproduce the bug: - The field expense_policy in the product.product form view was not visible before saving PS: The default value was always set to False even if the current user was in the right group. opw:2194236 Forward-Port-Of: odoo/odoo#45467
Steps to reproduce: - install crm - go to any lead and schedule an activity in the mail thread - select "email" as activity type and type some text in the note field - change the activity type to "call" Previous behavior: The text you had in the note field is erased even if there is nothing set as a default message Current behavior: the note field gets erased only if there is a default message set for the current activity type opw-2195368 Forward-Port-Of: odoo/odoo#45505
Original PR description
Steps to reproduce: - install crm - go to any lead and schedule an activity in the mail thread - select "email" as activity type and type some text in the note field - change the activity type to "call" Previous behavior: The text you had in the note field is erased even if there is nothing set as a default message Current behavior: the note field gets erased only if there is a default message set for the current activity type opw-2195368 Forward-Port-Of: odoo/odoo#45505
…e off Before this commit: We can't create company (or team) time off if you have 2 or more template contract in your database. We can't create mutliple company or team time off that overlaps. After this commit: We can create company (or team) time off if you have 2 or more template contract in your database. If a time off is set across multiple contract, print those contracts in error message. We can create multiple company or team time off that overlaps. taskID: 2196185 Forwa
Original PR description
…e off Before this commit: We can't create company (or team) time off if you have 2 or more template contract in your database. We can't create mutliple company or team time off that overlaps. After this commit: We can create company (or team) time off if you have 2 or more template contract in your database. If a time off is set across multiple contract, print those contracts in error message. We can create multiple company or team time off that overlaps. taskID: 2196185 Forward-Port-Of: odoo/enterprise#8471 Forward-Port-Of: odoo/enterprise#8443
This feature hasn't be handled during the following refactoring: https://github.com/odoo/enterprise/commit/172e8a4f3df759ad6261563222f5b65eb5e12149 Forward-Port-Of: odoo/enterprise#8525
Original PR description
This feature hasn't be handled during the following refactoring: https://github.com/odoo/enterprise/commit/172e8a4f3df759ad6261563222f5b65eb5e12149 Forward-Port-Of: odoo/enterprise#8525
Opening or creating an expense raises a traceback. The domain syntax is wrong [1] [1] https://en.wikipedia.org/wiki/Polish_notation Forward-Port-Of: odoo/enterprise#8464
Original PR description
Opening or creating an expense raises a traceback. The domain syntax is wrong [1] [1] https://en.wikipedia.org/wiki/Polish_notation Forward-Port-Of: odoo/enterprise#8464