Tuesday, March 10, 2020
30 changes · master
Enhancements to existing features
The signature flow has been adjusted so mobile users are not automatically focused into the name field when opening the name and signature step. This helps prevent the on-screen keyboard from appearing unexpectedly and makes signing smoother on phones and tablets.
Original PR description
Task ID: 2155601
The web client startup template was simplified by removing obsolete Internet Explorer-specific code and shortening a menu reload script. This reduces unnecessary page content and keeps the web interface aligned with modern browser support, with no expected change for users on supported browsers.
Original PR description
This PR modifies the `web.webclient_bootstrap` template in two ways: - removes conditional comments targetting old IE versions - rewrite odoo.reloadMenus implementation to take advantage of modern JS syntax.
New databases now get the same accent-insensitive search support that restored databases already received when the option is enabled. This keeps database creation and restoration behavior consistent and helps avoid search differences between environments.
Original PR description
When `unaccent = True`, odoo should install `unaccent` extension in new databases, like [it does in restored databases](https://github.com/odoo/odoo/blob/355e3609732bdc1ef0563edadb8634a322d7d5af/odoo/service/db.py#L305).
Product pricelists can now use decimal values for minimum quantities instead of only whole numbers. This makes pricing rules more flexible for products sold or priced in fractional quantities, such as by weight, length, or partial units.
Original PR description
purpose of this commit is to change the field type of min_quantity from int to float on product pricelist object task:2165208 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This fixes an issue where clicking Edit on a website page with no editable content could show an error. Users now avoid an unnecessary interruption when managing website pages that cannot be edited.
Original PR description
Avoid traceback when click on edit and nothing is editable on the page. task-2199214 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
**Description of the issue/feature this PR addresses:** Prefetching fields does not make any sense if we unlink afterwards, so we disable the prefetch that it will not access before. This does not reduce query count, but improves the runtime depending on the recordset size between 6-50%, still not enough, but a start. Should be possible to forward port. Info: @wt-io-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/od
Original PR description
**Description of the issue/feature this PR addresses:** Prefetching fields does not make any sense if we unlink afterwards, so we disable the prefetch that it will not access before. This does not reduce query count, but improves the runtime depending on the recordset size between 6-50%, still not enough, but a start. Should be possible to forward port. Info: @wt-io-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47184 Forward-Port-Of: odoo/odoo#45851
This update fixes a spelling mistake in a field label within the employee organization chart. It improves clarity and presentation for users viewing HR organizational information, with no expected change to business processes.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Test locations used by the inventory barcode workflow were renamed from “Shelf” to “Section” to avoid duplicate names. This prevents automated tests from selecting the wrong location, making test results more consistent without changing customer-facing behavior.
Original PR description
As we usually use WH/Stock as location in test, we also have it's child locations (Shelf 1, Shelf 2, ...). But, in some test, we created also locations we name also Shelf 1 and Shelf 2. Because of that, it can happen in test tour that the tour doesn't select the same location (for instance, want to select Shelf 1, but hey, we have two Shelf 1 !). The result could be we have during the tour an another page with the same name than an existing page. So, to avoid this undeterminist behavior, this commit renames all locations created in tests with a "Shelf n" name into "Section n".
Before 13.0, the "Payment reference" column was linked to the 'ref' field. In 13.0 it is linked to "invoice_payment_ref". So the field reference was not visible in the list view opw:2201763 Forward-Port-Of: odoo/odoo#47162 Forward-Port-Of: odoo/odoo#46983
Original PR description
Before 13.0, the "Payment reference" column was linked to the 'ref' field. In 13.0 it is linked to "invoice_payment_ref". So the field reference was not visible in the list view opw:2201763 Forward-Port-Of: odoo/odoo#47162 Forward-Port-Of: odoo/odoo#46983
Steps to reproducethe bug: - On an existing product P, add alternative products under the eCommerce tab - Go to the website - Check that the compare button is enabled on the main shop page - Turn off comparison button in the list under customize menu Bug: The compare button is still available on the alternative products of P. opw:2201874 Forward-Port-Of: odoo/odoo#47202
Original PR description
Steps to reproducethe bug: - On an existing product P, add alternative products under the eCommerce tab - Go to the website - Check that the compare button is enabled on the main shop page - Turn off comparison button in the list under customize menu Bug: The compare button is still available on the alternative products of P. opw:2201874 Forward-Port-Of: odoo/odoo#47202
task - https://www.odoo.com/web#id=2058702&action=327&model=project.task&view_type=form&menu_id=4720 pad - https://pad.odoo.com/p/r.50444f91ae4d457c61a3465732f117ab While selecting an option from popover, widget will set that option value in "field-selector" space and shows related fields list (if any) in popover. Now close that popover and focus-in that field-selector will open pop-over and shows list of field options but not only related to that set field-selector value, it will show all
Original PR description
task - https://www.odoo.com/web#id=2058702&action=327&model=project.task&view_type=form&menu_id=4720 pad - https://pad.odoo.com/p/r.50444f91ae4d457c61a3465732f117ab While selecting an option from popover, widget will set that option value in "field-selector" space and shows related fields list (if any) in popover. Now close that popover and focus-in that field-selector will open pop-over and shows list of field options but not only related to that set field-selector value, it will show all the options. This is the issue. It should be shows options only related to that already set field-selector value. Described issue has been fixed by this commit. Forward-Port-Of: odoo/odoo#47157 Forward-Port-Of: odoo/odoo#36307
opw-2210274 Forward-Port-Of: odoo/odoo#47126
Original PR description
opw-2210274 Forward-Port-Of: odoo/odoo#47126
Purpose: Same view for report of SO and SO online Specification: -Display 'Discription on the Invoice' of payment terms instead of 'Name' of the payment terms on SO online task-2186685 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47084 Forward-Port-Of: odoo/odoo#46815
Original PR description
Purpose: Same view for report of SO and SO online Specification: -Display 'Discription on the Invoice' of payment terms instead of 'Name' of the payment terms on SO online task-2186685 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47084 Forward-Port-Of: odoo/odoo#46815
- Create 2 companies A & B - Set the website in A - Set the user in both companies, main company being A - Create a SO template in company B - Click on "Design Template" An AccessError is raised because: - `slug` accesses the `display_name` of the template which is in company B - the `allowed_company_ids` is set to company A in [1] A solution could be to always set: ``` context['allowed_company_ids'] = request.env.user.company_ids.ids ``` But the side-effects could cause oth
Original PR description
- Create 2 companies A & B - Set the website in A - Set the user in both companies, main company being A - Create a SO template in company B - Click on "Design Template" An AccessError is raised because: - `slug` accesses the `display_name` of the template which is in company B - the `allowed_company_ids` is set to company A in [1] A solution could be to always set: ``` context['allowed_company_ids'] = request.env.user.company_ids.ids ``` But the side-effects could cause other issues. Therefore, we handle the `slug` manually. [1] https://github.com/odoo/odoo/blob/af411b866aa2052c01168342f8f05ae3dabad83e/addons/website/models/ir_http.py#L203 opw-2194103 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47192
Cherry-pick of #46379 Forward-Port-Of: odoo/odoo#47234 Forward-Port-Of: odoo/odoo#47214
Original PR description
Cherry-pick of #46379 Forward-Port-Of: odoo/odoo#47234 Forward-Port-Of: odoo/odoo#47214
### Issue - Install Sale - Create SO - Add a note line with a very looong word - Print PDF No line break, table is expending out of the visible report. ### Cause There is no line break CSS rule ### Solution Use word-break: break-word; in order to break line without cutting words. **OPW-2195984** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47090
Original PR description
### Issue - Install Sale - Create SO - Add a note line with a very looong word - Print PDF No line break, table is expending out of the visible report. ### Cause There is no line break CSS rule ### Solution Use word-break: break-word; in order to break line without cutting words. **OPW-2195984** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47090
If you want to de-activate the multi company ir.rule, those checks will still raise an error. Task 2198433 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47176
Original PR description
If you want to de-activate the multi company ir.rule, those checks will still raise an error. Task 2198433 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47176
This PR allows one to build the user documentation with python 3 and sphinx>= 2.4.0. It also removes several warnings. Remove autogenerated JS doc (backport from master) Forward-Port-Of: odoo/odoo#47169 Forward-Port-Of: odoo/odoo#46069
Original PR description
This PR allows one to build the user documentation with python 3 and sphinx>= 2.4.0. It also removes several warnings. Remove autogenerated JS doc (backport from master) Forward-Port-Of: odoo/odoo#47169 Forward-Port-Of: odoo/odoo#46069
Some option sections are feeling really laggy especialy the theme one. This is due to the "preview" activation of the snippet being triggered on hover and not on enter. Introcuced by: https://github.com/odoo/odoo/pull/36068 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47280 Forward-Port-Of: odoo/odoo#47108
Original PR description
Some option sections are feeling really laggy especialy the theme one. This is due to the "preview" activation of the snippet being triggered on hover and not on enter. Introcuced by: https://github.com/odoo/odoo/pull/36068 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47280 Forward-Port-Of: odoo/odoo#47108
The report layout was refactored before, but we forgot to give the specific German lay-out a name, although the field was added. This gave a traceback when we wanted to select a lay-out or this particular lay-out (name False) in the Settings. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#
Original PR description
The report layout was refactored before, but we forgot to give the specific German lay-out a name, although the field was added. This gave a traceback when we wanted to select a lay-out or this particular lay-out (name False) in the Settings. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47287
Follow-up of d0c852f The parser of `many2one_reference` was not introduced when the new field type was created and then later when the formatter was added, which leads to errors when the web client is trying to set the value of such fields. Since the value of this field is an ID, it is parsed as an integer. Forward-Port-Of: odoo/odoo#47319
Original PR description
Follow-up of d0c852f The parser of `many2one_reference` was not introduced when the new field type was created and then later when the formatter was added, which leads to errors when the web client is trying to set the value of such fields. Since the value of this field is an ID, it is parsed as an integer. Forward-Port-Of: odoo/odoo#47319
This bug is a side effect of the overflow rule for card introduced in this [commit](https://github.com/odoo/odoo/commit/f34d7f4fabe3cd819ed17ea581915107afd00a7f). -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#46829
Original PR description
This bug is a side effect of the overflow rule for card introduced in this [commit](https://github.com/odoo/odoo/commit/f34d7f4fabe3cd819ed17ea581915107afd00a7f). -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#46829
Improve url-picker and countdown url management -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#46640
Original PR description
Improve url-picker and countdown url management -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#46640
Before this commit: If we have a default project in context (for example, when we click on 'planning' button on the kanban view of project), and we create a new shift, the default project is present in context but there are no default task so the project will be erase. After this commit: Even if there are no task on a new shift, the default project value is kept. Forward-Port-Of: odoo/enterprise#9131
Original PR description
Before this commit: If we have a default project in context (for example, when we click on 'planning' button on the kanban view of project), and we create a new shift, the default project is present in context but there are no default task so the project will be erase. After this commit: Even if there are no task on a new shift, the default project value is kept. Forward-Port-Of: odoo/enterprise#9131
Before this commit: In expense, if we change the name of an expense, the product and the price will be overridden by a new default one (comes from the predict of product based on name). But it makes non sense to change already set product when we change the name (for a typo for example) After this commit: We try to predict product when we change the name if they are no already set product. Forward-Port-Of: odoo/enterprise#8670
Original PR description
Before this commit: In expense, if we change the name of an expense, the product and the price will be overridden by a new default one (comes from the predict of product based on name). But it makes non sense to change already set product when we change the name (for a typo for example) After this commit: We try to predict product when we change the name if they are no already set product. Forward-Port-Of: odoo/enterprise#8670
[FIX] l10n_mx_edi: calculate total before saving Install l10n_mx_edi, create a new invoice, create new lines. Before this commit, the total, the taxes, the amount untaxed are not calculated, before saving. Note that, when saving the invoice these fields are calculated. Now, the fields are calculated. opw-2190389 ------------------------------------------------------- [FIX] l10n_mx_edi: saving qty umt Install l10n_mx_edi, create a new invoice with a partner that needs an e
Original PR description
[FIX] l10n_mx_edi: calculate total before saving Install l10n_mx_edi, create a new invoice, create new lines. Before this commit, the total, the taxes, the amount untaxed are not calculated, before saving. Note that, when saving the invoice these fields are calculated. Now, the fields are calculated. opw-2190389 ------------------------------------------------------- [FIX] l10n_mx_edi: saving qty umt Install l10n_mx_edi, create a new invoice with a partner that needs an external trade, create new lines with Qty UMT filled. Before this commit, when saving the invoice the Qty UMT field was emptied. opw-2190389 Forward-Port-Of: odoo/enterprise#9118
- Install industry_fsm - Delete product variant "Field Service" - Install industry_fsm_report An error is raised because of a missing record. Complement of b8ee437232f0506abd0c877c39f40f15046c6c60 opw-2180900 Forward-Port-Of: odoo/enterprise#9113
Original PR description
- Install industry_fsm - Delete product variant "Field Service" - Install industry_fsm_report An error is raised because of a missing record. Complement of b8ee437232f0506abd0c877c39f40f15046c6c60 opw-2180900 Forward-Port-Of: odoo/enterprise#9113
Counterpart of forward-port odoo/odoo#46381 Forward-Port-Of: odoo/enterprise#9101 Forward-Port-Of: odoo/enterprise#9043
Original PR description
Counterpart of forward-port odoo/odoo#46381 Forward-Port-Of: odoo/enterprise#9101 Forward-Port-Of: odoo/enterprise#9043
Steps to reproduce the bug: - Let's consider a user U with no rights in Sales and Accounting - Log with U and open an Helpdesk ticket T - Try to duplicate T Bug: An access error was raised. opw:2201306 Forward-Port-Of: odoo/enterprise#9024 Forward-Port-Of: odoo/enterprise#9007
Original PR description
Steps to reproduce the bug: - Let's consider a user U with no rights in Sales and Accounting - Log with U and open an Helpdesk ticket T - Try to duplicate T Bug: An access error was raised. opw:2201306 Forward-Port-Of: odoo/enterprise#9024 Forward-Port-Of: odoo/enterprise#9007
This are the errors that had been fixed: - CAE due date was added as a an string of datetime, now we add the proper date format that AFIP requires. - Mistype in the afip pos number long, probably added when changing the pos number max sequences from 4 to 5 Before:  After  After  Forward-Port-Of: odoo/enterprise#8620 Forward-Port-Of: odoo/enterprise#8574